Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1322871 > unrolled thread

[PATCH] Staging: speakup: Fix allyesconfig build on mn10300

Back to article view | Back to linux.kernel

Contents

  [PATCH] Staging: speakup: Fix allyesconfig build on mn10300 Samuel Thibault <samuel.thibault@ens-lyon.org> - 2016-02-01 09:10 +0100
    Re: [PATCH] Staging: speakup: Fix allyesconfig build on mn10300 Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-01 21:50 +0100
    Re: [PATCH] Staging: speakup: Fix allyesconfig build on mn10300 Geert Uytterhoeven <geert@linux-m68k.org> - 2016-02-07 10:20 +0100
      Re: [PATCH] Staging: speakup: Fix allyesconfig build on mn10300 Samuel Thibault <samuel.thibault@ens-lyon.org> - 2016-02-07 18:40 +0100
      Re: [PATCH] Staging: speakup: Fix allyesconfig build on mn10300 Samuel Thibault <samuel.thibault@ens-lyon.org> - 2016-02-07 21:30 +0100

#1322871 — [PATCH] Staging: speakup: Fix allyesconfig build on mn10300

mn10300 uses an mmio-driven uart. This is not supported by speakup, so
prevent from enabling it.

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

--- a/drivers/staging/speakup/Kconfig
+++ b/drivers/staging/speakup/Kconfig
@@ -1,7 +1,7 @@
 menu "Speakup console speech"
 
 config SPEAKUP
-	depends on VT
+	depends on VT && !MN10300
 	tristate "Speakup core"
 	---help---
 		This is the Speakup screen reader.  Think of it as a

[toc] | [next] | [standalone]

#1323489

On Mon, Feb 01, 2016 at 09:06:03AM +0100, Samuel Thibault wrote:
> mn10300 uses an mmio-driven uart. This is not supported by speakup, so
> prevent from enabling it.
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> 
> --- a/drivers/staging/speakup/Kconfig
> +++ b/drivers/staging/speakup/Kconfig
> @@ -1,7 +1,7 @@
>  menu "Speakup console speech"
>  
>  config SPEAKUP
> -	depends on VT
> +	depends on VT && !MN10300

Heh, that's funny.  I'll go queue this up, thanks for the patch.

greg k-h

[toc] | [prev] | [next] | [standalone]

#1328449

Hi Samuel,

On Mon, Feb 1, 2016 at 9:06 AM, Samuel Thibault
<samuel.thibault@ens-lyon.org> wrote:
> mn10300 uses an mmio-driven uart. This is not supported by speakup, so
> prevent from enabling it.

Just wondering, what are the symptoms of the failure?
Is it a compile-time or run-time failure?

Is this about drivers/staging/speakup/serialio.c?
I guess there are many other platforms where the UART is MMIO-driven...

> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> --- a/drivers/staging/speakup/Kconfig
> +++ b/drivers/staging/speakup/Kconfig
> @@ -1,7 +1,7 @@
>  menu "Speakup console speech"
>
>  config SPEAKUP
> -       depends on VT
> +       depends on VT && !MN10300
>         tristate "Speakup core"
>         ---help---
>                 This is the Speakup screen reader.  Think of it as a

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[toc] | [prev] | [next] | [standalone]

#1328537

Geert Uytterhoeven, on Sun 07 Feb 2016 10:18:46 +0100, wrote:
> On Mon, Feb 1, 2016 at 9:06 AM, Samuel Thibault
> <samuel.thibault@ens-lyon.org> wrote:
> > mn10300 uses an mmio-driven uart. This is not supported by speakup, so
> > prevent from enabling it.
> 
> Just wondering, what are the symptoms of the failure?

It'll try to request the 0x00-0x08 ports and fail, returning -ENODEV.

> Is it a compile-time or run-time failure?

The fix is for compile-time. run-time failure will already return
-ENODEV.

> Is this about drivers/staging/speakup/serialio.c?

Yes.

This code is to be replaced anyway.

Samuel

[toc] | [prev] | [next] | [standalone]

#1328579

Geert Uytterhoeven, on Sun 07 Feb 2016 10:18:46 +0100, wrote:
> I guess there are many other platforms where the UART is MMIO-driven...

Actually they can't ever get to be exposed to speakup's serialio.c:
their SERIAL_PORT_DFNS would set SERIAL_IO_MEM in the io_type field,
but that field doesn't even exist in serialio.c's old_serial_port, so
serialio.c would actually not even build, so we are on the safe side.

Samuel

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web