Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1324882 > unrolled thread
| Started by | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| First post | 2016-02-03 04:40 +0100 |
| Last post | 2016-02-04 07:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] mmc: dw_mmc-rockchip: remove dw_mci_rockchip_pmops Shawn Lin <shawn.lin@rock-chips.com> - 2016-02-03 04:40 +0100
Re: [PATCH] mmc: dw_mmc-rockchip: remove dw_mci_rockchip_pmops Jaehoon Chung <jh80.chung@samsung.com> - 2016-02-04 07:20 +0100
| From | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| Date | 2016-02-03 04:40 +0100 |
| Subject | [PATCH] mmc: dw_mmc-rockchip: remove dw_mci_rockchip_pmops |
| Message-ID | <qXWsq-4TV-19@gated-at.bofh.it> |
dw_mci_rockchip_pmops just copy-paste what dw_mci_pltfm_pmops
have done. Let's remove it.
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
drivers/mmc/host/dw_mmc-rockchip.c | 22 +---------------------
1 file changed, 1 insertion(+), 21 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
index d9c92f3..3438ab3 100644
--- a/drivers/mmc/host/dw_mmc-rockchip.c
+++ b/drivers/mmc/host/dw_mmc-rockchip.c
@@ -276,33 +276,13 @@ static int dw_mci_rockchip_probe(struct platform_device *pdev)
return dw_mci_pltfm_register(pdev, drv_data);
}
-#ifdef CONFIG_PM_SLEEP
-static int dw_mci_rockchip_suspend(struct device *dev)
-{
- struct dw_mci *host = dev_get_drvdata(dev);
-
- return dw_mci_suspend(host);
-}
-
-static int dw_mci_rockchip_resume(struct device *dev)
-{
- struct dw_mci *host = dev_get_drvdata(dev);
-
- return dw_mci_resume(host);
-}
-#endif /* CONFIG_PM_SLEEP */
-
-static SIMPLE_DEV_PM_OPS(dw_mci_rockchip_pmops,
- dw_mci_rockchip_suspend,
- dw_mci_rockchip_resume);
-
static struct platform_driver dw_mci_rockchip_pltfm_driver = {
.probe = dw_mci_rockchip_probe,
.remove = dw_mci_pltfm_remove,
.driver = {
.name = "dwmmc_rockchip",
.of_match_table = dw_mci_rockchip_match,
- .pm = &dw_mci_rockchip_pmops,
+ .pm = &dw_mci_pltfm_pmops,
},
};
--
2.3.7
[toc] | [next] | [standalone]
| From | Jaehoon Chung <jh80.chung@samsung.com> |
|---|---|
| Date | 2016-02-04 07:20 +0100 |
| Message-ID | <qYlqO-4PS-13@gated-at.bofh.it> |
| In reply to | #1324882 |
Hi, Shawn.
On 02/03/2016 12:26 PM, Shawn Lin wrote:
> dw_mci_rockchip_pmops just copy-paste what dw_mci_pltfm_pmops
> have done. Let's remove it.
Yep, it's possible to remove.
I'm not sure but i want to know there is no plan to add the specific code of rockchip in suspend/resume.
Could you check this?
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
>
> drivers/mmc/host/dw_mmc-rockchip.c | 22 +---------------------
> 1 file changed, 1 insertion(+), 21 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
> index d9c92f3..3438ab3 100644
> --- a/drivers/mmc/host/dw_mmc-rockchip.c
> +++ b/drivers/mmc/host/dw_mmc-rockchip.c
> @@ -276,33 +276,13 @@ static int dw_mci_rockchip_probe(struct platform_device *pdev)
> return dw_mci_pltfm_register(pdev, drv_data);
> }
>
> -#ifdef CONFIG_PM_SLEEP
> -static int dw_mci_rockchip_suspend(struct device *dev)
> -{
> - struct dw_mci *host = dev_get_drvdata(dev);
> -
> - return dw_mci_suspend(host);
> -}
> -
> -static int dw_mci_rockchip_resume(struct device *dev)
> -{
> - struct dw_mci *host = dev_get_drvdata(dev);
> -
> - return dw_mci_resume(host);
> -}
> -#endif /* CONFIG_PM_SLEEP */
> -
> -static SIMPLE_DEV_PM_OPS(dw_mci_rockchip_pmops,
> - dw_mci_rockchip_suspend,
> - dw_mci_rockchip_resume);
> -
> static struct platform_driver dw_mci_rockchip_pltfm_driver = {
> .probe = dw_mci_rockchip_probe,
> .remove = dw_mci_pltfm_remove,
> .driver = {
> .name = "dwmmc_rockchip",
> .of_match_table = dw_mci_rockchip_match,
> - .pm = &dw_mci_rockchip_pmops,
> + .pm = &dw_mci_pltfm_pmops,
> },
> };
>
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web