Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1326376 > unrolled thread

[PATCH v2 02/22] media: Add ALSA Media Controller function entities

Started byShuah Khan <shuahkh@osg.samsung.com>
First post2016-02-04 05:10 +0100
Last post2016-02-04 09:50 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH v2 02/22] media: Add ALSA Media Controller function entities Shuah Khan <shuahkh@osg.samsung.com> - 2016-02-04 05:10 +0100
    Re: [PATCH v2 02/22] media: Add ALSA Media Controller function  entities Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2016-02-04 09:50 +0100

#1326376 — [PATCH v2 02/22] media: Add ALSA Media Controller function entities

FromShuah Khan <shuahkh@osg.samsung.com>
Date2016-02-04 05:10 +0100
Subject[PATCH v2 02/22] media: Add ALSA Media Controller function entities
Message-ID<qYjp0-3uR-11@gated-at.bofh.it>
Add ALSA Media Controller capture, playback, and mixer
function entity defines.

Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
---
 include/uapi/linux/media.h | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h
index ee020e8..7d50480 100644
--- a/include/uapi/linux/media.h
+++ b/include/uapi/linux/media.h
@@ -98,6 +98,17 @@ struct media_device_info {
 #define MEDIA_ENT_F_IF_AUD_DECODER	(MEDIA_ENT_F_BASE + 42)
 
 /*
+ * DOC: Media Controller Next Generation ALSA Function Entities
+ *
+ * MEDIA_ENT_F_AUDIO_CAPTURE - Audio Capture Function
+ * MEDIA_ENT_F_AUDIO_PLAYBACK - Audio Play Back Function
+ * MEDIA_ENT_F_AUDIO_MIXER - Audio Mixer Function
+*/
+#define MEDIA_ENT_F_AUDIO_CAPTURE	(MEDIA_ENT_F_BASE + 200)
+#define MEDIA_ENT_F_AUDIO_PLAYBACK	(MEDIA_ENT_F_BASE + 201)
+#define MEDIA_ENT_F_AUDIO_MIXER		(MEDIA_ENT_F_BASE + 202)
+
+/*
  * Don't touch on those. The ranges MEDIA_ENT_F_OLD_BASE and
  * MEDIA_ENT_F_OLD_SUBDEV_BASE are kept to keep backward compatibility
  * with the legacy v1 API.The number range is out of range by purpose:
-- 
2.5.0

[toc] | [next] | [standalone]


#1326485 — Re: [PATCH v2 02/22] media: Add ALSA Media Controller function entities

FromMauro Carvalho Chehab <mchehab@osg.samsung.com>
Date2016-02-04 09:50 +0100
SubjectRe: [PATCH v2 02/22] media: Add ALSA Media Controller function entities
Message-ID<qYnLX-6cC-5@gated-at.bofh.it>
In reply to#1326376
Em Wed, 03 Feb 2016 21:03:34 -0700
Shuah Khan <shuahkh@osg.samsung.com> escreveu:

> Add ALSA Media Controller capture, playback, and mixer
> function entity defines.
> 
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
>  include/uapi/linux/media.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h
> index ee020e8..7d50480 100644
> --- a/include/uapi/linux/media.h
> +++ b/include/uapi/linux/media.h
> @@ -98,6 +98,17 @@ struct media_device_info {
>  #define MEDIA_ENT_F_IF_AUD_DECODER	(MEDIA_ENT_F_BASE + 42)
>  
>  /*
> + * DOC: Media Controller Next Generation ALSA Function Entities
> + *
> + * MEDIA_ENT_F_AUDIO_CAPTURE - Audio Capture Function
> + * MEDIA_ENT_F_AUDIO_PLAYBACK - Audio Play Back Function
> + * MEDIA_ENT_F_AUDIO_MIXER - Audio Mixer Function
> +*/

Wrong way to document it. Please see my comments to patch 01/22.

> +#define MEDIA_ENT_F_AUDIO_CAPTURE	(MEDIA_ENT_F_BASE + 200)
> +#define MEDIA_ENT_F_AUDIO_PLAYBACK	(MEDIA_ENT_F_BASE + 201)
> +#define MEDIA_ENT_F_AUDIO_MIXER		(MEDIA_ENT_F_BASE + 202)
> +
> +/*
>   * Don't touch on those. The ranges MEDIA_ENT_F_OLD_BASE and
>   * MEDIA_ENT_F_OLD_SUBDEV_BASE are kept to keep backward compatibility
>   * with the legacy v1 API.The number range is out of range by purpose:

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web