Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1328184 > unrolled thread

[PATCH] param-convert-some-on-off-users-to-strtobool fix

Back to article view | Back to linux.kernel

Contents

  [PATCH] param-convert-some-on-off-users-to-strtobool fix Kees Cook <keescook@chromium.org> - 2016-02-06 02:10 +0100

#1328184 — [PATCH] param-convert-some-on-off-users-to-strtobool fix

This converts a missed __setup return (and silences the build warning it
was causing).

Signed-off-by: Kees Cook <keescook@chromium.org>
---
 arch/powerpc/kernel/rtasd.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/powerpc/kernel/rtasd.c b/arch/powerpc/kernel/rtasd.c
index 0ae5cb84d4e2..aa610ce8742f 100644
--- a/arch/powerpc/kernel/rtasd.c
+++ b/arch/powerpc/kernel/rtasd.c
@@ -592,8 +592,6 @@ __setup("surveillance=", surveillance_setup);
 
 static int __init rtasmsgs_setup(char *str)
 {
-	kstrtobool(str, &full_rtas_msgs);
-
-	return 1;
+	return (kstrtobool(str, &full_rtas_msgs) == 0);
 }
 __setup("rtasmsgs=", rtasmsgs_setup);
-- 
2.6.3


-- 
Kees Cook
Chrome OS & Brillo Security

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web