Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1328120 > unrolled thread

[PATCH 4/5] ARM: dts: NSP: Add SP805 Support to DT

Started byJon Mason <jonmason@broadcom.com>
First post2016-02-06 00:00 +0100
Last post2016-02-06 22:40 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 4/5] ARM: dts: NSP: Add SP805 Support to DT Jon Mason <jonmason@broadcom.com> - 2016-02-06 00:00 +0100
    Re: [PATCH 4/5] ARM: dts: NSP: Add SP805 Support to DT Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-02-06 13:50 +0100
      Re: [PATCH 4/5] ARM: dts: NSP: Add SP805 Support to DT Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-02-06 22:40 +0100

#1328120 — [PATCH 4/5] ARM: dts: NSP: Add SP805 Support to DT

FromJon Mason <jonmason@broadcom.com>
Date2016-02-06 00:00 +0100
Subject[PATCH 4/5] ARM: dts: NSP: Add SP805 Support to DT
Message-ID<qYXw6-6sJ-25@gated-at.bofh.it>
Add support for the ARM SP805 Watchdog timer to the Northstar Plus
device tree.

Signed-off-by: Jon Mason <jonmason@broadcom.com>
---
 arch/arm/boot/dts/bcm-nsp.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi
index 415a0a6..0e8cb6e 100644
--- a/arch/arm/boot/dts/bcm-nsp.dtsi
+++ b/arch/arm/boot/dts/bcm-nsp.dtsi
@@ -203,6 +203,14 @@
 			clock-frequency = <100000>;
 		};
 
+		wdt@39000 {
+			compatible = "arm,sp805", "arm,primecell";
+			reg = <0x39000 0x1000>;
+			interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&iprocslow>, <&iprocslow>;
+			clock-names = "wdogclk", "apb_pclk";
+		};
+
 		lcpll0: lcpll0@3f100 {
 			#clock-cells = <1>;
 			compatible = "brcm,nsp-lcpll0";
-- 
1.9.1

[toc] | [next] | [standalone]


#1328296

FromSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date2016-02-06 13:50 +0100
Message-ID<qZatk-7lm-15@gated-at.bofh.it>
In reply to#1328120
Hello.

On 2/6/2016 1:43 AM, Jon Mason wrote:

> Add support for the ARM SP805 Watchdog timer to the Northstar Plus
> device tree.
>
> Signed-off-by: Jon Mason <jonmason@broadcom.com>
> ---
>   arch/arm/boot/dts/bcm-nsp.dtsi | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi
> index 415a0a6..0e8cb6e 100644
> --- a/arch/arm/boot/dts/bcm-nsp.dtsi
> +++ b/arch/arm/boot/dts/bcm-nsp.dtsi
> @@ -203,6 +203,14 @@
>   			clock-frequency = <100000>;
>   		};
>
> +		wdt@39000 {

    Should be "watchdog@39000", according to ePAPR.

[...]

MBR, Sergei

[toc] | [prev] | [next] | [standalone]


#1328376

FromSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date2016-02-06 22:40 +0100
Message-ID<qZiKd-4Pm-1@gated-at.bofh.it>
In reply to#1328296
On 02/06/2016 11:47 PM, Scott Branden wrote:

>             Add support for the ARM SP805 Watchdog timer to the Northstar Plus
>             device tree.
>
>             Signed-off-by: Jon Mason <jonmason@broadcom.com
>             <mailto:jonmason@broadcom.com>>
>             ---
>                arch/arm/boot/dts/bcm-nsp.dtsi | 8 ++++++++
>                1 file changed, 8 insertions(+)
>
>             diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi
>             b/arch/arm/boot/dts/bcm-nsp.dtsi
>             index 415a0a6..0e8cb6e 100644
>             --- a/arch/arm/boot/dts/bcm-nsp.dtsi
>             +++ b/arch/arm/boot/dts/bcm-nsp.dtsi
>             @@ -203,6 +203,14 @@
>                                      clock-frequency = <100000>;
>                              };
>
>             +               wdt@39000 {
>
>
>             Should be "watchdog@39000", according to ePAPR.
>
>
>     Thanks, I'll fix it and send it right out.

> I didn't know ePAPR was a requirement for a linux dtb?  We haven't done this
> with the wtd in other dts files.  Is this described somewhere?

    Nobody reads the docs. Like this:

http://www.devicetree.org/Device_Tree_Usage

    That page refers to the ePAPR 1.0 (not the most recent).

MBR, Sergei

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web