Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1328056 > unrolled thread
| Started by | Bjorn Helgaas <helgaas@kernel.org> |
|---|---|
| First post | 2016-02-05 21:40 +0100 |
| Last post | 2016-02-05 23:30 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] PCI: layerscape: add ls2085a compatible Bjorn Helgaas <helgaas@kernel.org> - 2016-02-05 21:40 +0100
Re: [PATCH] PCI: layerscape: add ls2085a compatible "Shi, Yang" <yang.shi@linaro.org> - 2016-02-05 21:50 +0100
Re: [PATCH] PCI: layerscape: add ls2085a compatible Bjorn Helgaas <helgaas@kernel.org> - 2016-02-05 23:30 +0100
| From | Bjorn Helgaas <helgaas@kernel.org> |
|---|---|
| Date | 2016-02-05 21:40 +0100 |
| Subject | Re: [PATCH] PCI: layerscape: add ls2085a compatible |
| Message-ID | <qYVkB-572-7@gated-at.bofh.it> |
[+cc Rob, et al]
On Wed, Jan 27, 2016 at 09:32:05AM -0800, Yang Shi wrote:
> The layerscape PCI host driver needs recognize ls2085a compatible when using
> firmware with ls2085a compatible property, otherwise the PCI bus won't be
> detected even though ls2085a compatible is included by the dts.
>
> Signed-off-by: Yang Shi <yang.shi@linaro.org>
> ---
> drivers/pci/host/pci-layerscape.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c
> index 3923bed..c40d8b2 100644
> --- a/drivers/pci/host/pci-layerscape.c
> +++ b/drivers/pci/host/pci-layerscape.c
> @@ -203,6 +203,7 @@ static const struct of_device_id ls_pcie_of_match[] = {
> { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata },
> { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata },
> { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
> + { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata },
Hmm, "fsl,ls2085a-pcie" doesn't appear in
Documentation/devicetree/bindings/pci/.
Aren't we supposed to add these strings to the bindings before or at
the same time we add them to drivers?
checkpatch doesn't complain though, so maybe I'm wrong about this.
> { },
> };
> MODULE_DEVICE_TABLE(of, ls_pcie_of_match);
> --
> 2.0.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [next] | [standalone]
| From | "Shi, Yang" <yang.shi@linaro.org> |
|---|---|
| Date | 2016-02-05 21:50 +0100 |
| Message-ID | <qYVui-5aD-13@gated-at.bofh.it> |
| In reply to | #1328056 |
On 2/5/2016 12:38 PM, Bjorn Helgaas wrote:
> [+cc Rob, et al]
>
> On Wed, Jan 27, 2016 at 09:32:05AM -0800, Yang Shi wrote:
>> The layerscape PCI host driver needs recognize ls2085a compatible when using
>> firmware with ls2085a compatible property, otherwise the PCI bus won't be
>> detected even though ls2085a compatible is included by the dts.
>>
>> Signed-off-by: Yang Shi <yang.shi@linaro.org>
>> ---
>> drivers/pci/host/pci-layerscape.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c
>> index 3923bed..c40d8b2 100644
>> --- a/drivers/pci/host/pci-layerscape.c
>> +++ b/drivers/pci/host/pci-layerscape.c
>> @@ -203,6 +203,7 @@ static const struct of_device_id ls_pcie_of_match[] = {
>> { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata },
>> { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata },
>> { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
>> + { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata },
>
> Hmm, "fsl,ls2085a-pcie" doesn't appear in
> Documentation/devicetree/bindings/pci/.
>
> Aren't we supposed to add these strings to the bindings before or at
> the same time we add them to drivers?
The below patch will add it into dts and binding doc. I should mentioned
this in the commit log.
https://patchwork.kernel.org/patch/7767061/
Thanks,
Yang
>
> checkpatch doesn't complain though, so maybe I'm wrong about this.
>
>> { },
>> };
>> MODULE_DEVICE_TABLE(of, ls_pcie_of_match);
>> --
>> 2.0.2
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [prev] | [next] | [standalone]
| From | Bjorn Helgaas <helgaas@kernel.org> |
|---|---|
| Date | 2016-02-05 23:30 +0100 |
| Message-ID | <qYX34-6g3-23@gated-at.bofh.it> |
| In reply to | #1328060 |
On Fri, Feb 05, 2016 at 12:45:25PM -0800, Shi, Yang wrote:
> On 2/5/2016 12:38 PM, Bjorn Helgaas wrote:
> >[+cc Rob, et al]
> >
> >On Wed, Jan 27, 2016 at 09:32:05AM -0800, Yang Shi wrote:
> >>The layerscape PCI host driver needs recognize ls2085a compatible when using
> >>firmware with ls2085a compatible property, otherwise the PCI bus won't be
> >>detected even though ls2085a compatible is included by the dts.
> >>
> >>Signed-off-by: Yang Shi <yang.shi@linaro.org>
> >>---
> >> drivers/pci/host/pci-layerscape.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >>diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c
> >>index 3923bed..c40d8b2 100644
> >>--- a/drivers/pci/host/pci-layerscape.c
> >>+++ b/drivers/pci/host/pci-layerscape.c
> >>@@ -203,6 +203,7 @@ static const struct of_device_id ls_pcie_of_match[] = {
> >> { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata },
> >> { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata },
> >> { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
> >>+ { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata },
> >
> >Hmm, "fsl,ls2085a-pcie" doesn't appear in
> >Documentation/devicetree/bindings/pci/.
> >
> >Aren't we supposed to add these strings to the bindings before or at
> >the same time we add them to drivers?
>
> The below patch will add it into dts and binding doc. I should
> mentioned this in the commit log.
>
> https://patchwork.kernel.org/patch/7767061/
OK. This is really annoying as a reviewer. To me, adding
"fsl,ls2085a-pcie" to:
- the binding in Documentation/devicetree/bindings/pci/layerscape-pci.txt
- the DT in arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
- the driver in drivers/pci/host/pci-layerscape.c
are all logically related, and it would make sense to have them all in
a single patch.
But whatever. I applied this to pci/host-layerscape for v4.6.
> >checkpatch doesn't complain though, so maybe I'm wrong about this.
> >
> >> { },
> >> };
> >> MODULE_DEVICE_TABLE(of, ls_pcie_of_match);
> >>--
> >>2.0.2
> >>
> >>--
> >>To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> >>the body of a message to majordomo@vger.kernel.org
> >>More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web