Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1327687 > unrolled thread

[PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver

Started bySebastian Frias <sf84@laposte.net>
First post2016-02-05 14:40 +0100
Last post2016-02-05 17:00 +0100
Articles 4 on this page of 24 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver Sebastian Frias <sf84@laposte.net> - 2016-02-05 14:40 +0100
    Re: [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver Måns Rullgård <mans@mansr.com> - 2016-02-05 14:40 +0100
      [PATCH v2] net: ethernet: support "fixed-link" DT key/node on nb8800  driver Sebastian Frias <sf84@laposte.net> - 2016-02-05 14:50 +0100
        Re: [PATCH v2] net: ethernet: support "fixed-link" DT key/node on nb8800 driver Måns Rullgård <mans@mansr.com> - 2016-02-05 15:00 +0100
          Re: [PATCH v2] net: ethernet: support "fixed-link" DT key/node on  nb8800 driver Sebastian Frias <sf84@laposte.net> - 2016-02-05 15:10 +0100
            Re: [PATCH v2] net: ethernet: support "fixed-link" DT key/node on nb8800 driver Måns Rullgård <mans@mansr.com> - 2016-02-05 15:20 +0100
              [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800  driver Sebastian Frias <sf84@laposte.net> - 2016-02-05 15:30 +0100
                Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver Måns Rullgård <mans@mansr.com> - 2016-02-05 15:40 +0100
                  Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800  driver Sebastian Frias <sf84@laposte.net> - 2016-02-05 16:00 +0100
                    Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver Måns Rullgård <mans@mansr.com> - 2016-02-05 16:10 +0100
                      Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver Måns Rullgård <mans@mansr.com> - 2016-02-05 16:30 +0100
                        [PATCH v5] net: ethernet: nb8800: support fixed-link DT node Sebastian Frias <sf84@laposte.net> - 2016-02-08 11:30 +0100
                          Re: [PATCH v5] net: ethernet: nb8800: support fixed-link DT node Måns Rullgård <mans@mansr.com> - 2016-02-08 14:20 +0100
                        Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800  driver Sebastian Frias <sf84@laposte.net> - 2016-02-08 11:40 +0100
                          Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver Måns Rullgård <mans@mansr.com> - 2016-02-08 14:40 +0100
                            Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800  driver Mason <slash.tmp@free.fr> - 2016-02-08 15:20 +0100
                              Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800  driver Sebastian Frias <sf84@laposte.net> - 2016-02-08 15:40 +0100
                                Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver Måns Rullgård <mans@mansr.com> - 2016-02-08 15:50 +0100
                            Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800  driver Sebastian Frias <sf84@laposte.net> - 2016-02-08 15:40 +0100
                              Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver Måns Rullgård <mans@mansr.com> - 2016-02-08 16:00 +0100
                      Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800  driver Sebastian Frias <sf84@laposte.net> - 2016-02-05 16:30 +0100
                  [PATCH v4] net: ethernet: nb8800: support fixed-link DT node Sebastian Frias <sf84@laposte.net> - 2016-02-05 16:00 +0100
      Re: [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-05 17:00 +0100
        Re: [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver Måns Rullgård <mans@mansr.com> - 2016-02-05 17:00 +0100

Page 2 of 2 — ← Prev page 1 [2]

#1327839 — Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver

FromSebastian Frias <sf84@laposte.net>
Date2016-02-05 16:30 +0100
SubjectRe: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver
Message-ID<qYQuB-22s-7@gated-at.bofh.it>
In reply to#1327828
On 02/05/2016 04:08 PM, Måns Rullgård wrote:
> Sebastian Frias <sf84@laposte.net> writes:
>
>> On 02/05/2016 03:34 PM, Måns Rullgård wrote:
>>> Sebastian Frias <sf84@laposte.net> writes:
>>>
>>>> Signed-off-by: Sebastian Frias <sf84@laposte.net>
>>>
>>> Please change the subject to something like "net: ethernet: nb8800:
>>> support fixed-link DT node" and add a comment body.
>>
>> The subject is pretty explicit for such a simple patch, what else
>> could I add that wouldn't be unnecessary chat?
>
> It's customary to include a description body even if it's little more
> than a restatement of the subject.  Also, while the subject usually only
> says _what_ the patch does, the body should additionally state _why_ it
> is needed.

I understand, but _why_ it is needed is also obvious in this case; I 
mean, without the patch "fixed-link" cannot be used.
Other patches may not be as obvious/simple and thus justify and require 
more details.

Anyway, I added "Properly handles the case where the PHY is not connected
to the real MDIO bus" would that be ok?

>
>>>> ---
>>>>    drivers/net/ethernet/aurora/nb8800.c | 14 +++++++++++++-
>>>>    1 file changed, 13 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/net/ethernet/aurora/nb8800.c
>>>> b/drivers/net/ethernet/aurora/nb8800.c
>>>> index ecc4a33..e1fb071 100644
>>>> --- a/drivers/net/ethernet/aurora/nb8800.c
>>>> +++ b/drivers/net/ethernet/aurora/nb8800.c
>>>> @@ -1460,7 +1460,19 @@ static int nb8800_probe(struct platform_device *pdev)
>>>>    		goto err_disable_clk;
>>>>    	}
>>>>
>>>> -	priv->phy_node = of_parse_phandle(pdev->dev.of_node, "phy-handle", 0);
>>>> +	if (of_phy_is_fixed_link(pdev->dev.of_node)) {
>>>> +		ret = of_phy_register_fixed_link(pdev->dev.of_node);
>>>> +		if (ret < 0) {
>>>> +			dev_err(&pdev->dev, "bad fixed-link spec\n");
>>>> +			goto err_free_bus;
>>>> +		}
>>>> +		priv->phy_node = of_node_get(pdev->dev.of_node);
>>>> +	}
>>>> +
>>>> +	if (!priv->phy_node)
>>>> +		priv->phy_node = of_parse_phandle(pdev->dev.of_node,
>>>> +						  "phy-handle", 0);
>>>> +
>>>>    	if (!priv->phy_node) {
>>>>    		dev_err(&pdev->dev, "no PHY specified\n");
>>>>    		ret = -ENODEV;
>>>> --
>>>> 2.1.4
>>>
>

[toc] | [prev] | [next] | [standalone]

#1327821 — [PATCH v4] net: ethernet: nb8800: support fixed-link DT node

FromSebastian Frias <sf84@laposte.net>
Date2016-02-05 16:00 +0100
Subject[PATCH v4] net: ethernet: nb8800: support fixed-link DT node
Message-ID<qYQ1A-1Bz-15@gated-at.bofh.it>
In reply to#1327802
Properly handles the case where the PHY is not connected
to the real MDIO bus

Signed-off-by: Sebastian Frias <sf84@laposte.net>
---
  drivers/net/ethernet/aurora/nb8800.c | 14 +++++++++++++-
  1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/aurora/nb8800.c 
b/drivers/net/ethernet/aurora/nb8800.c
index ecc4a33..e1fb071 100644
--- a/drivers/net/ethernet/aurora/nb8800.c
+++ b/drivers/net/ethernet/aurora/nb8800.c
@@ -1460,7 +1460,19 @@ static int nb8800_probe(struct platform_device *pdev)
  		goto err_disable_clk;
  	}

-	priv->phy_node = of_parse_phandle(pdev->dev.of_node, "phy-handle", 0);
+	if (of_phy_is_fixed_link(pdev->dev.of_node)) {
+		ret = of_phy_register_fixed_link(pdev->dev.of_node);
+		if (ret < 0) {
+			dev_err(&pdev->dev, "bad fixed-link spec\n");
+			goto err_free_bus;
+		}
+		priv->phy_node = of_node_get(pdev->dev.of_node);
+	}
+
+	if (!priv->phy_node)
+		priv->phy_node = of_parse_phandle(pdev->dev.of_node,
+						  "phy-handle", 0);
+
  	if (!priv->phy_node) {
  		dev_err(&pdev->dev, "no PHY specified\n");
  		ret = -ENODEV;
-- 
2.1.4

[toc] | [prev] | [next] | [standalone]

#1327855

FromAndy Shevchenko <andy.shevchenko@gmail.com>
Date2016-02-05 17:00 +0100
Message-ID<qYQXD-2cP-5@gated-at.bofh.it>
In reply to#1327689
On Fri, Feb 5, 2016 at 3:39 PM, Måns Rullgård <mans@mansr.com> wrote:
>> +                     if (ret < 0) {
>> +                             dev_err(&pdev->dev, "broken fixed-link specification\n");
>
> Line is longer than 80 chars.

This is actually okay, though I would recommend to move long string
literal to the next line.

-- 
With Best Regards,
Andy Shevchenko

[toc] | [prev] | [next] | [standalone]

#1327861

FromMåns Rullgård <mans@mansr.com>
Date2016-02-05 17:00 +0100
Message-ID<qYQXE-2cP-21@gated-at.bofh.it>
In reply to#1327855
Andy Shevchenko <andy.shevchenko@gmail.com> writes:

> On Fri, Feb 5, 2016 at 3:39 PM, Måns Rullgård <mans@mansr.com> wrote:
>>> +                     if (ret < 0) {
>>> +                             dev_err(&pdev->dev, "broken fixed-link specification\n");
>>
>> Line is longer than 80 chars.
>
> This is actually okay, though I would recommend to move long string
> literal to the next line.

I only mentioned it because fixing it was trivial.

-- 
Måns Rullgård

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web