Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1327326 > unrolled thread

[PATCH V2] i2c: i801: Adding Intel Lewisburg support for iTCO

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH V2] i2c: i801: Adding Intel Lewisburg support for iTCO Alexandra Yates <alexandra.yates@linux.intel.com> - 2016-02-05 00:10 +0100
    Re: [PATCH V2] i2c: i801: Adding Intel Lewisburg support for iTCO Wolfram Sang <wsa@the-dreams.de> - 2016-02-05 00:30 +0100
      Re: [PATCH V2] i2c: i801: Adding Intel Lewisburg support for iTCO Jean Delvare <jdelvare@suse.de> - 2016-02-05 10:50 +0100
        Re: [PATCH V2] i2c: i801: Adding Intel Lewisburg support for iTCO Alexandra Yates <alexandra.yates@linux.intel.com> - 2016-02-05 23:10 +0100
      Re: [PATCH V2] i2c: i801: Adding Intel Lewisburg support for iTCO Alexandra Yates <alexandra.yates@linux.intel.com> - 2016-02-05 23:00 +0100

#1327326 — [PATCH V2] i2c: i801: Adding Intel Lewisburg support for iTCO

Starting from Intel Sunrisepoint (Skylake PCH) the iTCO watchdog
resources have been moved to reside under the i801 SMBus host
controller whereas previously they were under the LPC device.

This patch adds Intel lewisburg SMBus support for iTCO device.

Signed-off-by: Alexandra Yates <alexandra.yates@linux.intel.com>
---
 drivers/i2c/busses/i2c-i801.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index f62d697..27fa0cb 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -1271,6 +1271,8 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id)
 	switch (dev->device) {
 	case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_SMBUS:
 	case PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_SMBUS:
+	case PCI_DEVICE_ID_INTEL_LEWISBURG_SMBUS:
+	case PCI_DEVICE_ID_INTEL_LEWISBURG_SSKU_SMBUS:
 	case PCI_DEVICE_ID_INTEL_DNV_SMBUS:
 		priv->features |= FEATURE_I2C_BLOCK_READ;
 		priv->features |= FEATURE_IRQ;
-- 
1.9.1

[toc] | [next] | [standalone]

#1327346

[Multipart message — attachments visible in raw view] — view raw

On Thu, Feb 04, 2016 at 03:06:55PM -0800, Alexandra Yates wrote:
> Starting from Intel Sunrisepoint (Skylake PCH) the iTCO watchdog
> resources have been moved to reside under the i801 SMBus host
> controller whereas previously they were under the LPC device.
> 
> This patch adds Intel lewisburg SMBus support for iTCO device.
> 
> Signed-off-by: Alexandra Yates <alexandra.yates@linux.intel.com>

Please state what has changed in v2 of this patch?

[toc] | [prev] | [next] | [standalone]

#1327580

On Fri, 5 Feb 2016 00:27:46 +0100, Wolfram Sang wrote:
> On Thu, Feb 04, 2016 at 03:06:55PM -0800, Alexandra Yates wrote:
> > Starting from Intel Sunrisepoint (Skylake PCH) the iTCO watchdog
> > resources have been moved to reside under the i801 SMBus host
> > controller whereas previously they were under the LPC device.
> > 
> > This patch adds Intel lewisburg SMBus support for iTCO device.
> > 
> > Signed-off-by: Alexandra Yates <alexandra.yates@linux.intel.com>
> 
> Please state what has changed in v2 of this patch?

Yes, Alexandra, please always include a changelog (between the ---
separator and the diffstat) when posting patch updates.

In this case there is no code change, the only change is the subject.

If I understand correctly, this is a fixup for commit
cdc5a3110e7c3ae793f367285789a6bc39c962dc ("i2c: i801: add Intel
Lewisburg device IDs") which should have included these changes. If so,
please mention it in the commit message. It may also make sense to tag
the patch for stable [v4.4].

Reviewed-by: Jean Delvare <jdelvare@suse.de>

Thanks,
-- 
Jean Delvare
SUSE L3 Support

[toc] | [prev] | [next] | [standalone]

#1328094

Hi Jean,

Thank you for your review and feedback.

On 02/05/2016 01:48 AM, Jean Delvare wrote:
> On Fri, 5 Feb 2016 00:27:46 +0100, Wolfram Sang wrote:
>> On Thu, Feb 04, 2016 at 03:06:55PM -0800, Alexandra Yates wrote:
>>> Starting from Intel Sunrisepoint (Skylake PCH) the iTCO watchdog
>>> resources have been moved to reside under the i801 SMBus host
>>> controller whereas previously they were under the LPC device.
>>>
>>> This patch adds Intel lewisburg SMBus support for iTCO device.
>>>
>>> Signed-off-by: Alexandra Yates <alexandra.yates@linux.intel.com>
>>
>> Please state what has changed in v2 of this patch?
>
> Yes, Alexandra, please always include a changelog (between the ---
> separator and the diffstat) when posting patch updates.
>
> In this case there is no code change, the only change is the subject.

correct
>
> If I understand correctly, this is a fixup for commit
> cdc5a3110e7c3ae793f367285789a6bc39c962dc ("i2c: i801: add Intel
> Lewisburg device IDs") which should have included these changes. If so,
> please mention it in the commit message. It may also make sense to tag
> the patch for stable [v4.4].

It is an addition to that commit, at the time I submitted the commit I 
wasn't aware that this portion was needed to load dynamically since this 
part of the code was in flux as well.  As it is the driver loads using 
modprobe. I'll add that to the commit message to make it clear and 
resend the patch.

>
> Reviewed-by: Jean Delvare <jdelvare@suse.de>
>
> Thanks,
>

-- 
Thank you,
<Alexandra>

[toc] | [prev] | [next] | [standalone]

#1328093

Hi Wolfram,

On 02/04/2016 03:27 PM, Wolfram Sang wrote:
> On Thu, Feb 04, 2016 at 03:06:55PM -0800, Alexandra Yates wrote:
>> Starting from Intel Sunrisepoint (Skylake PCH) the iTCO watchdog
>> resources have been moved to reside under the i801 SMBus host
>> controller whereas previously they were under the LPC device.
>>
>> This patch adds Intel lewisburg SMBus support for iTCO device.
>>
>> Signed-off-by: Alexandra Yates <alexandra.yates@linux.intel.com>
>
> Please state what has changed in v2 of this patch?
>

The subject line changed I added i2c:i801 per your past request to match 
the subject format for the list.


-- 
Thank you,
<Alexandra>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web