Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1325766 > unrolled thread
| Started by | Marc Zyngier <marc.zyngier@arm.com> |
|---|---|
| First post | 2016-02-03 19:10 +0100 |
| Last post | 2016-02-08 15:50 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v3 20/23] arm64: perf: Count EL2 events if the kernel is running in HYP Marc Zyngier <marc.zyngier@arm.com> - 2016-02-03 19:10 +0100
Re: [PATCH v3 20/23] arm64: perf: Count EL2 events if the kernel is running in HYP Christoffer Dall <christoffer.dall@linaro.org> - 2016-02-04 20:30 +0100
Re: [PATCH v3 20/23] arm64: perf: Count EL2 events if the kernel is running in HYP Marc Zyngier <marc.zyngier@arm.com> - 2016-02-05 10:10 +0100
Re: [PATCH v3 20/23] arm64: perf: Count EL2 events if the kernel is running in HYP Catalin Marinas <catalin.marinas@arm.com> - 2016-02-08 15:50 +0100
| From | Marc Zyngier <marc.zyngier@arm.com> |
|---|---|
| Date | 2016-02-03 19:10 +0100 |
| Subject | [PATCH v3 20/23] arm64: perf: Count EL2 events if the kernel is running in HYP |
| Message-ID | <qYa2o-5r0-47@gated-at.bofh.it> |
When the kernel is running in HYP (with VHE), it is necessary to
include EL2 events if the user requests counting kernel or
hypervisor events.
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
arch/arm64/kernel/perf_event.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
index f7ab14c..6013a38 100644
--- a/arch/arm64/kernel/perf_event.c
+++ b/arch/arm64/kernel/perf_event.c
@@ -20,6 +20,7 @@
*/
#include <asm/irq_regs.h>
+#include <asm/virt.h>
#include <linux/of.h>
#include <linux/perf/arm_pmu.h>
@@ -693,10 +694,15 @@ static int armv8pmu_set_event_filter(struct hw_perf_event *event,
return -EPERM;
if (attr->exclude_user)
config_base |= ARMV8_EXCLUDE_EL0;
- if (attr->exclude_kernel)
- config_base |= ARMV8_EXCLUDE_EL1;
- if (!attr->exclude_hv)
- config_base |= ARMV8_INCLUDE_EL2;
+ if (is_kernel_in_hyp_mode()) {
+ if (!attr->exclude_kernel || !attr->exclude_hv)
+ config_base |= ARMV8_INCLUDE_EL2;
+ } else {
+ if (attr->exclude_kernel)
+ config_base |= ARMV8_EXCLUDE_EL1;
+ if (!attr->exclude_hv)
+ config_base |= ARMV8_INCLUDE_EL2;
+ }
/*
* Install the filter into config_base as this is used to
--
2.1.4
[toc] | [next] | [standalone]
| From | Christoffer Dall <christoffer.dall@linaro.org> |
|---|---|
| Date | 2016-02-04 20:30 +0100 |
| Subject | Re: [PATCH v3 20/23] arm64: perf: Count EL2 events if the kernel is running in HYP |
| Message-ID | <qYxLk-6hi-15@gated-at.bofh.it> |
| In reply to | #1325766 |
On Wed, Feb 03, 2016 at 06:00:13PM +0000, Marc Zyngier wrote:
> When the kernel is running in HYP (with VHE), it is necessary to
> include EL2 events if the user requests counting kernel or
> hypervisor events.
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> arch/arm64/kernel/perf_event.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
> index f7ab14c..6013a38 100644
> --- a/arch/arm64/kernel/perf_event.c
> +++ b/arch/arm64/kernel/perf_event.c
> @@ -20,6 +20,7 @@
> */
>
> #include <asm/irq_regs.h>
> +#include <asm/virt.h>
>
> #include <linux/of.h>
> #include <linux/perf/arm_pmu.h>
> @@ -693,10 +694,15 @@ static int armv8pmu_set_event_filter(struct hw_perf_event *event,
> return -EPERM;
> if (attr->exclude_user)
> config_base |= ARMV8_EXCLUDE_EL0;
> - if (attr->exclude_kernel)
> - config_base |= ARMV8_EXCLUDE_EL1;
> - if (!attr->exclude_hv)
> - config_base |= ARMV8_INCLUDE_EL2;
> + if (is_kernel_in_hyp_mode()) {
> + if (!attr->exclude_kernel || !attr->exclude_hv)
> + config_base |= ARMV8_INCLUDE_EL2;
is exclude_hv a perf generic construct?
is it really correct to count everything the host kernel does (even
unrelated to running VMs) when counting hypervisor events?
Other than my ignorance in this area, this patch looks fine to me.
Thanks,
-Christoffer
> + } else {
> + if (attr->exclude_kernel)
> + config_base |= ARMV8_EXCLUDE_EL1;
> + if (!attr->exclude_hv)
> + config_base |= ARMV8_INCLUDE_EL2;
> + }
>
> /*
> * Install the filter into config_base as this is used to
> --
> 2.1.4
>
[toc] | [prev] | [next] | [standalone]
| From | Marc Zyngier <marc.zyngier@arm.com> |
|---|---|
| Date | 2016-02-05 10:10 +0100 |
| Subject | Re: [PATCH v3 20/23] arm64: perf: Count EL2 events if the kernel is running in HYP |
| Message-ID | <qYKyS-6DW-13@gated-at.bofh.it> |
| In reply to | #1327122 |
On 04/02/16 19:23, Christoffer Dall wrote:
> On Wed, Feb 03, 2016 at 06:00:13PM +0000, Marc Zyngier wrote:
>> When the kernel is running in HYP (with VHE), it is necessary to
>> include EL2 events if the user requests counting kernel or
>> hypervisor events.
>>
>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>> ---
>> arch/arm64/kernel/perf_event.c | 14 ++++++++++----
>> 1 file changed, 10 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm64/kernel/perf_event.c b/arch/arm64/kernel/perf_event.c
>> index f7ab14c..6013a38 100644
>> --- a/arch/arm64/kernel/perf_event.c
>> +++ b/arch/arm64/kernel/perf_event.c
>> @@ -20,6 +20,7 @@
>> */
>>
>> #include <asm/irq_regs.h>
>> +#include <asm/virt.h>
>>
>> #include <linux/of.h>
>> #include <linux/perf/arm_pmu.h>
>> @@ -693,10 +694,15 @@ static int armv8pmu_set_event_filter(struct hw_perf_event *event,
>> return -EPERM;
>> if (attr->exclude_user)
>> config_base |= ARMV8_EXCLUDE_EL0;
>> - if (attr->exclude_kernel)
>> - config_base |= ARMV8_EXCLUDE_EL1;
>> - if (!attr->exclude_hv)
>> - config_base |= ARMV8_INCLUDE_EL2;
>> + if (is_kernel_in_hyp_mode()) {
>> + if (!attr->exclude_kernel || !attr->exclude_hv)
>> + config_base |= ARMV8_INCLUDE_EL2;
>
> is exclude_hv a perf generic construct?
Yes. It seems to be universally used on all architectures.
> is it really correct to count everything the host kernel does (even
> unrelated to running VMs) when counting hypervisor events?
With VHE, the roles are blurred, and the PMU can only count events
occurring when at a given exception level. It has no notion of context.
> Other than my ignorance in this area, this patch looks fine to me.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
[toc] | [prev] | [next] | [standalone]
| From | Catalin Marinas <catalin.marinas@arm.com> |
|---|---|
| Date | 2016-02-08 15:50 +0100 |
| Subject | Re: [PATCH v3 20/23] arm64: perf: Count EL2 events if the kernel is running in HYP |
| Message-ID | <qZViy-6Ep-5@gated-at.bofh.it> |
| In reply to | #1325766 |
On Wed, Feb 03, 2016 at 06:00:13PM +0000, Marc Zyngier wrote: > When the kernel is running in HYP (with VHE), it is necessary to > include EL2 events if the user requests counting kernel or > hypervisor events. > > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web