Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1327106 > unrolled thread

[PATCH V2 0/3] leds: add SN3218 LED driver

Started byStefan Wahren <stefan.wahren@i2se.com>
First post2016-02-04 20:00 +0100
Last post2016-02-05 09:20 +0100
Articles 4 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH V2 0/3] leds: add SN3218 LED driver Stefan Wahren <stefan.wahren@i2se.com> - 2016-02-04 20:00 +0100
    [PATCH V2 2/3] DT: add binding for SN3218 LED driver Stefan Wahren <stefan.wahren@i2se.com> - 2016-02-04 20:00 +0100
    [PATCH V2 1/3] of: Add vendor prefix for Si-En Technology Stefan Wahren <stefan.wahren@i2se.com> - 2016-02-04 20:00 +0100
    Re: [PATCH V2 0/3] leds: add SN3218 LED driver Jacek Anaszewski <j.anaszewski@samsung.com> - 2016-02-05 09:20 +0100

#1327106 — [PATCH V2 0/3] leds: add SN3218 LED driver

FromStefan Wahren <stefan.wahren@i2se.com>
Date2016-02-04 20:00 +0100
Subject[PATCH V2 0/3] leds: add SN3218 LED driver
Message-ID<qYxii-5PO-19@gated-at.bofh.it>
This patch series implements support for the Si-En SN3218
18 Channel LED Driver connected through I2C. The SN3218
doesn't support reading so the LED states are cached in a
regmap.

The driver has been tested on a Raspberry Pi B.

Changes since V1:
  * add shutdown handler
  * use defines for modes
  * remove empty line at the end of binding doc
  * make sn3218_led_init static
  * skip setting default max brightness
  * fix fail sn3218_init

Changes since RFC:
  * using regmap instead of direct I2C
  * add new function to init single LED
  * add module name to Kconfig help
  * replace of_get_property() with of_property_read_string()
  * remove lock, leds_state and name from priv structure
  * drop sn3218 LED name prefix
  * don't use led_info and led_platform_data
  * abort probing if no SN3218 is connected or DT invalid
  * fix some style and text issues
  * fix license
  * move i2c_device_id and of_device_id at the end of file
  * use devm_* calls
  * use device function as node name in DT binding

Stefan Wahren (3):
  of: Add vendor prefix for Si-En Technology
  DT: add binding for SN3218 LED driver
  leds: add SN3218 LED driver

 .../devicetree/bindings/leds/leds-sn3218.txt       |   41 +++
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 drivers/leds/Kconfig                               |   12 +
 drivers/leds/Makefile                              |    1 +
 drivers/leds/leds-sn3218.c                         |  306 ++++++++++++++++++++
 5 files changed, 361 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-sn3218.txt
 create mode 100644 drivers/leds/leds-sn3218.c

-- 
1.7.9.5

[toc] | [next] | [standalone]


#1327109 — [PATCH V2 2/3] DT: add binding for SN3218 LED driver

FromStefan Wahren <stefan.wahren@i2se.com>
Date2016-02-04 20:00 +0100
Subject[PATCH V2 2/3] DT: add binding for SN3218 LED driver
Message-ID<qYxij-5PO-37@gated-at.bofh.it>
In reply to#1327106
This patch adds the binding for Si-En Technology SN3218
18-Channel LED driver.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Acked-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/leds/leds-sn3218.txt       |   41 ++++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-sn3218.txt

diff --git a/Documentation/devicetree/bindings/leds/leds-sn3218.txt b/Documentation/devicetree/bindings/leds/leds-sn3218.txt
new file mode 100644
index 0000000..19cbf57
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/leds-sn3218.txt
@@ -0,0 +1,41 @@
+* Si-En Technology - SN3218 18-Channel LED Driver
+
+Required properties:
+- compatible :
+	"si-en,sn3218"
+- address-cells : must be 1
+- size-cells : must be 0
+- reg : I2C slave address, typically 0x54
+
+There must be at least 1 LED which is represented as a sub-node
+of the sn3218 device.
+
+LED sub-node properties:
+- label : (optional) see Documentation/devicetree/bindings/leds/common.txt
+- reg : number of LED line (could be from 0 to 17)
+- linux,default-trigger : (optional)
+   see Documentation/devicetree/bindings/leds/common.txt
+
+Example:
+
+sn3218: led-controller@54 {
+	compatible = "si-en,sn3218";
+	#address-cells = <1>;
+	#size-cells = <0>;
+	reg = <0x54>;
+
+	led@0 {
+		label = "led1";
+		reg = <0x0>;
+	};
+
+	led@1 {
+		label = "led2";
+		reg = <0x1>;
+	};
+
+	led@2 {
+		label = "led3";
+		reg = <0x2>;
+	};
+};
-- 
1.7.9.5

[toc] | [prev] | [next] | [standalone]


#1327110 — [PATCH V2 1/3] of: Add vendor prefix for Si-En Technology

FromStefan Wahren <stefan.wahren@i2se.com>
Date2016-02-04 20:00 +0100
Subject[PATCH V2 1/3] of: Add vendor prefix for Si-En Technology
Message-ID<qYxii-5PO-33@gated-at.bofh.it>
In reply to#1327106
Si-En Technology is a fabless design house which offers
audio amplifiers, LED drivers and sensors.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Acked-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 72e2c5a..52f22f9 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -204,6 +204,7 @@ seagate	Seagate Technology PLC
 semtech	Semtech Corporation
 sgx	SGX Sensortech
 sharp	Sharp Corporation
+si-en	Si-En Technology Ltd.
 sigma	Sigma Designs, Inc.
 sil	Silicon Image
 silabs	Silicon Laboratories
-- 
1.7.9.5

[toc] | [prev] | [next] | [standalone]


#1327531

FromJacek Anaszewski <j.anaszewski@samsung.com>
Date2016-02-05 09:20 +0100
Message-ID<qYJMu-64X-9@gated-at.bofh.it>
In reply to#1327106
Hi Stefan,

Patch set applied to the for-next branch of linux-leds.git.

Thanks,
Jacek Anaszewski

On 02/04/2016 07:56 PM, Stefan Wahren wrote:
> This patch series implements support for the Si-En SN3218
> 18 Channel LED Driver connected through I2C. The SN3218
> doesn't support reading so the LED states are cached in a
> regmap.
>
> The driver has been tested on a Raspberry Pi B.
>
> Changes since V1:
>    * add shutdown handler
>    * use defines for modes
>    * remove empty line at the end of binding doc
>    * make sn3218_led_init static
>    * skip setting default max brightness
>    * fix fail sn3218_init
>
> Changes since RFC:
>    * using regmap instead of direct I2C
>    * add new function to init single LED
>    * add module name to Kconfig help
>    * replace of_get_property() with of_property_read_string()
>    * remove lock, leds_state and name from priv structure
>    * drop sn3218 LED name prefix
>    * don't use led_info and led_platform_data
>    * abort probing if no SN3218 is connected or DT invalid
>    * fix some style and text issues
>    * fix license
>    * move i2c_device_id and of_device_id at the end of file
>    * use devm_* calls
>    * use device function as node name in DT binding
>
> Stefan Wahren (3):
>    of: Add vendor prefix for Si-En Technology
>    DT: add binding for SN3218 LED driver
>    leds: add SN3218 LED driver
>
>   .../devicetree/bindings/leds/leds-sn3218.txt       |   41 +++
>   .../devicetree/bindings/vendor-prefixes.txt        |    1 +
>   drivers/leds/Kconfig                               |   12 +
>   drivers/leds/Makefile                              |    1 +
>   drivers/leds/leds-sn3218.c                         |  306 ++++++++++++++++++++
>   5 files changed, 361 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/leds/leds-sn3218.txt
>   create mode 100644 drivers/leds/leds-sn3218.c
>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web