Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1327240 > unrolled thread

Re: [PATCH] PCI: layerscape: add ls2085a compatible

Started byBjorn Helgaas <helgaas@kernel.org>
First post2016-02-04 23:40 +0100
Last post2016-02-05 22:20 +0100
Articles 6 — 5 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] PCI: layerscape: add ls2085a compatible Bjorn Helgaas <helgaas@kernel.org> - 2016-02-04 23:40 +0100
    Re: [PATCH] PCI: layerscape: add ls2085a compatible "Shi, Yang" <yang.shi@linaro.org> - 2016-02-05 00:50 +0100
      RE: [PATCH] PCI: layerscape: add ls2085a compatible Bhupesh Sharma <bhupesh.sharma@nxp.com> - 2016-02-05 08:10 +0100
        RE: [PATCH] PCI: layerscape: add ls2085a compatible Minghuan Lian <minghuan.lian@nxp.com> - 2016-02-05 08:40 +0100
          Re: [PATCH] PCI: layerscape: add ls2085a compatible Bjorn Helgaas <helgaas@kernel.org> - 2016-02-05 17:00 +0100
            RE: [PATCH] PCI: layerscape: add ls2085a compatible Yang-Leo Li <leoyang.li@nxp.com> - 2016-02-05 22:20 +0100

#1327240 — Re: [PATCH] PCI: layerscape: add ls2085a compatible

FromBjorn Helgaas <helgaas@kernel.org>
Date2016-02-04 23:40 +0100
SubjectRe: [PATCH] PCI: layerscape: add ls2085a compatible
Message-ID<qYAJc-8hU-5@gated-at.bofh.it>
On Wed, Jan 27, 2016 at 10:05:40AM -0800, Shi, Yang wrote:
> Correct FSL folks email address to nxp.com, sorry for the inconvenience.

Do we need some MAINTAINERS updates in addition to the ack for this patch?
I see a bunch of @freescale.com addresses in MAINTAINERS.

> On 1/27/2016 9:32 AM, Yang Shi wrote:
> >The layerscape PCI host driver needs recognize ls2085a compatible when using
> >firmware with ls2085a compatible property, otherwise the PCI bus won't be
> >detected even though ls2085a compatible is included by the dts.
> >
> >Signed-off-by: Yang Shi <yang.shi@linaro.org>
> >---
> >  drivers/pci/host/pci-layerscape.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> >diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c
> >index 3923bed..c40d8b2 100644
> >--- a/drivers/pci/host/pci-layerscape.c
> >+++ b/drivers/pci/host/pci-layerscape.c
> >@@ -203,6 +203,7 @@ static const struct of_device_id ls_pcie_of_match[] = {
> >  	{ .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata },
> >  	{ .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata },
> >  	{ .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
> >+	{ .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata },
> >  	{ },
> >  };
> >  MODULE_DEVICE_TABLE(of, ls_pcie_of_match);
> >
>

[toc] | [next] | [standalone]

#1327354

From"Shi, Yang" <yang.shi@linaro.org>
Date2016-02-05 00:50 +0100
Message-ID<qYBOV-xk-1@gated-at.bofh.it>
In reply to#1327240
On 2/4/2016 2:37 PM, Bjorn Helgaas wrote:
> On Wed, Jan 27, 2016 at 10:05:40AM -0800, Shi, Yang wrote:
>> Correct FSL folks email address to nxp.com, sorry for the inconvenience.
>
> Do we need some MAINTAINERS updates in addition to the ack for this patch?
> I see a bunch of @freescale.com addresses in MAINTAINERS.

I guess so if the @freescale.com address is not valid anymore.

Thanks,
Yang

>
>> On 1/27/2016 9:32 AM, Yang Shi wrote:
>>> The layerscape PCI host driver needs recognize ls2085a compatible when using
>>> firmware with ls2085a compatible property, otherwise the PCI bus won't be
>>> detected even though ls2085a compatible is included by the dts.
>>>
>>> Signed-off-by: Yang Shi <yang.shi@linaro.org>
>>> ---
>>>   drivers/pci/host/pci-layerscape.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c
>>> index 3923bed..c40d8b2 100644
>>> --- a/drivers/pci/host/pci-layerscape.c
>>> +++ b/drivers/pci/host/pci-layerscape.c
>>> @@ -203,6 +203,7 @@ static const struct of_device_id ls_pcie_of_match[] = {
>>>   	{ .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata },
>>>   	{ .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata },
>>>   	{ .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
>>> +	{ .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata },
>>>   	{ },
>>>   };
>>>   MODULE_DEVICE_TABLE(of, ls_pcie_of_match);
>>>
>>

[toc] | [prev] | [next] | [standalone]

#1327510

FromBhupesh Sharma <bhupesh.sharma@nxp.com>
Date2016-02-05 08:10 +0100
Message-ID<qYIGK-5pB-9@gated-at.bofh.it>
In reply to#1327354
> From: Shi, Yang
> Sent: Friday, February 05, 2016 5:19 AM
> 
> On 2/4/2016 2:37 PM, Bjorn Helgaas wrote:
> > On Wed, Jan 27, 2016 at 10:05:40AM -0800, Shi, Yang wrote:
> >> Correct FSL folks email address to nxp.com, sorry for the
> inconvenience.
> >
> > Do we need some MAINTAINERS updates in addition to the ack for this
> patch?
> > I see a bunch of @freescale.com addresses in MAINTAINERS.
> 
> I guess so if the @freescale.com address is not valid anymore.

All @freescale.com address have shifted to @nxp.com.

Leo, Minghuan - can you kindly review this patch.

Shawn - can you take this through your tree, once Leo and Minghuan have reviewed the code.

Regards,
Bhupesh
 
> 
> >
> >> On 1/27/2016 9:32 AM, Yang Shi wrote:
> >>> The layerscape PCI host driver needs recognize ls2085a compatible
> >>> when using firmware with ls2085a compatible property, otherwise the
> >>> PCI bus won't be detected even though ls2085a compatible is included
> by the dts.
> >>>
> >>> Signed-off-by: Yang Shi <yang.shi@linaro.org>
> >>> ---
> >>>   drivers/pci/host/pci-layerscape.c | 1 +
> >>>   1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/drivers/pci/host/pci-layerscape.c
> >>> b/drivers/pci/host/pci-layerscape.c
> >>> index 3923bed..c40d8b2 100644
> >>> --- a/drivers/pci/host/pci-layerscape.c
> >>> +++ b/drivers/pci/host/pci-layerscape.c
> >>> @@ -203,6 +203,7 @@ static const struct of_device_id
> ls_pcie_of_match[] = {
> >>>   	{ .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata
> },
> >>>   	{ .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata
> },
> >>>   	{ .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata
> },
> >>> +	{ .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata },
> >>>   	{ },
> >>>   };
> >>>   MODULE_DEVICE_TABLE(of, ls_pcie_of_match);
> >>>
> >>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [next] | [standalone]

#1327518

FromMinghuan Lian <minghuan.lian@nxp.com>
Date2016-02-05 08:40 +0100
Message-ID<qYJ9L-5A8-1@gated-at.bofh.it>
In reply to#1327510
The patch is ok to me.

Thanks,
Minghuan

> -----Original Message-----
> From: Bhupesh Sharma
> Sent: Friday, February 05, 2016 1:36 PM
> To: Shi, Yang <yang.shi@linaro.org>; Bjorn Helgaas <helgaas@kernel.org>;
> Yang-Leo Li <leoyang.li@nxp.com>; shawn.guo@linaro.org
> Cc: Mingkai Hu <mingkai.hu@nxp.com>; Minghuan Lian
> <minghuan.lian@nxp.com>; bhelgaas@google.com; linux-pci@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> linaro-kernel@lists.linaro.org
> Subject: RE: [PATCH] PCI: layerscape: add ls2085a compatible
> 
> > From: Shi, Yang
> > Sent: Friday, February 05, 2016 5:19 AM
> >
> > On 2/4/2016 2:37 PM, Bjorn Helgaas wrote:
> > > On Wed, Jan 27, 2016 at 10:05:40AM -0800, Shi, Yang wrote:
> > >> Correct FSL folks email address to nxp.com, sorry for the
> > inconvenience.
> > >
> > > Do we need some MAINTAINERS updates in addition to the ack for this
> > patch?
> > > I see a bunch of @freescale.com addresses in MAINTAINERS.
> >
> > I guess so if the @freescale.com address is not valid anymore.
> 
> All @freescale.com address have shifted to @nxp.com.
> 
> Leo, Minghuan - can you kindly review this patch.
> 
> Shawn - can you take this through your tree, once Leo and Minghuan have
> reviewed the code.
> 
> Regards,
> Bhupesh
> 
> >
> > >
> > >> On 1/27/2016 9:32 AM, Yang Shi wrote:
> > >>> The layerscape PCI host driver needs recognize ls2085a compatible
> > >>> when using firmware with ls2085a compatible property, otherwise
> > >>> the PCI bus won't be detected even though ls2085a compatible is
> > >>> included
> > by the dts.
> > >>>
> > >>> Signed-off-by: Yang Shi <yang.shi@linaro.org>
> > >>> ---
> > >>>   drivers/pci/host/pci-layerscape.c | 1 +
> > >>>   1 file changed, 1 insertion(+)
> > >>>
> > >>> diff --git a/drivers/pci/host/pci-layerscape.c
> > >>> b/drivers/pci/host/pci-layerscape.c
> > >>> index 3923bed..c40d8b2 100644
> > >>> --- a/drivers/pci/host/pci-layerscape.c
> > >>> +++ b/drivers/pci/host/pci-layerscape.c
> > >>> @@ -203,6 +203,7 @@ static const struct of_device_id
> > ls_pcie_of_match[] = {
> > >>>   	{ .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata
> > },
> > >>>   	{ .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata
> > },
> > >>>   	{ .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata
> > },
> > >>> +	{ .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata },
> > >>>   	{ },
> > >>>   };
> > >>>   MODULE_DEVICE_TABLE(of, ls_pcie_of_match);
> > >>>
> > >>
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-pci"
> > in the body of a message to majordomo@vger.kernel.org More majordomo
> > info at http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [next] | [standalone]

#1327858

FromBjorn Helgaas <helgaas@kernel.org>
Date2016-02-05 17:00 +0100
Message-ID<qYQXD-2cP-11@gated-at.bofh.it>
In reply to#1327518
On Fri, Feb 05, 2016 at 06:07:10AM +0000, Minghuan Lian wrote:
> The patch is ok to me.

Thanks, I'll transform that into an ack.

Who's going to post a patch to update MAINTAINERS to fix the
@freescale.com addresses?  If we can get that in for v4.5, it will
save some hassle.

> > -----Original Message-----
> > From: Bhupesh Sharma
> > Sent: Friday, February 05, 2016 1:36 PM
> > To: Shi, Yang <yang.shi@linaro.org>; Bjorn Helgaas <helgaas@kernel.org>;
> > Yang-Leo Li <leoyang.li@nxp.com>; shawn.guo@linaro.org
> > Cc: Mingkai Hu <mingkai.hu@nxp.com>; Minghuan Lian
> > <minghuan.lian@nxp.com>; bhelgaas@google.com; linux-pci@vger.kernel.org;
> > linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > linaro-kernel@lists.linaro.org
> > Subject: RE: [PATCH] PCI: layerscape: add ls2085a compatible
> > 
> > > From: Shi, Yang
> > > Sent: Friday, February 05, 2016 5:19 AM
> > >
> > > On 2/4/2016 2:37 PM, Bjorn Helgaas wrote:
> > > > On Wed, Jan 27, 2016 at 10:05:40AM -0800, Shi, Yang wrote:
> > > >> Correct FSL folks email address to nxp.com, sorry for the
> > > inconvenience.
> > > >
> > > > Do we need some MAINTAINERS updates in addition to the ack for this
> > > patch?
> > > > I see a bunch of @freescale.com addresses in MAINTAINERS.
> > >
> > > I guess so if the @freescale.com address is not valid anymore.
> > 
> > All @freescale.com address have shifted to @nxp.com.
> > 
> > Leo, Minghuan - can you kindly review this patch.
> > 
> > Shawn - can you take this through your tree, once Leo and Minghuan have
> > reviewed the code.
> > 
> > Regards,
> > Bhupesh
> > 
> > >
> > > >
> > > >> On 1/27/2016 9:32 AM, Yang Shi wrote:
> > > >>> The layerscape PCI host driver needs recognize ls2085a compatible
> > > >>> when using firmware with ls2085a compatible property, otherwise
> > > >>> the PCI bus won't be detected even though ls2085a compatible is
> > > >>> included
> > > by the dts.
> > > >>>
> > > >>> Signed-off-by: Yang Shi <yang.shi@linaro.org>
> > > >>> ---
> > > >>>   drivers/pci/host/pci-layerscape.c | 1 +
> > > >>>   1 file changed, 1 insertion(+)
> > > >>>
> > > >>> diff --git a/drivers/pci/host/pci-layerscape.c
> > > >>> b/drivers/pci/host/pci-layerscape.c
> > > >>> index 3923bed..c40d8b2 100644
> > > >>> --- a/drivers/pci/host/pci-layerscape.c
> > > >>> +++ b/drivers/pci/host/pci-layerscape.c
> > > >>> @@ -203,6 +203,7 @@ static const struct of_device_id
> > > ls_pcie_of_match[] = {
> > > >>>   	{ .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata
> > > },
> > > >>>   	{ .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata
> > > },
> > > >>>   	{ .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata
> > > },
> > > >>> +	{ .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata },
> > > >>>   	{ },
> > > >>>   };
> > > >>>   MODULE_DEVICE_TABLE(of, ls_pcie_of_match);
> > > >>>
> > > >>
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-pci"
> > > in the body of a message to majordomo@vger.kernel.org More majordomo
> > > info at http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [next] | [standalone]

#1328078

FromYang-Leo Li <leoyang.li@nxp.com>
Date2016-02-05 22:20 +0100
Message-ID<qYVXk-5zO-19@gated-at.bofh.it>
In reply to#1327858
> On Fri, Feb 05, 2016 at 06:07:10AM +0000, Minghuan Lian wrote:
> > The patch is ok to me.
> 
> Thanks, I'll transform that into an ack.

Also
Acked-by: Li Yang <leoyang.li@nxp.com>

> 
> Who's going to post a patch to update MAINTAINERS to fix the @freescale.com
> addresses?  If we can get that in for v4.5, it will save some hassle.

The @freescale.com address can still reach us for some time(not sure how long though).  I don't know if all the people want to change to an NXP company email address in MAINTAINERS or just update to a personal email address as some already did.

Regards,
Leo

> 
> > > -----Original Message-----
> > > From: Bhupesh Sharma
> > > Sent: Friday, February 05, 2016 1:36 PM
> > > To: Shi, Yang <yang.shi@linaro.org>; Bjorn Helgaas
> > > <helgaas@kernel.org>; Yang-Leo Li <leoyang.li@nxp.com>;
> > > shawn.guo@linaro.org
> > > Cc: Mingkai Hu <mingkai.hu@nxp.com>; Minghuan Lian
> > > <minghuan.lian@nxp.com>; bhelgaas@google.com;
> > > linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org;
> > > linux-arm-kernel@lists.infradead.org;
> > > linaro-kernel@lists.linaro.org
> > > Subject: RE: [PATCH] PCI: layerscape: add ls2085a compatible
> > >
> > > > From: Shi, Yang
> > > > Sent: Friday, February 05, 2016 5:19 AM
> > > >
> > > > On 2/4/2016 2:37 PM, Bjorn Helgaas wrote:
> > > > > On Wed, Jan 27, 2016 at 10:05:40AM -0800, Shi, Yang wrote:
> > > > >> Correct FSL folks email address to nxp.com, sorry for the
> > > > inconvenience.
> > > > >
> > > > > Do we need some MAINTAINERS updates in addition to the ack for
> > > > > this
> > > > patch?
> > > > > I see a bunch of @freescale.com addresses in MAINTAINERS.
> > > >
> > > > I guess so if the @freescale.com address is not valid anymore.
> > >
> > > All @freescale.com address have shifted to @nxp.com.
> > >
> > > Leo, Minghuan - can you kindly review this patch.
> > >
> > > Shawn - can you take this through your tree, once Leo and Minghuan
> > > have reviewed the code.
> > >
> > > Regards,
> > > Bhupesh
> > >
> > > >
> > > > >
> > > > >> On 1/27/2016 9:32 AM, Yang Shi wrote:
> > > > >>> The layerscape PCI host driver needs recognize ls2085a
> > > > >>> compatible when using firmware with ls2085a compatible
> > > > >>> property, otherwise the PCI bus won't be detected even though
> > > > >>> ls2085a compatible is included
> > > > by the dts.
> > > > >>>
> > > > >>> Signed-off-by: Yang Shi <yang.shi@linaro.org>
> > > > >>> ---
> > > > >>>   drivers/pci/host/pci-layerscape.c | 1 +
> > > > >>>   1 file changed, 1 insertion(+)
> > > > >>>
> > > > >>> diff --git a/drivers/pci/host/pci-layerscape.c
> > > > >>> b/drivers/pci/host/pci-layerscape.c
> > > > >>> index 3923bed..c40d8b2 100644
> > > > >>> --- a/drivers/pci/host/pci-layerscape.c
> > > > >>> +++ b/drivers/pci/host/pci-layerscape.c
> > > > >>> @@ -203,6 +203,7 @@ static const struct of_device_id
> > > > ls_pcie_of_match[] = {
> > > > >>>   	{ .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata
> > > > },
> > > > >>>   	{ .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata
> > > > },
> > > > >>>   	{ .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata
> > > > },
> > > > >>> +	{ .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata
> > > > >>> +},
> > > > >>>   	{ },
> > > > >>>   };
> > > > >>>   MODULE_DEVICE_TABLE(of, ls_pcie_of_match);
> > > > >>>
> > > > >>
> > > >
> > > > --
> > > > To unsubscribe from this list: send the line "unsubscribe linux-pci"
> > > > in the body of a message to majordomo@vger.kernel.org More
> > > > majordomo info at http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web