Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1324592 > unrolled thread

[RFC 07/12] sh, rwsem: provide __down_write_killable

Started byMichal Hocko <mhocko@kernel.org>
First post2016-02-02 21:30 +0100
Last post2016-02-03 13:20 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [RFC 07/12] sh, rwsem: provide __down_write_killable Michal Hocko <mhocko@kernel.org> - 2016-02-02 21:30 +0100
    Re: [RFC 07/12] sh, rwsem: provide __down_write_killable Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-02-03 12:20 +0100
      Re: [RFC 07/12] sh, rwsem: provide __down_write_killable Michal Hocko <mhocko@kernel.org> - 2016-02-03 13:20 +0100

#1324592 — [RFC 07/12] sh, rwsem: provide __down_write_killable

FromMichal Hocko <mhocko@kernel.org>
Date2016-02-02 21:30 +0100
Subject[RFC 07/12] sh, rwsem: provide __down_write_killable
Message-ID<qXPKi-8sh-9@gated-at.bofh.it>
From: Michal Hocko <mhocko@suse.com>

which is uses the same fast path as __down_write except it falls back to
rwsem_down_write_failed_killable slow path and return -EINTR if killed.

Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 arch/sh/include/asm/rwsem.h | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/sh/include/asm/rwsem.h b/arch/sh/include/asm/rwsem.h
index f6c951c7a875..8a457b83d2a5 100644
--- a/arch/sh/include/asm/rwsem.h
+++ b/arch/sh/include/asm/rwsem.h
@@ -54,6 +54,19 @@ static inline void __down_write(struct rw_semaphore *sem)
 		rwsem_down_write_failed(sem);
 }
 
+static inline int __down_write_killable(struct rw_semaphore *sem)
+{
+	int tmp;
+
+	tmp = atomic_add_return(RWSEM_ACTIVE_WRITE_BIAS,
+				(atomic_t *)(&sem->count));
+	if (tmp != RWSEM_ACTIVE_WRITE_BIAS)
+		if (IS_ERR(rwsem_down_write_failed_killable(sem)))
+			return -EINTR;
+
+	return 0;
+}
+
 static inline int __down_write_trylock(struct rw_semaphore *sem)
 {
 	int tmp;
-- 
2.7.0

[toc] | [next] | [standalone]


#1325219

FromSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date2016-02-03 12:20 +0100
Message-ID<qY3DA-1cM-3@gated-at.bofh.it>
In reply to#1324592
Hello.

On 2/2/2016 11:19 PM, Michal Hocko wrote:

> From: Michal Hocko <mhocko@suse.com>
>
> which is uses the same fast path as __down_write except it falls back to

    s/is//. Same typo (?) in the other patches...

> rwsem_down_write_failed_killable slow path and return -EINTR if killed.
>
> Signed-off-by: Michal Hocko <mhocko@suse.com>

[...]

MBR, Sergei

[toc] | [prev] | [next] | [standalone]


#1325325

FromMichal Hocko <mhocko@kernel.org>
Date2016-02-03 13:20 +0100
Message-ID<qY4zE-1Ok-13@gated-at.bofh.it>
In reply to#1325219
On Wed 03-02-16 14:19:05, Sergei Shtylyov wrote:
> Hello.
> 
> On 2/2/2016 11:19 PM, Michal Hocko wrote:
> 
> >From: Michal Hocko <mhocko@suse.com>
> >
> >which is uses the same fast path as __down_write except it falls back to
> 
>    s/is//. Same typo (?) in the other patches...

Thanks will fix that.

> 
> >rwsem_down_write_failed_killable slow path and return -EINTR if killed.
> >
> >Signed-off-by: Michal Hocko <mhocko@suse.com>
> 
> [...]
> 
> MBR, Sergei
> 

-- 
Michal Hocko
SUSE Labs

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web