Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1323682 > unrolled thread

Re: [PATCH 4.3.y] crypto: fix test vector for rsa

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 4.3.y] crypto: fix test vector for rsa Greg KH <gregkh@linuxfoundation.org> - 2016-02-02 02:00 +0100
    Re: [PATCH 4.3.y] crypto: fix test vector for rsa Herbert Xu <herbert@gondor.apana.org.au> - 2016-02-02 04:30 +0100

#1323682 — Re: [PATCH 4.3.y] crypto: fix test vector for rsa

On Wed, Jan 13, 2016 at 08:57:40PM -0800, Tadeusz Struk wrote:
> Hi,
> After the fix to the asn1_decoder in commit: 0d62e9dd
> "ASN.1: Fix non-match detection failure on data overrun"
> the rsa algorithm is failing to register in 4.3 stable kernels with
> error: "alg: rsa: test failed on vector 4, err=-74"
> 
> This happens because the asn1 definition for the rsa key that has been
> added in 4.2 defined all 3 components of the key as non-optional, as
> the asn1_decoder before the fix was working fine for both the private
> and public keys.
> 
> This patch adds the missing (fake) component to one key vector to allow
> the algorithm to successfully register and be used with a valid private
> keys later. This is only to make the asn1_decoder successfully parse the
> key and the fake component is never used in the test as the vector is
> marked as public key.
> 
> This patch applies only to 4.3 kernels as the 4.2 version of asn1_decoder
> works fine with the asn1 definition.
> 4.4 is also ok because the akcipher interface has been changed, and
> the set_key function has been split into set_public_key and set_priv_key
> and there are two separate asn1 definitions for the two key formats
> with all the required components correctly defined (commit 22287b0).
> 
> Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
> ---
> diff --git a/crypto/testmgr.h b/crypto/testmgr.h
> index 64b8a80..450f30e 100644
> --- a/crypto/testmgr.h
> +++ b/crypto/testmgr.h
> @@ -270,7 +270,7 @@ static struct akcipher_testvec rsa_tv_template[] = {
>  	.c_size = 256,
>  	}, {
>  	.key =
> -	"\x30\x82\x01\x09" /* sequence of 265 bytes */
> +	"\x30\x82\x01\x0C" /* sequence of 268 bytes */
>  	"\x02\x82\x01\x00" /* modulus - integer of 256 bytes */
>  	"\xDB\x10\x1A\xC2\xA3\xF1\xDC\xFF\x13\x6B\xED\x44\xDF\xF0\x02\x6D"
>  	"\x13\xC7\x88\xDA\x70\x6B\x54\xF1\xE8\x27\xDC\xC3\x0F\x99\x6A\xFA"
> @@ -288,8 +288,9 @@ static struct akcipher_testvec rsa_tv_template[] = {
>  	"\x55\xE6\x29\x69\xD1\xC2\xE8\xB9\x78\x59\xF6\x79\x10\xC6\x4E\xEB"
>  	"\x6A\x5E\xB9\x9A\xC7\xC4\x5B\x63\xDA\xA3\x3F\x5E\x92\x7A\x81\x5E"
>  	"\xD6\xB0\xE2\x62\x8F\x74\x26\xC2\x0C\xD3\x9A\x17\x47\xE6\x8E\xAB"
> -	"\x02\x03\x01\x00\x01", /* public key - integer of 3 bytes */
> -	.key_len = 269,
> +	"\x02\x03\x01\x00\x01" /* public key - integer of 3 bytes */
> +	"\x02\x01\x00", /* private key - integer of 1 byte */
> +	.key_len = 272,
>  	.m = "\x54\x85\x9b\x34\x2c\x49\xea\x2a",
>  	.c =
>  	"\xb2\x97\x76\xb4\xae\x3e\x38\x3c\x7e\x64\x1f\xcc\xa2\x7f\xf6\xbe"
> 

I need an ack from the maintainer of this subsystem before I can take a
patch that is not already upstream in Linus's tree...

thanks,

greg k-h

[toc] | [next] | [standalone]

#1323760

On Mon, Feb 01, 2016 at 04:52:53PM -0800, Greg KH wrote:
> On Wed, Jan 13, 2016 at 08:57:40PM -0800, Tadeusz Struk wrote:
> > Hi,
> > After the fix to the asn1_decoder in commit: 0d62e9dd
> > "ASN.1: Fix non-match detection failure on data overrun"
> > the rsa algorithm is failing to register in 4.3 stable kernels with
> > error: "alg: rsa: test failed on vector 4, err=-74"
> > 
> > This happens because the asn1 definition for the rsa key that has been
> > added in 4.2 defined all 3 components of the key as non-optional, as
> > the asn1_decoder before the fix was working fine for both the private
> > and public keys.
> > 
> > This patch adds the missing (fake) component to one key vector to allow
> > the algorithm to successfully register and be used with a valid private
> > keys later. This is only to make the asn1_decoder successfully parse the
> > key and the fake component is never used in the test as the vector is
> > marked as public key.
> > 
> > This patch applies only to 4.3 kernels as the 4.2 version of asn1_decoder
> > works fine with the asn1 definition.
> > 4.4 is also ok because the akcipher interface has been changed, and
> > the set_key function has been split into set_public_key and set_priv_key
> > and there are two separate asn1 definitions for the two key formats
> > with all the required components correctly defined (commit 22287b0).
> > 
> > Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
> > ---
> > diff --git a/crypto/testmgr.h b/crypto/testmgr.h
> > index 64b8a80..450f30e 100644
> > --- a/crypto/testmgr.h
> > +++ b/crypto/testmgr.h
> > @@ -270,7 +270,7 @@ static struct akcipher_testvec rsa_tv_template[] = {
> >  	.c_size = 256,
> >  	}, {
> >  	.key =
> > -	"\x30\x82\x01\x09" /* sequence of 265 bytes */
> > +	"\x30\x82\x01\x0C" /* sequence of 268 bytes */
> >  	"\x02\x82\x01\x00" /* modulus - integer of 256 bytes */
> >  	"\xDB\x10\x1A\xC2\xA3\xF1\xDC\xFF\x13\x6B\xED\x44\xDF\xF0\x02\x6D"
> >  	"\x13\xC7\x88\xDA\x70\x6B\x54\xF1\xE8\x27\xDC\xC3\x0F\x99\x6A\xFA"
> > @@ -288,8 +288,9 @@ static struct akcipher_testvec rsa_tv_template[] = {
> >  	"\x55\xE6\x29\x69\xD1\xC2\xE8\xB9\x78\x59\xF6\x79\x10\xC6\x4E\xEB"
> >  	"\x6A\x5E\xB9\x9A\xC7\xC4\x5B\x63\xDA\xA3\x3F\x5E\x92\x7A\x81\x5E"
> >  	"\xD6\xB0\xE2\x62\x8F\x74\x26\xC2\x0C\xD3\x9A\x17\x47\xE6\x8E\xAB"
> > -	"\x02\x03\x01\x00\x01", /* public key - integer of 3 bytes */
> > -	.key_len = 269,
> > +	"\x02\x03\x01\x00\x01" /* public key - integer of 3 bytes */
> > +	"\x02\x01\x00", /* private key - integer of 1 byte */
> > +	.key_len = 272,
> >  	.m = "\x54\x85\x9b\x34\x2c\x49\xea\x2a",
> >  	.c =
> >  	"\xb2\x97\x76\xb4\xae\x3e\x38\x3c\x7e\x64\x1f\xcc\xa2\x7f\xf6\xbe"
> > 
> 
> I need an ack from the maintainer of this subsystem before I can take a
> patch that is not already upstream in Linus's tree...

Acked-by: Herbert Xu <herbert@gondor.apana.org.au>

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web