Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1323739 > unrolled thread

[PATCH v2 0/5] alienware-wmi new platform and feature support

Started byMario Limonciello <mario_limonciello@dell.com>
First post2016-02-02 03:40 +0100
Last post2016-02-02 18:40 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH v2 0/5] alienware-wmi new platform and feature support Mario Limonciello <mario_limonciello@dell.com> - 2016-02-02 03:40 +0100
    Re: [PATCH v2 0/5] alienware-wmi new platform and feature support Darren Hart <dvhart@infradead.org> - 2016-02-02 18:40 +0100

#1323739 — [PATCH v2 0/5] alienware-wmi new platform and feature support

FromMario Limonciello <mario_limonciello@dell.com>
Date2016-02-02 03:40 +0100
Subject[PATCH v2 0/5] alienware-wmi new platform and feature support
Message-ID<qXz2O-3Wf-9@gated-at.bofh.it>
I've got some extensions for the alienware-wmi driver that have
been introduced for a few new platforms and can be controlled via the WMI
interface.

Changes from V1:
 - Make sure whitespace changes are in their own patch
 - Add commit descriptions to all patches
 - Allow one line to go over 80 characters in deep sleep control patch
   Other patches may have some areas that avoid going over 80 characters
   still, but this matches the style of the existing driver.  If you would
   like these to go over 80 characters as well, please comment which areas
   this is OK.

Mario Limonciello (5):
  Clean up whitespace for ASM100 platform
  Add support for new platform: X51-R3
  Add initial support for alienware graphics amplifier.
  Add support for deep sleep control.
  Add support for two new systems: ASM200 and ASM201.

 drivers/platform/x86/alienware-wmi.c | 282 +++++++++++++++++++++++++++++++----
 1 file changed, 250 insertions(+), 32 deletions(-)

-- 
1.9.1

[toc] | [next] | [standalone]


#1324318

FromDarren Hart <dvhart@infradead.org>
Date2016-02-02 18:40 +0100
Message-ID<qXN5L-6qA-9@gated-at.bofh.it>
In reply to#1323739
On Mon, Feb 01, 2016 at 08:28:46PM -0600, Mario Limonciello wrote:
> I've got some extensions for the alienware-wmi driver that have
> been introduced for a few new platforms and can be controlled via the WMI
> interface.
> 
> Changes from V1:
>  - Make sure whitespace changes are in their own patch
>  - Add commit descriptions to all patches
>  - Allow one line to go over 80 characters in deep sleep control patch
>    Other patches may have some areas that avoid going over 80 characters
>    still, but this matches the style of the existing driver.  If you would
>    like these to go over 80 characters as well, please comment which areas
>    this is OK.

This made it much easier to review. Thank you Mario. A few changes requested,
and a couple questions for you regarding intent/best-practice.

Thanks!

-- 
Darren Hart
Intel Open Source Technology Center

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web