Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1322446 > unrolled thread

Re: [PATCH V7 2/8] mfd: max77620: add core driver for MAX77620/MAX20024

Started byLaxman Dewangan <ldewangan@nvidia.com>
First post2016-01-30 18:30 +0100
Last post2016-02-01 10:30 +0100
Articles 5 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH V7 2/8] mfd: max77620: add core driver for MAX77620/MAX20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-30 18:30 +0100
    Re: [PATCH V7 2/8] mfd: max77620: add core driver for  MAX77620/MAX20024 Lee Jones <lee.jones@linaro.org> - 2016-02-01 09:30 +0100
      Re: [PATCH V7 2/8] mfd: max77620: add core driver for MAX77620/MAX20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-01 09:50 +0100
        Re: [PATCH V7 2/8] mfd: max77620: add core driver for  MAX77620/MAX20024 Lee Jones <lee.jones@linaro.org> - 2016-02-01 10:10 +0100
          Re: [PATCH V7 2/8] mfd: max77620: add core driver for MAX77620/MAX20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-01 10:30 +0100

#1322446 — Re: [PATCH V7 2/8] mfd: max77620: add core driver for MAX77620/MAX20024

FromLaxman Dewangan <ldewangan@nvidia.com>
Date2016-01-30 18:30 +0100
SubjectRe: [PATCH V7 2/8] mfd: max77620: add core driver for MAX77620/MAX20024
Message-ID<qWHvs-7bS-11@gated-at.bofh.it>
This depends on patch
[PATCH V2] mfd: core: add macro for adding mfd cells

and due to absence of this patch, it reports the error.



On Saturday 30 January 2016 10:46 PM, kbuild test robot wrote:
> Hi Laxman,
>
> [auto build test ERROR on pinctrl/for-next]
> [also build test ERROR on v4.5-rc1 next-20160129]
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
>
> url:    https://github.com/0day-ci/linux/commits/Laxman-Dewangan/Add-support-for-MAXIM-MAX77620-MAX20024-PMIC/20160131-005355
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git for-next
> config: i386-allmodconfig (attached as .config)
> reproduce:
>          # save the attached .config to linux build tree
>          make ARCH=i386
>
> All errors (new ones prefixed by >>):
>
>>> drivers/mfd/max77620.c:57:2: error: implicit declaration of function 'DEFINE_MFD_CELL_NAME' [-Werror=implicit-function-declaration]
>       DEFINE_MFD_CELL_NAME("max77620-pinctrl"),
>       ^
>>> drivers/mfd/max77620.c:57:2: error: initializer element is not constant
>     drivers/mfd/max77620.c:57:2: note: (near initialization for 'max77620_children[0].name')
>>> drivers/mfd/max77620.c:58:2: error: implicit declaration of function 'DEFINE_MFD_CELL_NAME_RESOURCE' [-Werror=implicit-function-declaration]
>       DEFINE_MFD_CELL_NAME_RESOURCE("max77620-gpio", gpio_resources),
>       ^
>     drivers/mfd/max77620.c:58:2: error: initializer element is not constant
>     drivers/mfd/max77620.c:58:2: note: (near initialization for 'max77620_children[0].id')
>     drivers/mfd/max77620.c:59:2: error: initializer element is not constant
>       DEFINE_MFD_CELL_NAME("max77620-pmic"),
>       ^
>     drivers/mfd/max77620.c:59:2: note: (near initialization for 'max77620_children[0].usage_count')
>     drivers/mfd/max77620.c:60:2: error: initializer element is not constant
>       DEFINE_MFD_CELL_NAME_RESOURCE("max77620-rtc", rtc_resources),
>       ^
>     drivers/mfd/max77620.c:60:2: note: (near initialization for 'max77620_children[0].enable')
>     drivers/mfd/max77620.c:61:2: error: initializer element is not constant
>       DEFINE_MFD_CELL_NAME_RESOURCE("max77620-power", power_resources),
>       ^
>     drivers/mfd/max77620.c:61:2: note: (near initialization for 'max77620_children[0].disable')
>     drivers/mfd/max77620.c:62:2: error: initializer element is not constant
>       DEFINE_MFD_CELL_NAME("max77620-watchdog"),
>       ^
>     drivers/mfd/max77620.c:62:2: note: (near initialization for 'max77620_children[0].suspend')
>     drivers/mfd/max77620.c:63:2: error: initializer element is not constant
>       DEFINE_MFD_CELL_NAME("max77620-clock"),
>       ^
>     drivers/mfd/max77620.c:63:2: note: (near initialization for 'max77620_children[0].resume')
>     drivers/mfd/max77620.c:64:2: error: initializer element is not constant
>       DEFINE_MFD_CELL_NAME_RESOURCE("max77620-thermal", thermal_resources),
>       ^
>     drivers/mfd/max77620.c:64:2: note: (near initialization for 'max77620_children[0].platform_data')
>     drivers/mfd/max77620.c:68:2: error: initializer element is not constant
>       DEFINE_MFD_CELL_NAME("max20024-pinctrl"),
>       ^
>     drivers/mfd/max77620.c:68:2: note: (near initialization for 'max20024_children[0].name')
>     drivers/mfd/max77620.c:69:2: error: initializer element is not constant
>       DEFINE_MFD_CELL_NAME_RESOURCE("max20024-gpio", gpio_resources),
>       ^
>     drivers/mfd/max77620.c:69:2: note: (near initialization for 'max20024_children[0].id')
>     drivers/mfd/max77620.c:70:2: error: initializer element is not constant
>       DEFINE_MFD_CELL_NAME("max20024-pmic"),
>       ^
>     drivers/mfd/max77620.c:70:2: note: (near initialization for 'max20024_children[0].usage_count')
>     drivers/mfd/max77620.c:71:2: error: initializer element is not constant
>       DEFINE_MFD_CELL_NAME_RESOURCE("max20024-rtc", rtc_resources),
>       ^
>     drivers/mfd/max77620.c:71:2: note: (near initialization for 'max20024_children[0].enable')
>     drivers/mfd/max77620.c:72:2: error: initializer element is not constant
>       DEFINE_MFD_CELL_NAME_RESOURCE("max20024-power", power_resources),
>       ^
>     drivers/mfd/max77620.c:72:2: note: (near initialization for 'max20024_children[0].disable')
>     drivers/mfd/max77620.c:73:2: error: initializer element is not constant
>       DEFINE_MFD_CELL_NAME("max20024-watchdog"),
>       ^
>     drivers/mfd/max77620.c:73:2: note: (near initialization for 'max20024_children[0].suspend')
>     drivers/mfd/max77620.c:74:2: error: initializer element is not constant
>       DEFINE_MFD_CELL_NAME("max20024-clock"),
>       ^
>     drivers/mfd/max77620.c:74:2: note: (near initialization for 'max20024_children[0].resume')
>     cc1: some warnings being treated as errors
>
> vim +/DEFINE_MFD_CELL_NAME +57 drivers/mfd/max77620.c
>
>      51		REGMAP_IRQ_REG(MAX77620_IRQ_LBT_MBATLOW, 1, MAX77620_IRQ_LBM_MASK),
>      52		REGMAP_IRQ_REG(MAX77620_IRQ_LBT_TJALRM1, 1, MAX77620_IRQ_TJALRM1_MASK),
>      53		REGMAP_IRQ_REG(MAX77620_IRQ_LBT_TJALRM2, 1, MAX77620_IRQ_TJALRM2_MASK),
>      54	};
>      55	
>      56	static struct mfd_cell max77620_children[] = {
>    > 57		DEFINE_MFD_CELL_NAME("max77620-pinctrl"),
>    > 58		DEFINE_MFD_CELL_NAME_RESOURCE("max77620-gpio", gpio_resources),
>      59		DEFINE_MFD_CELL_NAME("max77620-pmic"),
>      60		DEFINE_MFD_CELL_NAME_RESOURCE("max77620-rtc", rtc_resources),
>      61		DEFINE_MFD_CELL_NAME_RESOURCE("max77620-power", power_resources),
>
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [next] | [standalone]

#1322894 — Re: [PATCH V7 2/8] mfd: max77620: add core driver for MAX77620/MAX20024

FromLee Jones <lee.jones@linaro.org>
Date2016-02-01 09:30 +0100
SubjectRe: [PATCH V7 2/8] mfd: max77620: add core driver for MAX77620/MAX20024
Message-ID<qXi1Z-8lp-25@gated-at.bofh.it>
In reply to#1322446
On Sat, 30 Jan 2016, Laxman Dewangan wrote:

> This depends on patch
> [PATCH V2] mfd: core: add macro for adding mfd cells
> 
> and due to absence of this patch, it reports the error.

If you have dependencies, why aren't they in this set?

> On Saturday 30 January 2016 10:46 PM, kbuild test robot wrote:
> >Hi Laxman,
> >
> >[auto build test ERROR on pinctrl/for-next]
> >[also build test ERROR on v4.5-rc1 next-20160129]
> >[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
> >
> >url:    https://github.com/0day-ci/linux/commits/Laxman-Dewangan/Add-support-for-MAXIM-MAX77620-MAX20024-PMIC/20160131-005355
> >base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git for-next
> >config: i386-allmodconfig (attached as .config)
> >reproduce:
> >         # save the attached .config to linux build tree
> >         make ARCH=i386
> >
> >All errors (new ones prefixed by >>):
> >
> >>>drivers/mfd/max77620.c:57:2: error: implicit declaration of function 'DEFINE_MFD_CELL_NAME' [-Werror=implicit-function-declaration]
> >      DEFINE_MFD_CELL_NAME("max77620-pinctrl"),
> >      ^
> >>>drivers/mfd/max77620.c:57:2: error: initializer element is not constant
> >    drivers/mfd/max77620.c:57:2: note: (near initialization for 'max77620_children[0].name')
> >>>drivers/mfd/max77620.c:58:2: error: implicit declaration of function 'DEFINE_MFD_CELL_NAME_RESOURCE' [-Werror=implicit-function-declaration]
> >      DEFINE_MFD_CELL_NAME_RESOURCE("max77620-gpio", gpio_resources),
> >      ^
> >    drivers/mfd/max77620.c:58:2: error: initializer element is not constant
> >    drivers/mfd/max77620.c:58:2: note: (near initialization for 'max77620_children[0].id')
> >    drivers/mfd/max77620.c:59:2: error: initializer element is not constant
> >      DEFINE_MFD_CELL_NAME("max77620-pmic"),
> >      ^
> >    drivers/mfd/max77620.c:59:2: note: (near initialization for 'max77620_children[0].usage_count')
> >    drivers/mfd/max77620.c:60:2: error: initializer element is not constant
> >      DEFINE_MFD_CELL_NAME_RESOURCE("max77620-rtc", rtc_resources),
> >      ^
> >    drivers/mfd/max77620.c:60:2: note: (near initialization for 'max77620_children[0].enable')
> >    drivers/mfd/max77620.c:61:2: error: initializer element is not constant
> >      DEFINE_MFD_CELL_NAME_RESOURCE("max77620-power", power_resources),
> >      ^
> >    drivers/mfd/max77620.c:61:2: note: (near initialization for 'max77620_children[0].disable')
> >    drivers/mfd/max77620.c:62:2: error: initializer element is not constant
> >      DEFINE_MFD_CELL_NAME("max77620-watchdog"),
> >      ^
> >    drivers/mfd/max77620.c:62:2: note: (near initialization for 'max77620_children[0].suspend')
> >    drivers/mfd/max77620.c:63:2: error: initializer element is not constant
> >      DEFINE_MFD_CELL_NAME("max77620-clock"),
> >      ^
> >    drivers/mfd/max77620.c:63:2: note: (near initialization for 'max77620_children[0].resume')
> >    drivers/mfd/max77620.c:64:2: error: initializer element is not constant
> >      DEFINE_MFD_CELL_NAME_RESOURCE("max77620-thermal", thermal_resources),
> >      ^
> >    drivers/mfd/max77620.c:64:2: note: (near initialization for 'max77620_children[0].platform_data')
> >    drivers/mfd/max77620.c:68:2: error: initializer element is not constant
> >      DEFINE_MFD_CELL_NAME("max20024-pinctrl"),
> >      ^
> >    drivers/mfd/max77620.c:68:2: note: (near initialization for 'max20024_children[0].name')
> >    drivers/mfd/max77620.c:69:2: error: initializer element is not constant
> >      DEFINE_MFD_CELL_NAME_RESOURCE("max20024-gpio", gpio_resources),
> >      ^
> >    drivers/mfd/max77620.c:69:2: note: (near initialization for 'max20024_children[0].id')
> >    drivers/mfd/max77620.c:70:2: error: initializer element is not constant
> >      DEFINE_MFD_CELL_NAME("max20024-pmic"),
> >      ^
> >    drivers/mfd/max77620.c:70:2: note: (near initialization for 'max20024_children[0].usage_count')
> >    drivers/mfd/max77620.c:71:2: error: initializer element is not constant
> >      DEFINE_MFD_CELL_NAME_RESOURCE("max20024-rtc", rtc_resources),
> >      ^
> >    drivers/mfd/max77620.c:71:2: note: (near initialization for 'max20024_children[0].enable')
> >    drivers/mfd/max77620.c:72:2: error: initializer element is not constant
> >      DEFINE_MFD_CELL_NAME_RESOURCE("max20024-power", power_resources),
> >      ^
> >    drivers/mfd/max77620.c:72:2: note: (near initialization for 'max20024_children[0].disable')
> >    drivers/mfd/max77620.c:73:2: error: initializer element is not constant
> >      DEFINE_MFD_CELL_NAME("max20024-watchdog"),
> >      ^
> >    drivers/mfd/max77620.c:73:2: note: (near initialization for 'max20024_children[0].suspend')
> >    drivers/mfd/max77620.c:74:2: error: initializer element is not constant
> >      DEFINE_MFD_CELL_NAME("max20024-clock"),
> >      ^
> >    drivers/mfd/max77620.c:74:2: note: (near initialization for 'max20024_children[0].resume')
> >    cc1: some warnings being treated as errors
> >
> >vim +/DEFINE_MFD_CELL_NAME +57 drivers/mfd/max77620.c
> >
> >     51		REGMAP_IRQ_REG(MAX77620_IRQ_LBT_MBATLOW, 1, MAX77620_IRQ_LBM_MASK),
> >     52		REGMAP_IRQ_REG(MAX77620_IRQ_LBT_TJALRM1, 1, MAX77620_IRQ_TJALRM1_MASK),
> >     53		REGMAP_IRQ_REG(MAX77620_IRQ_LBT_TJALRM2, 1, MAX77620_IRQ_TJALRM2_MASK),
> >     54	};
> >     55	
> >     56	static struct mfd_cell max77620_children[] = {
> >   > 57		DEFINE_MFD_CELL_NAME("max77620-pinctrl"),
> >   > 58		DEFINE_MFD_CELL_NAME_RESOURCE("max77620-gpio", gpio_resources),
> >     59		DEFINE_MFD_CELL_NAME("max77620-pmic"),
> >     60		DEFINE_MFD_CELL_NAME_RESOURCE("max77620-rtc", rtc_resources),
> >     61		DEFINE_MFD_CELL_NAME_RESOURCE("max77620-power", power_resources),
> >
> >---
> >0-DAY kernel test infrastructure                Open Source Technology Center
> >https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [next] | [standalone]

#1322907

FromLaxman Dewangan <ldewangan@nvidia.com>
Date2016-02-01 09:50 +0100
Message-ID<qXilk-8sL-1@gated-at.bofh.it>
In reply to#1322894
On Monday 01 February 2016 01:55 PM, Lee Jones wrote:
> On Sat, 30 Jan 2016, Laxman Dewangan wrote:
>
>> This depends on patch
>> [PATCH V2] mfd: core: add macro for adding mfd cells
>>
>> and due to absence of this patch, it reports the error.
> If you have dependencies, why aren't they in this set?
>

This change is not related to the series as such and so independent.
I just thought that mentioning on commit log will be fine here. May be I 
missed some points here.

Let me know if I need to add this to back on series.

Thanks,
Laxman

[toc] | [prev] | [next] | [standalone]

#1322922 — Re: [PATCH V7 2/8] mfd: max77620: add core driver for MAX77620/MAX20024

FromLee Jones <lee.jones@linaro.org>
Date2016-02-01 10:10 +0100
SubjectRe: [PATCH V7 2/8] mfd: max77620: add core driver for MAX77620/MAX20024
Message-ID<qXiEG-pe-9@gated-at.bofh.it>
In reply to#1322907
On Mon, 01 Feb 2016, Laxman Dewangan wrote:

> 
> On Monday 01 February 2016 01:55 PM, Lee Jones wrote:
> >On Sat, 30 Jan 2016, Laxman Dewangan wrote:
> >
> >>This depends on patch
> >>[PATCH V2] mfd: core: add macro for adding mfd cells
> >>
> >>and due to absence of this patch, it reports the error.
> >If you have dependencies, why aren't they in this set?
> >
> 
> This change is not related to the series as such and so independent.
> I just thought that mentioning on commit log will be fine here. May
> be I missed some points here.

If you have patches which use/depend on it, then it's not so
independent, right?

> Let me know if I need to add this to back on series.
 
In order to avoid any mishaps, that would be preferable, yes.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [next] | [standalone]

#1322941

FromLaxman Dewangan <ldewangan@nvidia.com>
Date2016-02-01 10:30 +0100
Message-ID<qXiY2-wH-19@gated-at.bofh.it>
In reply to#1322922
On Monday 01 February 2016 02:32 PM, Lee Jones wrote:
> On Mon, 01 Feb 2016, Laxman Dewangan wrote:
>
>> On Monday 01 February 2016 01:55 PM, Lee Jones wrote:
>>> On Sat, 30 Jan 2016, Laxman Dewangan wrote:
>>>
>>>> This depends on patch
>>>> [PATCH V2] mfd: core: add macro for adding mfd cells
>>>>
>>>> and due to absence of this patch, it reports the error.
>>> If you have dependencies, why aren't they in this set?
>>>
>> This change is not related to the series as such and so independent.
>> I just thought that mentioning on commit log will be fine here. May
>> be I missed some points here.
> If you have patches which use/depend on it, then it's not so
> independent, right?

Hmm.. true. I had different thought that the core header is independent 
as it does not depends on other but this series dependent which depends 
on core header. Seems something I missed.
Idea was to review md header independently and used on this series.



>> Let me know if I need to add this to back on series.
>   
> In order to avoid any mishaps, that would be preferable, yes.
>
I will respin this series to V8 once I will have change from you per 
discussion on other email.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web