Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1320371 > unrolled thread

Re: [PATCH v1 2/8] mm, kasan: SLAB support

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v1 2/8] mm, kasan: SLAB support Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-01-28 08:50 +0100
    Re: [PATCH v1 2/8] mm, kasan: SLAB support Alexander Potapenko <glider@google.com> - 2016-01-28 14:30 +0100
      Re: [PATCH v1 2/8] mm, kasan: SLAB support Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-02-01 03:20 +0100

#1320371 — Re: [PATCH v1 2/8] mm, kasan: SLAB support

On Wed, Jan 27, 2016 at 07:25:07PM +0100, Alexander Potapenko wrote:
> This patch adds KASAN hooks to SLAB allocator.
> 
> This patch is based on the "mm: kasan: unified support for SLUB and
> SLAB allocators" patch originally prepared by Dmitry Chernenkov.
> 
> Signed-off-by: Alexander Potapenko <glider@google.com>
> ---
>  Documentation/kasan.txt  |  5 ++-

...

> +#ifdef CONFIG_SLAB
> +struct kasan_alloc_meta *get_alloc_info(struct kmem_cache *cache,
> +					const void *object)
> +{
> +	return (void *)object + cache->kasan_info.alloc_meta_offset;
> +}
> +
> +struct kasan_free_meta *get_free_info(struct kmem_cache *cache,
> +				      const void *object)
> +{
> +	return (void *)object + cache->kasan_info.free_meta_offset;
> +}
> +#endif

I cannot find the place to store stack info for free. get_free_info()
isn't used except print_object(). Plese let me know where.

Thanks.

[toc] | [next] | [standalone]

#1320668

On Thu, Jan 28, 2016 at 1:37 PM, Alexander Potapenko <glider@google.com> wrote:
>
> On Jan 28, 2016 8:44 AM, "Joonsoo Kim" <iamjoonsoo.kim@lge.com> wrote:
>>
>> On Wed, Jan 27, 2016 at 07:25:07PM +0100, Alexander Potapenko wrote:
>> > This patch adds KASAN hooks to SLAB allocator.
>> >
>> > This patch is based on the "mm: kasan: unified support for SLUB and
>> > SLAB allocators" patch originally prepared by Dmitry Chernenkov.
>> >
>> > Signed-off-by: Alexander Potapenko <glider@google.com>
>> > ---
>> >  Documentation/kasan.txt  |  5 ++-
>>
>> ...
>>
>> > +#ifdef CONFIG_SLAB
>> > +struct kasan_alloc_meta *get_alloc_info(struct kmem_cache *cache,
>> > +                                     const void *object)
>> > +{
>> > +     return (void *)object + cache->kasan_info.alloc_meta_offset;
>> > +}
>> > +
>> > +struct kasan_free_meta *get_free_info(struct kmem_cache *cache,
>> > +                                   const void *object)
>> > +{
>> > +     return (void *)object + cache->kasan_info.free_meta_offset;
>> > +}
>> > +#endif
>>
>> I cannot find the place to store stack info for free. get_free_info()
>> isn't used except print_object(). Plese let me know where.
>
> This is covered by other patches in this patchset.
>
>> Thanks.
(resending to linux-kernel@ because the previous mail bounced)


-- 
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Straße, 33
80636 München

Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den
Absender und löschen Sie die E-Mail und alle Anhänge. Vielen Dank.
This e-mail is confidential. If you are not the right addressee please
do not forward it, please inform the sender, and please erase this
e-mail including any attachments. Thanks.

[toc] | [prev] | [next] | [standalone]

#1322782

On Thu, Jan 28, 2016 at 02:29:42PM +0100, Alexander Potapenko wrote:
> On Thu, Jan 28, 2016 at 1:37 PM, Alexander Potapenko <glider@google.com> wrote:
> >
> > On Jan 28, 2016 8:44 AM, "Joonsoo Kim" <iamjoonsoo.kim@lge.com> wrote:
> >>
> >> On Wed, Jan 27, 2016 at 07:25:07PM +0100, Alexander Potapenko wrote:
> >> > This patch adds KASAN hooks to SLAB allocator.
> >> >
> >> > This patch is based on the "mm: kasan: unified support for SLUB and
> >> > SLAB allocators" patch originally prepared by Dmitry Chernenkov.
> >> >
> >> > Signed-off-by: Alexander Potapenko <glider@google.com>
> >> > ---
> >> >  Documentation/kasan.txt  |  5 ++-
> >>
> >> ...
> >>
> >> > +#ifdef CONFIG_SLAB
> >> > +struct kasan_alloc_meta *get_alloc_info(struct kmem_cache *cache,
> >> > +                                     const void *object)
> >> > +{
> >> > +     return (void *)object + cache->kasan_info.alloc_meta_offset;
> >> > +}
> >> > +
> >> > +struct kasan_free_meta *get_free_info(struct kmem_cache *cache,
> >> > +                                   const void *object)
> >> > +{
> >> > +     return (void *)object + cache->kasan_info.free_meta_offset;
> >> > +}
> >> > +#endif
> >>
> >> I cannot find the place to store stack info for free. get_free_info()
> >> isn't used except print_object(). Plese let me know where.
> >
> > This is covered by other patches in this patchset.

This should be covered by this patch. Stroing and printing free_info
is already done on SLUB and it is meaningful without quarantain.

Thanks.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web