Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1322769 > unrolled thread

Re: [PATCH] deadline: remove unused struct member

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] deadline: remove unused struct member Tahsin Erdogan <tahsin@google.com> - 2016-02-01 02:00 +0100
    Re: [PATCH] deadline: remove unused struct member Jeff Moyer <jmoyer@redhat.com> - 2016-02-01 16:20 +0100
      Re: [PATCH] deadline: remove unused struct member Jens Axboe <axboe@kernel.dk> - 2016-02-01 17:20 +0100

#1322769 — Re: [PATCH] deadline: remove unused struct member

Ping?

On Thu, Jan 14, 2016 at 2:41 PM, Tahsin Erdogan <tahsin@google.com> wrote:
> commit 63de428b139d3d31d86ebe25ae97b33f6540fb7e ("deadline-iosched:
> allow non-sequential batching") removed last use of last_sector.
>
> Signed-off-by: Tahsin Erdogan <tahsin@google.com>
> ---
>  block/deadline-iosched.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/block/deadline-iosched.c b/block/deadline-iosched.c
> index a753df2..d0dd788 100644
> --- a/block/deadline-iosched.c
> +++ b/block/deadline-iosched.c
> @@ -39,7 +39,6 @@ struct deadline_data {
>          */
>         struct request *next_rq[2];
>         unsigned int batching;          /* number of sequential requests made */
> -       sector_t last_sector;           /* head position */
>         unsigned int starved;           /* times reads have starved writes */
>
>         /*
> @@ -210,8 +209,6 @@ deadline_move_request(struct deadline_data *dd, struct request *rq)
>         dd->next_rq[WRITE] = NULL;
>         dd->next_rq[data_dir] = deadline_latter_request(rq);
>
> -       dd->last_sector = rq_end_sector(rq);
> -
>         /*
>          * take it off the sort and fifo list, move
>          * to dispatch queue
> --
> 2.6.0.rc2.230.g3dd15c0
>

[toc] | [next] | [standalone]

#1323221

Tahsin Erdogan <tahsin@google.com> writes:

> Ping?

Yeah, commit 63de428b139d3 (deadline-iosched: allow non-sequential
batching) removed the use of last_sector, and should have removed the
structure member as well (way back in 2008).

Reviewed-by: Jeff Moyer <jmoyer@redhat.com>


> On Thu, Jan 14, 2016 at 2:41 PM, Tahsin Erdogan <tahsin@google.com> wrote:
>> commit 63de428b139d3d31d86ebe25ae97b33f6540fb7e ("deadline-iosched:
>> allow non-sequential batching") removed last use of last_sector.
>>
>> Signed-off-by: Tahsin Erdogan <tahsin@google.com>
>> ---
>>  block/deadline-iosched.c | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/block/deadline-iosched.c b/block/deadline-iosched.c
>> index a753df2..d0dd788 100644
>> --- a/block/deadline-iosched.c
>> +++ b/block/deadline-iosched.c
>> @@ -39,7 +39,6 @@ struct deadline_data {
>>          */
>>         struct request *next_rq[2];
>>         unsigned int batching;          /* number of sequential requests made */
>> -       sector_t last_sector;           /* head position */
>>         unsigned int starved;           /* times reads have starved writes */
>>
>>         /*
>> @@ -210,8 +209,6 @@ deadline_move_request(struct deadline_data *dd, struct request *rq)
>>         dd->next_rq[WRITE] = NULL;
>>         dd->next_rq[data_dir] = deadline_latter_request(rq);
>>
>> -       dd->last_sector = rq_end_sector(rq);
>> -
>>         /*
>>          * take it off the sort and fifo list, move
>>          * to dispatch queue
>> --
>> 2.6.0.rc2.230.g3dd15c0
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-block" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [next] | [standalone]

#1323297

On 02/01/2016 08:10 AM, Jeff Moyer wrote:
> Tahsin Erdogan <tahsin@google.com> writes:
>
>> Ping?
>
> Yeah, commit 63de428b139d3 (deadline-iosched: allow non-sequential
> batching) removed the use of last_sector, and should have removed the
> structure member as well (way back in 2008).

Heh, just 8 years! Thanks Tahsin, applied.

-- 
Jens Axboe

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web