Groups > linux.kernel > #1323714 > unrolled thread

[PATCH v2 17/17] drivers:mtd:ubi: Kconfig Makefile

Started by	Bean Huo <jackyard88@gmail.com>
First post	2016-02-02 03:40 +0100
Last post	2016-02-03 07:20 +0100
Articles	5 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

  [PATCH v2 17/17] drivers:mtd:ubi: Kconfig Makefile Bean Huo <jackyard88@gmail.com> - 2016-02-02 03:40 +0100
    Re: [PATCH v2 17/17] drivers:mtd:ubi: Kconfig Makefile kbuild test robot <lkp@intel.com> - 2016-02-02 05:00 +0100
      RE: [PATCH v2 17/17] drivers:mtd:ubi: Kconfig Makefile Bean Huo 霍斌斌 (beanhuo)   <beanhuo@micron.com> - 2016-02-02 05:20 +0100
        Re: [PATCH v2 17/17] drivers:mtd:ubi: Kconfig Makefile Brian Norris <computersforpeace@gmail.com> - 2016-02-03 01:50 +0100
          RE: [PATCH v2 17/17] drivers:mtd:ubi: Kconfig Makefile Bean Huo 霍斌斌 (beanhuo)   <beanhuo@micron.com> - 2016-02-03 07:20 +0100

#1323714 — [PATCH v2 17/17] drivers:mtd:ubi: Kconfig Makefile

From	Bean Huo <jackyard88@gmail.com>
Date	2016-02-02 03:40 +0100
Subject	[PATCH v2 17/17] drivers:mtd:ubi: Kconfig Makefile
Message-ID	<qXz2O-3Wf-15@gated-at.bofh.it>

From: Bean Huo <beanhuo@micron.com>

Signed-off-by: BeanHuo <beanhuo@micron.com>
---
 drivers/mtd/ubi/Kconfig  | 15 +++++++++++++++
 drivers/mtd/ubi/Makefile |  2 +-
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/ubi/Kconfig b/drivers/mtd/ubi/Kconfig
index f0855ce..d9f01fa 100644
--- a/drivers/mtd/ubi/Kconfig
+++ b/drivers/mtd/ubi/Kconfig
@@ -77,6 +77,21 @@ config MTD_UBI_FASTMAP
 
 	   If in doubt, say "N".
 
+config MTD_UBI_MLC_NAND_BAKVOL
+	bool "UBI solution for NAND pair page (Experimental feature)"
+	default n
+	help
+	   This used for MLC NAND paired page power-cut protection.
+
+	   MLC NAND paired page power loss is a known issue so far.
+	   Namely, MLC NAND pages are coupled in a sense that if you cut
+	   power while writing to a page, you corrupt not only this page,
+	   but also one of the previous pages which is paired with the current
+	   one. More detail information,please refer to follwoing link:
+	   http://www.linux-mtd.infradead.org/doc/ubifs.html
+
+	   If in doubt, say "N".
+
 config MTD_UBI_GLUEBI
 	tristate "MTD devices emulation driver (gluebi)"
 	help
diff --git a/drivers/mtd/ubi/Makefile b/drivers/mtd/ubi/Makefile
index 4e3c3d7..6bd78aa 100644
--- a/drivers/mtd/ubi/Makefile
+++ b/drivers/mtd/ubi/Makefile
@@ -1,6 +1,6 @@
 obj-$(CONFIG_MTD_UBI) += ubi.o
 
-ubi-y += vtbl.o vmt.o upd.o build.o cdev.o kapi.o eba.o io.o wl.o attach.o
+ubi-y += vtbl.o vmt.o upd.o build.o cdev.o kapi.o eba.o io.o wl.o attach.o bakvol.o
 ubi-y += misc.o debug.o
 ubi-$(CONFIG_MTD_UBI_FASTMAP) += fastmap.o
 ubi-$(CONFIG_MTD_UBI_BLOCK) += block.o
-- 
1.9.1

[toc] | [next] | [standalone]

#1323776

From	kbuild test robot <lkp@intel.com>
Date	2016-02-02 05:00 +0100
Message-ID	<qXAie-4OK-5@gated-at.bofh.it>
In reply to	#1323714

Hi Bean,

[auto build test WARNING on v4.5-rc2]
[also build test WARNING on next-20160201]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Bean-Huo/Add-a-bakvol-module-in-UBI-layer-for-MLC-paired-page-power-loss-issue/20160202-104450


coccinelle warnings: (new ones prefixed by >>)

>> drivers/mtd/ubi/bakvol.c:862:17-28: ERROR: ubi -> bkblk_tbl is NULL but dereferenced.
--
>> drivers/mtd/ubi/bakvol.c:1211:1-15: ERROR: reference preceded by free on line 1210
   drivers/mtd/ubi/bakvol.c:862:1-15: ERROR: reference preceded by free on line 855

vim +862 drivers/mtd/ubi/bakvol.c

3b3521fb Bean Huo 2016-02-02  846  out0:
3b3521fb Bean Huo 2016-02-02  847  	kfree(oob_ops_src->oobbuf);
3b3521fb Bean Huo 2016-02-02  848  out_oob_ops:
3b3521fb Bean Huo 2016-02-02  849  	kfree(oob_ops_src);
3b3521fb Bean Huo 2016-02-02  850  out_obs_src:
3b3521fb Bean Huo 2016-02-02  851  	kfree(oob_ops_bak->oobbuf);
3b3521fb Bean Huo 2016-02-02  852  out_back_oob_ops:
3b3521fb Bean Huo 2016-02-02  853  	kfree(oob_ops_bak);
3b3521fb Bean Huo 2016-02-02  854  out_backup_info:
3b3521fb Bean Huo 2016-02-02  855  	kfree(ubi->bkblk_tbl);
3b3521fb Bean Huo 2016-02-02  856  out_vidh:
3b3521fb Bean Huo 2016-02-02  857  	ubi_free_vid_hdr(ubi, vidh);
3b3521fb Bean Huo 2016-02-02  858  out_ech:
3b3521fb Bean Huo 2016-02-02  859  	kfree(ech);
3b3521fb Bean Huo 2016-02-02  860  out_init:
3b3521fb Bean Huo 2016-02-02  861  	ubi_err(ubi, "bakvol module init error,init step [%d].\n", step);
3b3521fb Bean Huo 2016-02-02 @862  	ubi->bkblk_tbl->bakvol_flag = UBI_BAKVOL_REJECT;
3b3521fb Bean Huo 2016-02-02  863  	return -1;
3b3521fb Bean Huo 2016-02-02  864  }
3b3521fb Bean Huo 2016-02-02  865  
3b3521fb Bean Huo 2016-02-02  866  /**
3b3521fb Bean Huo 2016-02-02  867   * ubi_bakvol_peb_scan - check VID header,see if this PEB
3b3521fb Bean Huo 2016-02-02  868   *				belongs to bakvol
3b3521fb Bean Huo 2016-02-02  869   *
3b3521fb Bean Huo 2016-02-02  870   * This function returns 1 if this PEB not belongs to bakvol

:::::: The code at line 862 was first introduced by commit
:::::: 3b3521fb6dda26424b36620d13e0195a5b4930b0 driver:mtd:ubi:add new bakvol module in ubi layer

:::::: TO: Bean Huo <beanhuo@micron.com>
:::::: CC: 0day robot <fengguang.wu@intel.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[toc] | [prev] | [next] | [standalone]

#1323780

From	Bean Huo 霍斌斌 (beanhuo) <beanhuo@micron.com>
Date	2016-02-02 05:20 +0100
Message-ID	<qXABA-5fp-7@gated-at.bofh.it>
In reply to	#1323776

> Hi Bean,
> 
> [auto build test WARNING on v4.5-rc2]

This version 2.0 patches are based on 4.2-rc7.

> [also build test WARNING on next-20160201] [if your patch is applied to the
> wrong git tree, please drop us a note to help improving the system]

[toc] | [prev] | [next] | [standalone]

#1324786

From	Brian Norris <computersforpeace@gmail.com>
Date	2016-02-03 01:50 +0100
Message-ID	<qXTNT-2Yj-5@gated-at.bofh.it>
In reply to	#1323780

On Tue, Feb 02, 2016 at 04:15:43AM +0000, Bean Huo 霍斌斌 wrote:
> > Hi Bean,
> > 
> > [auto build test WARNING on v4.5-rc2]
> 
> This version 2.0 patches are based on 4.2-rc7.

Please don't send patches against ancient kernel versions.

[toc] | [prev] | [next] | [standalone]

#1324953

From	Bean Huo 霍斌斌 (beanhuo) <beanhuo@micron.com>
Date	2016-02-03 07:20 +0100
Message-ID	<qXYXh-6CP-27@gated-at.bofh.it>
In reply to	#1324786

> >On Tue, Feb 02, 2016 at 04:15:43AM +0000, Bean Huo 霍斌斌 wrote:
> > > Hi Bean,
> > >
> > > [auto build test WARNING on v4.5-rc2]
> >
> > This version 2.0 patches are based on 4.2-rc7.
> 
> Please don't send patches against ancient kernel versions.
Brian 
Sorry for this. this patches codes are too long,
Next time I will push my patches based on latest kernel.

Beat Regards!
Beanhuo

[toc] | [prev] | [standalone]

csiph-web

[PATCH v2 17/17] drivers:mtd:ubi: Kconfig Makefile

Contents

#1323714 — [PATCH v2 17/17] drivers:mtd:ubi: Kconfig Makefile

#1323776

#1323780

#1324786

#1324953