Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1323341 > unrolled thread
| Started by | Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
|---|---|
| First post | 2016-02-01 18:30 +0100 |
| Last post | 2016-02-03 09:50 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH RFC 05/15] ASoC: qcom: ipq806x: add error in dma allocation. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-02-01 18:30 +0100
Re: [alsa-devel] [PATCH RFC 05/15] ASoC: qcom: ipq806x: add error in dma allocation. Kenneth Westfield <kwestfie@codeaurora.org> - 2016-02-03 01:40 +0100
Re: [alsa-devel] [PATCH RFC 05/15] ASoC: qcom: ipq806x: add error in dma allocation. Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-02-03 09:50 +0100
| From | Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
|---|---|
| Date | 2016-02-01 18:30 +0100 |
| Subject | [PATCH RFC 05/15] ASoC: qcom: ipq806x: add error in dma allocation. |
| Message-ID | <qXqsy-6bL-19@gated-at.bofh.it> |
ipq806x is only ever tested for playback so return error in dma allocation
if the stream direction is capture.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
sound/soc/qcom/lpass-ipq806x.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/sound/soc/qcom/lpass-ipq806x.c b/sound/soc/qcom/lpass-ipq806x.c
index 119048c..8bdcdcb 100644
--- a/sound/soc/qcom/lpass-ipq806x.c
+++ b/sound/soc/qcom/lpass-ipq806x.c
@@ -65,7 +65,10 @@ static struct snd_soc_dai_driver ipq806x_lpass_cpu_dai_driver = {
static int ipq806x_lpass_alloc_dma_channel(struct lpass_data *drvdata, int dir)
{
- return IPQ806X_LPAIF_RDMA_CHAN_MI2S;
+ if (dir == SNDRV_PCM_STREAM_PLAYBACK)
+ return IPQ806X_LPAIF_RDMA_CHAN_MI2S;
+ else /* Capture not supported */
+ return -EINVAL;
}
static int ipq806x_lpass_free_dma_channel(struct lpass_data *drvdata, int chan)
--
1.9.1
[toc] | [next] | [standalone]
| From | Kenneth Westfield <kwestfie@codeaurora.org> |
|---|---|
| Date | 2016-02-03 01:40 +0100 |
| Subject | Re: [alsa-devel] [PATCH RFC 05/15] ASoC: qcom: ipq806x: add error in dma allocation. |
| Message-ID | <qXTEf-2Um-25@gated-at.bofh.it> |
| In reply to | #1323341 |
On Mon, Feb 01, 2016 at 09:28:43AM -0800, Srinivas Kandagatla wrote:
> diff --git a/sound/soc/qcom/lpass-ipq806x.c
> b/sound/soc/qcom/lpass-ipq806x.c
> index 119048c..8bdcdcb 100644
> --- a/sound/soc/qcom/lpass-ipq806x.c
> +++ b/sound/soc/qcom/lpass-ipq806x.c
> @@ -65,7 +65,10 @@ static struct snd_soc_dai_driver
> ipq806x_lpass_cpu_dai_driver = {
>
> static int ipq806x_lpass_alloc_dma_channel(struct lpass_data *drvdata,
> int dir)
> {
> - return IPQ806X_LPAIF_RDMA_CHAN_MI2S;
> + if (dir == SNDRV_PCM_STREAM_PLAYBACK)
> + return IPQ806X_LPAIF_RDMA_CHAN_MI2S;
> + else /* Capture not supported */
> + return -EINVAL;
> }
The comment could be read as "Capture not supported by hardware", which
isn't true. Maybe "Capture currently not implemented"?
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
[toc] | [prev] | [next] | [standalone]
| From | Srinivas Kandagatla <srinivas.kandagatla@linaro.org> |
|---|---|
| Date | 2016-02-03 09:50 +0100 |
| Subject | Re: [alsa-devel] [PATCH RFC 05/15] ASoC: qcom: ipq806x: add error in dma allocation. |
| Message-ID | <qY1ip-80l-13@gated-at.bofh.it> |
| In reply to | #1324774 |
On 03/02/16 00:36, Kenneth Westfield wrote:
> On Mon, Feb 01, 2016 at 09:28:43AM -0800, Srinivas Kandagatla wrote:
>> diff --git a/sound/soc/qcom/lpass-ipq806x.c
>> b/sound/soc/qcom/lpass-ipq806x.c
>> index 119048c..8bdcdcb 100644
>> --- a/sound/soc/qcom/lpass-ipq806x.c
>> +++ b/sound/soc/qcom/lpass-ipq806x.c
>> @@ -65,7 +65,10 @@ static struct snd_soc_dai_driver
>> ipq806x_lpass_cpu_dai_driver = {
>>
>> static int ipq806x_lpass_alloc_dma_channel(struct lpass_data *drvdata,
>> int dir)
>> {
>> - return IPQ806X_LPAIF_RDMA_CHAN_MI2S;
>> + if (dir == SNDRV_PCM_STREAM_PLAYBACK)
>> + return IPQ806X_LPAIF_RDMA_CHAN_MI2S;
>> + else /* Capture not supported */
>> + return -EINVAL;
>> }
>
> The comment could be read as "Capture not supported by hardware", which
> isn't true. Maybe "Capture currently not implemented"?
Agreed, I will change this in next version.
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web