Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1324713 > unrolled thread
| Started by | Colin Vidal <colin@cvidal.org> |
|---|---|
| First post | 2016-02-03 00:00 +0100 |
| Last post | 2016-02-03 00:10 +0100 |
| Articles | 2 — 1 participant |
Back to article view | Back to linux.kernel
[PATCH] Staging: fix coding style in rtl8188eu/core Colin Vidal <colin@cvidal.org> - 2016-02-03 00:00 +0100
Re: [PATCH] Staging: fix coding style in rtl8188eu/core Colin Vidal <colin@cvidal.org> - 2016-02-03 00:10 +0100
| From | Colin Vidal <colin@cvidal.org> |
|---|---|
| Date | 2016-02-03 00:00 +0100 |
| Subject | [PATCH] Staging: fix coding style in rtl8188eu/core |
| Message-ID | <qXS5s-1xR-21@gated-at.bofh.it> |
Set constant operand on right of test, and refactor the code in a more
compact and readable way.
Signed-off-by: Colin Vidal <colin@cvidal.org>
---
drivers/staging/rtl8188eu/core/rtw_iol.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c
index cdcf0ea..00e1136 100644
--- a/drivers/staging/rtl8188eu/core/rtw_iol.c
+++ b/drivers/staging/rtl8188eu/core/rtw_iol.c
@@ -18,14 +18,11 @@
*
******************************************************************************/
-#include<rtw_iol.h>
+#include <rtw_iol.h>
-bool rtw_IOL_applied(struct adapter *adapter)
+bool rtw_IOL_applied(struct adapter *adapter)
{
- if (1 == adapter->registrypriv.fw_iol)
- return true;
-
- if ((2 == adapter->registrypriv.fw_iol) && (!adapter_to_dvobj(adapter)->ishighspeed))
- return true;
- return false;
+ return adapter->registrypriv.fw_iol == 1 ||
+ (adapter->registrypriv.fw_iol == 2 &&
+ !adapter_to_dvobj(adapter)->ishighspeed);
}
--
2.5.0
[toc] | [next] | [standalone]
| From | Colin Vidal <colin@cvidal.org> |
|---|---|
| Date | 2016-02-03 00:10 +0100 |
| Message-ID | <qXSf8-1Ty-11@gated-at.bofh.it> |
| In reply to | #1324713 |
On Tue, 2016-02-02 at 23:54 +0100, Colin Vidal wrote:
> Set constant operand on right of test, and refactor the code in a
> more
> compact and readable way.
>
> Signed-off-by: Colin Vidal <colin@cvidal.org>
> ---
> drivers/staging/rtl8188eu/core/rtw_iol.c | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c
> b/drivers/staging/rtl8188eu/core/rtw_iol.c
> index cdcf0ea..00e1136 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_iol.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_iol.c
> @@ -18,14 +18,11 @@
> *
>
> *********************************************************************
> *********/
>
> -#include<rtw_iol.h>
> +#include <rtw_iol.h>
>
> -bool rtw_IOL_applied(struct adapter *adapter)
> +bool rtw_IOL_applied(struct adapter *adapter)
> {
> - if (1 == adapter->registrypriv.fw_iol)
> - return true;
> -
> - if ((2 == adapter->registrypriv.fw_iol) &&
> (!adapter_to_dvobj(adapter)->ishighspeed))
> - return true;
> - return false;
> + return adapter->registrypriv.fw_iol == 1 ||
> + (adapter->registrypriv.fw_iol == 2 &&
> + !adapter_to_dvobj(adapter)->ishighspeed);
> }
Argh... The subject should be prefixed by "[PATCH v2]"... Missing
training, sorry.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web