Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1323256 > unrolled thread

[PATCH v2 09/11] xen/hvmlite: Use x86's default timer init for HVMlite guests

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v2 09/11] xen/hvmlite: Use x86's default timer init for HVMlite guests Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-02-01 16:50 +0100
    Re: [Xen-devel] [PATCH v2 09/11] xen/hvmlite: Use x86's default timer  init for HVMlite guests David Vrabel <david.vrabel@citrix.com> - 2016-02-02 17:30 +0100
      Re: [Xen-devel] [PATCH v2 09/11] xen/hvmlite: Use x86's default timer  init for HVMlite guests Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-02-02 18:10 +0100

#1323256 — [PATCH v2 09/11] xen/hvmlite: Use x86's default timer init for HVMlite guests

xen_timer_init() will be called from apic_bsp_setup().

Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
 arch/x86/xen/time.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
index f1ba6a0..d77b398 100644
--- a/arch/x86/xen/time.c
+++ b/arch/x86/xen/time.c
@@ -492,7 +492,10 @@ void __init xen_init_time_ops(void)
 {
 	pv_time_ops = xen_time_ops;
 
-	x86_init.timers.timer_init = xen_time_init;
+	if (!xen_hvmlite)
+		x86_init.timers.timer_init = xen_time_init;
+	else
+		x86_init.timers.timer_init = x86_init_noop;
 	x86_init.timers.setup_percpu_clockev = x86_init_noop;
 	x86_cpuinit.setup_percpu_clockev = x86_init_noop;
 
-- 
1.7.1

[toc] | [next] | [standalone]

#1324248 — Re: [Xen-devel] [PATCH v2 09/11] xen/hvmlite: Use x86's default timer init for HVMlite guests

On 01/02/16 15:38, Boris Ostrovsky wrote:
> xen_timer_init() will be called from apic_bsp_setup().

I must be missing something because xen_init_time_ops() is only called
from the PV-only xen_start_kernel()?

David

> --- a/arch/x86/xen/time.c
> +++ b/arch/x86/xen/time.c
> @@ -492,7 +492,10 @@ void __init xen_init_time_ops(void)
>  {
>  	pv_time_ops = xen_time_ops;
>  
> -	x86_init.timers.timer_init = xen_time_init;
> +	if (!xen_hvmlite)
> +		x86_init.timers.timer_init = xen_time_init;
> +	else
> +		x86_init.timers.timer_init = x86_init_noop;
>  	x86_init.timers.setup_percpu_clockev = x86_init_noop;
>  	x86_cpuinit.setup_percpu_clockev = x86_init_noop;
>  
> 

[toc] | [prev] | [next] | [standalone]

#1324291 — Re: [Xen-devel] [PATCH v2 09/11] xen/hvmlite: Use x86's default timer init for HVMlite guests

On 02/02/2016 11:27 AM, David Vrabel wrote:
> On 01/02/16 15:38, Boris Ostrovsky wrote:
>> xen_timer_init() will be called from apic_bsp_setup().
> I must be missing something because xen_init_time_ops() is only called
> from the PV-only xen_start_kernel()?

This is leftover from the earlier series where common code called 
xen_init_time_ops() (which, of course, it could easily not have done for 
HVMlite guests).

So it's not needed anymore, I'll drop this patch.

-boris

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web