Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1324247 > unrolled thread

Re: [PATCH] misc: Move panel driver out of staging

Started byGreg KH <gregkh@linuxfoundation.org>
First post2016-02-02 17:30 +0100
Last post2016-02-02 18:00 +0100
Articles 7 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] misc: Move panel driver out of staging Greg KH <gregkh@linuxfoundation.org> - 2016-02-02 17:30 +0100
    Re: [PATCH] misc: Move panel driver out of staging Ksenija Stanojević <ksenija.stanojevic@gmail.com> - 2016-02-02 17:50 +0100
      Re: [PATCH] misc: Move panel driver out of staging Greg KH <gregkh@linuxfoundation.org> - 2016-02-02 18:20 +0100
        Re: [PATCH] misc: Move panel driver out of staging Ksenija Stanojević <ksenija.stanojevic@gmail.com> - 2016-02-02 18:20 +0100
          Re: [PATCH] misc: Move panel driver out of staging Greg KH <gregkh@linuxfoundation.org> - 2016-02-02 18:50 +0100
            Re: [PATCH] misc: Move panel driver out of staging Ksenija Stanojević <ksenija.stanojevic@gmail.com> - 2016-02-02 19:20 +0100
    Re: [PATCH] misc: Move panel driver out of staging Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-02 18:00 +0100

#1324247 — Re: [PATCH] misc: Move panel driver out of staging

FromGreg KH <gregkh@linuxfoundation.org>
Date2016-02-02 17:30 +0100
SubjectRe: [PATCH] misc: Move panel driver out of staging
Message-ID<qXM01-5FW-7@gated-at.bofh.it>
On Tue, Feb 02, 2016 at 03:38:21PM +0100, Ksenija Stanojevic wrote:
> Move panel driver from drivers/staging/panel to drivers/misc.
> 
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---
>  drivers/misc/Kconfig                      |  278 ++++
>  drivers/misc/Makefile                     |    1 +
>  drivers/misc/panel.c                      | 2445 +++++++++++++++++++++++++++++
>  drivers/staging/Kconfig                   |    2 -
>  drivers/staging/Makefile                  |    1 -
>  drivers/staging/panel/Kconfig             |  278 ----
>  drivers/staging/panel/Makefile            |    1 -
>  drivers/staging/panel/TODO                |    8 -
>  drivers/staging/panel/lcd-panel-cgram.txt |   24 -
>  drivers/staging/panel/panel.c             | 2445 -----------------------------
>  10 files changed, 2724 insertions(+), 2759 deletions(-)
>  create mode 100644 drivers/misc/panel.c
>  delete mode 100644 drivers/staging/panel/Kconfig
>  delete mode 100644 drivers/staging/panel/Makefile
>  delete mode 100644 drivers/staging/panel/TODO
>  delete mode 100644 drivers/staging/panel/lcd-panel-cgram.txt
>  delete mode 100644 drivers/staging/panel/panel.c


Can you generate a patch like this with the -M option to git
format-patch?  It will show the files being moved, not being deleted and
added again, making it much easier to see that nothing is changing
during the move.

thanks,

greg k-h

[toc] | [next] | [standalone]

#1324268

FromKsenija Stanojević <ksenija.stanojevic@gmail.com>
Date2016-02-02 17:50 +0100
Message-ID<qXMjn-5NR-13@gated-at.bofh.it>
In reply to#1324247
Hi Greg,

On Tue, Feb 2, 2016 at 5:23 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Tue, Feb 02, 2016 at 03:38:21PM +0100, Ksenija Stanojevic wrote:
>> Move panel driver from drivers/staging/panel to drivers/misc.
>>
>> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
>> ---
>>  drivers/misc/Kconfig                      |  278 ++++
>>  drivers/misc/Makefile                     |    1 +
>>  drivers/misc/panel.c                      | 2445 +++++++++++++++++++++++++++++
>>  drivers/staging/Kconfig                   |    2 -
>>  drivers/staging/Makefile                  |    1 -
>>  drivers/staging/panel/Kconfig             |  278 ----
>>  drivers/staging/panel/Makefile            |    1 -
>>  drivers/staging/panel/TODO                |    8 -
>>  drivers/staging/panel/lcd-panel-cgram.txt |   24 -
>>  drivers/staging/panel/panel.c             | 2445 -----------------------------
>>  10 files changed, 2724 insertions(+), 2759 deletions(-)
>>  create mode 100644 drivers/misc/panel.c
>>  delete mode 100644 drivers/staging/panel/Kconfig
>>  delete mode 100644 drivers/staging/panel/Makefile
>>  delete mode 100644 drivers/staging/panel/TODO
>>  delete mode 100644 drivers/staging/panel/lcd-panel-cgram.txt
>>  delete mode 100644 drivers/staging/panel/panel.c
>
>
> Can you generate a patch like this with the -M option to git
> format-patch?

I tried that but it didn't change anything.
Also, should panel driver have a separate directory in drivers/misc?
I didn't make one.

>It will show the files being moved, not being deleted and
> added again, making it much easier to see that nothing is changing
> during the move.

Ksenija

[toc] | [prev] | [next] | [standalone]

#1324292

FromGreg KH <gregkh@linuxfoundation.org>
Date2016-02-02 18:20 +0100
Message-ID<qXMMq-6gE-1@gated-at.bofh.it>
In reply to#1324268
On Tue, Feb 02, 2016 at 05:48:56PM +0100, Ksenija Stanojević wrote:
> Hi Greg,
> 
> On Tue, Feb 2, 2016 at 5:23 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Tue, Feb 02, 2016 at 03:38:21PM +0100, Ksenija Stanojevic wrote:
> >> Move panel driver from drivers/staging/panel to drivers/misc.
> >>
> >> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> >> ---
> >>  drivers/misc/Kconfig                      |  278 ++++
> >>  drivers/misc/Makefile                     |    1 +
> >>  drivers/misc/panel.c                      | 2445 +++++++++++++++++++++++++++++
> >>  drivers/staging/Kconfig                   |    2 -
> >>  drivers/staging/Makefile                  |    1 -
> >>  drivers/staging/panel/Kconfig             |  278 ----
> >>  drivers/staging/panel/Makefile            |    1 -
> >>  drivers/staging/panel/TODO                |    8 -
> >>  drivers/staging/panel/lcd-panel-cgram.txt |   24 -
> >>  drivers/staging/panel/panel.c             | 2445 -----------------------------
> >>  10 files changed, 2724 insertions(+), 2759 deletions(-)
> >>  create mode 100644 drivers/misc/panel.c
> >>  delete mode 100644 drivers/staging/panel/Kconfig
> >>  delete mode 100644 drivers/staging/panel/Makefile
> >>  delete mode 100644 drivers/staging/panel/TODO
> >>  delete mode 100644 drivers/staging/panel/lcd-panel-cgram.txt
> >>  delete mode 100644 drivers/staging/panel/panel.c
> >
> >
> > Can you generate a patch like this with the -M option to git
> > format-patch?
> 
> I tried that but it didn't change anything.

It worked for me:

 drivers/misc/Kconfig                      | 278 ++++++++++++++++++++++++++++++
 drivers/misc/Makefile                     |   1 +
 drivers/{staging/panel => misc}/panel.c   |   0
 drivers/staging/Kconfig                   |   2 -
 drivers/staging/Makefile                  |   1 -
 drivers/staging/panel/Kconfig             | 278 ------------------------------
 drivers/staging/panel/Makefile            |   1 -
 drivers/staging/panel/TODO                |   8 -
 drivers/staging/panel/lcd-panel-cgram.txt |  24 ---
 9 files changed, 279 insertions(+), 314 deletions(-)
 rename drivers/{staging/panel => misc}/panel.c (100%)
 delete mode 100644 drivers/staging/panel/Kconfig
 delete mode 100644 drivers/staging/panel/Makefile
 delete mode 100644 drivers/staging/panel/TODO
 delete mode 100644 drivers/staging/panel/lcd-panel-cgram.txt

See the lines that show the file being renamed?

How exactly did you export the patch?

> Also, should panel driver have a separate directory in drivers/misc?

For a single driver, I wouldn't worry about that, putting it in misc/ is fine.
But, you dropped the lcd-panel-cgram.txt file, perhaps you want to keep that
somewhere in Documentation/ ?

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1324297

FromKsenija Stanojević <ksenija.stanojevic@gmail.com>
Date2016-02-02 18:20 +0100
Message-ID<qXMMr-6gE-21@gated-at.bofh.it>
In reply to#1324292
On Tue, Feb 2, 2016 at 6:14 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Tue, Feb 02, 2016 at 05:48:56PM +0100, Ksenija Stanojević wrote:
>> Hi Greg,
>>
>> On Tue, Feb 2, 2016 at 5:23 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>> > On Tue, Feb 02, 2016 at 03:38:21PM +0100, Ksenija Stanojevic wrote:
>> >> Move panel driver from drivers/staging/panel to drivers/misc.
>> >>
>> >> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
>> >> ---
>> >>  drivers/misc/Kconfig                      |  278 ++++
>> >>  drivers/misc/Makefile                     |    1 +
>> >>  drivers/misc/panel.c                      | 2445 +++++++++++++++++++++++++++++
>> >>  drivers/staging/Kconfig                   |    2 -
>> >>  drivers/staging/Makefile                  |    1 -
>> >>  drivers/staging/panel/Kconfig             |  278 ----
>> >>  drivers/staging/panel/Makefile            |    1 -
>> >>  drivers/staging/panel/TODO                |    8 -
>> >>  drivers/staging/panel/lcd-panel-cgram.txt |   24 -
>> >>  drivers/staging/panel/panel.c             | 2445 -----------------------------
>> >>  10 files changed, 2724 insertions(+), 2759 deletions(-)
>> >>  create mode 100644 drivers/misc/panel.c
>> >>  delete mode 100644 drivers/staging/panel/Kconfig
>> >>  delete mode 100644 drivers/staging/panel/Makefile
>> >>  delete mode 100644 drivers/staging/panel/TODO
>> >>  delete mode 100644 drivers/staging/panel/lcd-panel-cgram.txt
>> >>  delete mode 100644 drivers/staging/panel/panel.c
>> >
>> >
>> > Can you generate a patch like this with the -M option to git
>> > format-patch?
>>
>> I tried that but it didn't change anything.
>
> It worked for me:
>
>  drivers/misc/Kconfig                      | 278 ++++++++++++++++++++++++++++++
>  drivers/misc/Makefile                     |   1 +
>  drivers/{staging/panel => misc}/panel.c   |   0
>  drivers/staging/Kconfig                   |   2 -
>  drivers/staging/Makefile                  |   1 -
>  drivers/staging/panel/Kconfig             | 278 ------------------------------
>  drivers/staging/panel/Makefile            |   1 -
>  drivers/staging/panel/TODO                |   8 -
>  drivers/staging/panel/lcd-panel-cgram.txt |  24 ---
>  9 files changed, 279 insertions(+), 314 deletions(-)
>  rename drivers/{staging/panel => misc}/panel.c (100%)
>  delete mode 100644 drivers/staging/panel/Kconfig
>  delete mode 100644 drivers/staging/panel/Makefile
>  delete mode 100644 drivers/staging/panel/TODO
>  delete mode 100644 drivers/staging/panel/lcd-panel-cgram.txt
>
> See the lines that show the file being renamed?
>
> How exactly did you export the patch?

git fomat-patch HEAD^ -M

>> Also, should panel driver have a separate directory in drivers/misc?
>
> For a single driver, I wouldn't worry about that, putting it in misc/ is fine.
> But, you dropped the lcd-panel-cgram.txt file, perhaps you want to keep that
> somewhere in Documentation/ ?

Yes, I wasn't sure about that file, I can place it in Documentation/misc-devices

[toc] | [prev] | [next] | [standalone]

#1324336

FromGreg KH <gregkh@linuxfoundation.org>
Date2016-02-02 18:50 +0100
Message-ID<qXNft-6ut-29@gated-at.bofh.it>
In reply to#1324297
On Tue, Feb 02, 2016 at 06:19:43PM +0100, Ksenija Stanojević wrote:
> On Tue, Feb 2, 2016 at 6:14 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Tue, Feb 02, 2016 at 05:48:56PM +0100, Ksenija Stanojević wrote:
> >> Hi Greg,
> >>
> >> On Tue, Feb 2, 2016 at 5:23 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> >> > On Tue, Feb 02, 2016 at 03:38:21PM +0100, Ksenija Stanojevic wrote:
> >> >> Move panel driver from drivers/staging/panel to drivers/misc.
> >> >>
> >> >> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> >> >> ---
> >> >>  drivers/misc/Kconfig                      |  278 ++++
> >> >>  drivers/misc/Makefile                     |    1 +
> >> >>  drivers/misc/panel.c                      | 2445 +++++++++++++++++++++++++++++
> >> >>  drivers/staging/Kconfig                   |    2 -
> >> >>  drivers/staging/Makefile                  |    1 -
> >> >>  drivers/staging/panel/Kconfig             |  278 ----
> >> >>  drivers/staging/panel/Makefile            |    1 -
> >> >>  drivers/staging/panel/TODO                |    8 -
> >> >>  drivers/staging/panel/lcd-panel-cgram.txt |   24 -
> >> >>  drivers/staging/panel/panel.c             | 2445 -----------------------------
> >> >>  10 files changed, 2724 insertions(+), 2759 deletions(-)
> >> >>  create mode 100644 drivers/misc/panel.c
> >> >>  delete mode 100644 drivers/staging/panel/Kconfig
> >> >>  delete mode 100644 drivers/staging/panel/Makefile
> >> >>  delete mode 100644 drivers/staging/panel/TODO
> >> >>  delete mode 100644 drivers/staging/panel/lcd-panel-cgram.txt
> >> >>  delete mode 100644 drivers/staging/panel/panel.c
> >> >
> >> >
> >> > Can you generate a patch like this with the -M option to git
> >> > format-patch?
> >>
> >> I tried that but it didn't change anything.
> >
> > It worked for me:
> >
> >  drivers/misc/Kconfig                      | 278 ++++++++++++++++++++++++++++++
> >  drivers/misc/Makefile                     |   1 +
> >  drivers/{staging/panel => misc}/panel.c   |   0
> >  drivers/staging/Kconfig                   |   2 -
> >  drivers/staging/Makefile                  |   1 -
> >  drivers/staging/panel/Kconfig             | 278 ------------------------------
> >  drivers/staging/panel/Makefile            |   1 -
> >  drivers/staging/panel/TODO                |   8 -
> >  drivers/staging/panel/lcd-panel-cgram.txt |  24 ---
> >  9 files changed, 279 insertions(+), 314 deletions(-)
> >  rename drivers/{staging/panel => misc}/panel.c (100%)
> >  delete mode 100644 drivers/staging/panel/Kconfig
> >  delete mode 100644 drivers/staging/panel/Makefile
> >  delete mode 100644 drivers/staging/panel/TODO
> >  delete mode 100644 drivers/staging/panel/lcd-panel-cgram.txt
> >
> > See the lines that show the file being renamed?
> >
> > How exactly did you export the patch?
> 
> git fomat-patch HEAD^ -M

I just tried that as well, and got the same result I posted above.

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#1324373

FromKsenija Stanojević <ksenija.stanojevic@gmail.com>
Date2016-02-02 19:20 +0100
Message-ID<qXNIw-6Z3-57@gated-at.bofh.it>
In reply to#1324336
On Tue, Feb 2, 2016 at 6:44 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Tue, Feb 02, 2016 at 06:19:43PM +0100, Ksenija Stanojević wrote:
>> On Tue, Feb 2, 2016 at 6:14 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>> > On Tue, Feb 02, 2016 at 05:48:56PM +0100, Ksenija Stanojević wrote:
>> >> Hi Greg,
>> >>
>> >> On Tue, Feb 2, 2016 at 5:23 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>> >> > On Tue, Feb 02, 2016 at 03:38:21PM +0100, Ksenija Stanojevic wrote:
>> >> >> Move panel driver from drivers/staging/panel to drivers/misc.
>> >> >>
>> >> >> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
>> >> >> ---
>> >> >>  drivers/misc/Kconfig                      |  278 ++++
>> >> >>  drivers/misc/Makefile                     |    1 +
>> >> >>  drivers/misc/panel.c                      | 2445 +++++++++++++++++++++++++++++
>> >> >>  drivers/staging/Kconfig                   |    2 -
>> >> >>  drivers/staging/Makefile                  |    1 -
>> >> >>  drivers/staging/panel/Kconfig             |  278 ----
>> >> >>  drivers/staging/panel/Makefile            |    1 -
>> >> >>  drivers/staging/panel/TODO                |    8 -
>> >> >>  drivers/staging/panel/lcd-panel-cgram.txt |   24 -
>> >> >>  drivers/staging/panel/panel.c             | 2445 -----------------------------
>> >> >>  10 files changed, 2724 insertions(+), 2759 deletions(-)
>> >> >>  create mode 100644 drivers/misc/panel.c
>> >> >>  delete mode 100644 drivers/staging/panel/Kconfig
>> >> >>  delete mode 100644 drivers/staging/panel/Makefile
>> >> >>  delete mode 100644 drivers/staging/panel/TODO
>> >> >>  delete mode 100644 drivers/staging/panel/lcd-panel-cgram.txt
>> >> >>  delete mode 100644 drivers/staging/panel/panel.c
>> >> >
>> >> >
>> >> > Can you generate a patch like this with the -M option to git
>> >> > format-patch?
>> >>
>> >> I tried that but it didn't change anything.
>> >
>> > It worked for me:
>> >
>> >  drivers/misc/Kconfig                      | 278 ++++++++++++++++++++++++++++++
>> >  drivers/misc/Makefile                     |   1 +
>> >  drivers/{staging/panel => misc}/panel.c   |   0
>> >  drivers/staging/Kconfig                   |   2 -
>> >  drivers/staging/Makefile                  |   1 -
>> >  drivers/staging/panel/Kconfig             | 278 ------------------------------
>> >  drivers/staging/panel/Makefile            |   1 -
>> >  drivers/staging/panel/TODO                |   8 -
>> >  drivers/staging/panel/lcd-panel-cgram.txt |  24 ---
>> >  9 files changed, 279 insertions(+), 314 deletions(-)
>> >  rename drivers/{staging/panel => misc}/panel.c (100%)
>> >  delete mode 100644 drivers/staging/panel/Kconfig
>> >  delete mode 100644 drivers/staging/panel/Makefile
>> >  delete mode 100644 drivers/staging/panel/TODO
>> >  delete mode 100644 drivers/staging/panel/lcd-panel-cgram.txt
>> >
>> > See the lines that show the file being renamed?
>> >
>> > How exactly did you export the patch?
>>
>> git fomat-patch HEAD^ -M
>
> I just tried that as well, and got the same result I posted above.

i use git sen-email HEAD^ instead *.patch, now it works.

Thanks,
Ksenija

[toc] | [prev] | [next] | [standalone]

#1324279

FromSudip Mukherjee <sudipm.mukherjee@gmail.com>
Date2016-02-02 18:00 +0100
Message-ID<qXMt5-5Rl-11@gated-at.bofh.it>
In reply to#1324247
On Tue, Feb 02, 2016 at 08:23:20AM -0800, Greg KH wrote:
> On Tue, Feb 02, 2016 at 03:38:21PM +0100, Ksenija Stanojevic wrote:
> > Move panel driver from drivers/staging/panel to drivers/misc.
> > 
> > Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> > ---
> >  drivers/misc/Kconfig                      |  278 ++++
> >  drivers/misc/Makefile                     |    1 +
> >  drivers/misc/panel.c                      | 2445 +++++++++++++++++++++++++++++
> >  drivers/staging/Kconfig                   |    2 -
> >  drivers/staging/Makefile                  |    1 -
> >  drivers/staging/panel/Kconfig             |  278 ----
> >  drivers/staging/panel/Makefile            |    1 -
> >  drivers/staging/panel/TODO                |    8 -
> >  drivers/staging/panel/lcd-panel-cgram.txt |   24 -
> >  drivers/staging/panel/panel.c             | 2445 -----------------------------
> >  10 files changed, 2724 insertions(+), 2759 deletions(-)
> >  create mode 100644 drivers/misc/panel.c
> >  delete mode 100644 drivers/staging/panel/Kconfig
> >  delete mode 100644 drivers/staging/panel/Makefile
> >  delete mode 100644 drivers/staging/panel/TODO
> >  delete mode 100644 drivers/staging/panel/lcd-panel-cgram.txt
> >  delete mode 100644 drivers/staging/panel/panel.c
> 
> 
> Can you generate a patch like this with the -M option to git
> format-patch?  It will show the files being moved, not being deleted and
> added again, making it much easier to see that nothing is changing
> during the move.

while at it please modify the MAINTAINERS file also.

regards
sudip

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web