Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1324203 > unrolled thread

[PATCH v3] EDAC, mpc85xx: fix build warning

Back to article view | Back to linux.kernel

Contents

  [PATCH v3] EDAC, mpc85xx: fix build warning Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-02 16:40 +0100
    Re: [PATCH v3] EDAC, mpc85xx: fix build warning Johannes Thumshirn <jthumshirn@suse.de> - 2016-02-02 17:00 +0100
    Re: [PATCH v3] EDAC, mpc85xx: fix build warning Borislav Petkov <bp@alien8.de> - 2016-02-02 19:00 +0100

#1324203 — [PATCH v3] EDAC, mpc85xx: fix build warning

We were getting build warning about:
drivers/edac/mpc85xx_edac.c:1247:6: warning: unused variable 'pvr'

pvr is only used if CONFIG_FSL_SOC_BOOKE is defined. Use __maybe_unused
while declaring it.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/edac/mpc85xx_edac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
index b7139c1..ca63d0d 100644
--- a/drivers/edac/mpc85xx_edac.c
+++ b/drivers/edac/mpc85xx_edac.c
@@ -1244,7 +1244,7 @@ static struct platform_driver * const drivers[] = {
 static int __init mpc85xx_mc_init(void)
 {
 	int res = 0;
-	u32 pvr = 0;
+	u32 __maybe_unused pvr = 0;
 
 	printk(KERN_INFO "Freescale(R) MPC85xx EDAC driver, "
 	       "(C) 2006 Montavista Software\n");
-- 
1.9.1

[toc] | [next] | [standalone]

#1324225

On Tue, Feb 02, 2016 at 09:09:33PM +0530, Sudip Mukherjee wrote:
> We were getting build warning about:
> drivers/edac/mpc85xx_edac.c:1247:6: warning: unused variable 'pvr'
> 
> pvr is only used if CONFIG_FSL_SOC_BOOKE is defined. Use __maybe_unused
> while declaring it.
> 
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>  drivers/edac/mpc85xx_edac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
> index b7139c1..ca63d0d 100644
> --- a/drivers/edac/mpc85xx_edac.c
> +++ b/drivers/edac/mpc85xx_edac.c
> @@ -1244,7 +1244,7 @@ static struct platform_driver * const drivers[] = {
>  static int __init mpc85xx_mc_init(void)
>  {
>  	int res = 0;
> -	u32 pvr = 0;
> +	u32 __maybe_unused pvr = 0;
>  
>  	printk(KERN_INFO "Freescale(R) MPC85xx EDAC driver, "
>  	       "(C) 2006 Montavista Software\n");
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-edac" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

[toc] | [prev] | [next] | [standalone]

#1324338

On Tue, Feb 02, 2016 at 09:09:33PM +0530, Sudip Mukherjee wrote:
> We were getting build warning about:
> drivers/edac/mpc85xx_edac.c:1247:6: warning: unused variable 'pvr'
> 
> pvr is only used if CONFIG_FSL_SOC_BOOKE is defined. Use __maybe_unused
> while declaring it.
> 
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>  drivers/edac/mpc85xx_edac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
> index b7139c1..ca63d0d 100644
> --- a/drivers/edac/mpc85xx_edac.c
> +++ b/drivers/edac/mpc85xx_edac.c
> @@ -1244,7 +1244,7 @@ static struct platform_driver * const drivers[] = {
>  static int __init mpc85xx_mc_init(void)
>  {
>  	int res = 0;
> -	u32 pvr = 0;
> +	u32 __maybe_unused pvr = 0;
>  
>  	printk(KERN_INFO "Freescale(R) MPC85xx EDAC driver, "
>  	       "(C) 2006 Montavista Software\n");
> -- 

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web