Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1324234 > unrolled thread

Re: [PATCH v6] kernel: add kcov code coverage

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v6] kernel: add kcov code coverage Andrey Ryabinin <ryabinin.a.a@gmail.com> - 2016-02-02 17:10 +0100
    Re: [PATCH v6] kernel: add kcov code coverage Dmitry Vyukov <dvyukov@google.com> - 2016-02-04 16:10 +0100
      Re: [PATCH v6] kernel: add kcov code coverage Andrey Ryabinin <ryabinin.a.a@gmail.com> - 2016-02-04 16:20 +0100

#1324234 — Re: [PATCH v6] kernel: add kcov code coverage

2016-01-25 16:00 GMT+03:00 Dmitry Vyukov <dvyukov@google.com>:

> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index ecb9e75..cde6bd1 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -678,6 +678,26 @@ config DEBUG_STACKOVERFLOW
>
>           If in doubt, say "N".
>
> +config ARCH_HAS_KCOV
> +       bool
> +       help
> +         KCOV does not have any arch-specific code, but currently it is enabled
> +         only for x86_64. KCOV requires testing on other archs, and most likely
> +         disabling of instrumentation for some early boot code.
> +
> +config KCOV
> +       bool "Code coverage for fuzzing"
> +       depends on ARCH_HAS_KCOV

I think we should select DEBUG_FS here, since this useless without it.
Also you placed this into 'Memory Debugging' submenu which seems wrong.

> +       help
> +         KCOV exposes kernel code coverage information in a form suitable
> +         for coverage-guided fuzzing (randomized testing).
> +
> +         If RANDOMIZE_BASE is enabled, PC values will not be stable across
> +         different machines and across reboots. If you need stable PC values,
> +         disable RANDOMIZE_BASE.
> +
> +         For more details, see Documentation/kcov.txt.
> +
>  source "lib/Kconfig.kmemcheck"
>

[toc] | [next] | [standalone]

#1326900

On Tue, Feb 2, 2016 at 5:02 PM, Andrey Ryabinin <ryabinin.a.a@gmail.com> wrote:
> 2016-01-25 16:00 GMT+03:00 Dmitry Vyukov <dvyukov@google.com>:
>
>> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
>> index ecb9e75..cde6bd1 100644
>> --- a/lib/Kconfig.debug
>> +++ b/lib/Kconfig.debug
>> @@ -678,6 +678,26 @@ config DEBUG_STACKOVERFLOW
>>
>>           If in doubt, say "N".
>>
>> +config ARCH_HAS_KCOV
>> +       bool
>> +       help
>> +         KCOV does not have any arch-specific code, but currently it is enabled
>> +         only for x86_64. KCOV requires testing on other archs, and most likely
>> +         disabling of instrumentation for some early boot code.
>> +
>> +config KCOV
>> +       bool "Code coverage for fuzzing"
>> +       depends on ARCH_HAS_KCOV
>
> I think we should select DEBUG_FS here, since this useless without it.

Done in v7

> Also you placed this into 'Memory Debugging' submenu which seems wrong.

Any better suggestions?

>> +       help
>> +         KCOV exposes kernel code coverage information in a form suitable
>> +         for coverage-guided fuzzing (randomized testing).
>> +
>> +         If RANDOMIZE_BASE is enabled, PC values will not be stable across
>> +         different machines and across reboots. If you need stable PC values,
>> +         disable RANDOMIZE_BASE.
>> +
>> +         For more details, see Documentation/kcov.txt.
>> +
>>  source "lib/Kconfig.kmemcheck"
>>

[toc] | [prev] | [next] | [standalone]

#1326916

2016-02-04 18:07 GMT+03:00 Dmitry Vyukov <dvyukov@google.com>:
> On Tue, Feb 2, 2016 at 5:02 PM, Andrey Ryabinin <ryabinin.a.a@gmail.com> wrote:
>> 2016-01-25 16:00 GMT+03:00 Dmitry Vyukov <dvyukov@google.com>:
>>
>>> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
>>> index ecb9e75..cde6bd1 100644
>>> --- a/lib/Kconfig.debug
>>> +++ b/lib/Kconfig.debug
>>> @@ -678,6 +678,26 @@ config DEBUG_STACKOVERFLOW
>>>
>>>           If in doubt, say "N".
>>>
>>> +config ARCH_HAS_KCOV
>>> +       bool
>>> +       help
>>> +         KCOV does not have any arch-specific code, but currently it is enabled
>>> +         only for x86_64. KCOV requires testing on other archs, and most likely
>>> +         disabling of instrumentation for some early boot code.
>>> +
>>> +config KCOV
>>> +       bool "Code coverage for fuzzing"
>>> +       depends on ARCH_HAS_KCOV
>>
>> I think we should select DEBUG_FS here, since this useless without it.
>
> Done in v7
>
>> Also you placed this into 'Memory Debugging' submenu which seems wrong.
>
> Any better suggestions?
>

Just 'Kernel hacking'

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web