Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1324018 > unrolled thread
| Started by | Jisheng Zhang <jszhang@marvell.com> |
|---|---|
| First post | 2016-02-02 13:00 +0100 |
| Last post | 2016-02-02 14:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH v2] mmc: sdhci-of-at91: fix pm runtime unbalanced issue in error path Jisheng Zhang <jszhang@marvell.com> - 2016-02-02 13:00 +0100
Re: [PATCH v2] mmc: sdhci-of-at91: fix pm runtime unbalanced issue in error path Ulf Hansson <ulf.hansson@linaro.org> - 2016-02-02 14:20 +0100
| From | Jisheng Zhang <jszhang@marvell.com> |
|---|---|
| Date | 2016-02-02 13:00 +0100 |
| Subject | [PATCH v2] mmc: sdhci-of-at91: fix pm runtime unbalanced issue in error path |
| Message-ID | <qXHMK-2fP-9@gated-at.bofh.it> |
The device power usage counter is increased by pm_runtime_get_noresume
but isn't decreased in err_add_host error path.
Fix this issue by calling pm_runtime_put_noidle() in the error path to
restore the device's power usage counter.
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Fixes: f5f17813ae9b ("mmc: sdhci-of-at91: add PM support)
---
Since v1:
- Add Ludovic ack
- address Ulf's comment
drivers/mmc/host/sdhci-of-at91.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
index 7db7163..35c02fc 100644
--- a/drivers/mmc/host/sdhci-of-at91.c
+++ b/drivers/mmc/host/sdhci-of-at91.c
@@ -211,6 +211,7 @@ static int sdhci_at91_probe(struct platform_device *pdev)
pm_runtime_disable:
pm_runtime_disable(&pdev->dev);
pm_runtime_set_suspended(&pdev->dev);
+ pm_runtime_put_noidle(&pdev->dev);
clocks_disable_unprepare:
clk_disable_unprepare(priv->gck);
clk_disable_unprepare(priv->mainck);
--
1.9.1
[toc] | [next] | [standalone]
| From | Ulf Hansson <ulf.hansson@linaro.org> |
|---|---|
| Date | 2016-02-02 14:20 +0100 |
| Subject | Re: [PATCH v2] mmc: sdhci-of-at91: fix pm runtime unbalanced issue in error path |
| Message-ID | <qXJ2a-3sQ-29@gated-at.bofh.it> |
| In reply to | #1324018 |
On 2 February 2016 at 12:55, Jisheng Zhang <jszhang@marvell.com> wrote:
> The device power usage counter is increased by pm_runtime_get_noresume
> but isn't decreased in err_add_host error path.
>
> Fix this issue by calling pm_runtime_put_noidle() in the error path to
> restore the device's power usage counter.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> Fixes: f5f17813ae9b ("mmc: sdhci-of-at91: add PM support)
Thanks, applied for fixes!
Kind regards
Uffe
> ---
> Since v1:
> - Add Ludovic ack
> - address Ulf's comment
>
> drivers/mmc/host/sdhci-of-at91.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c
> index 7db7163..35c02fc 100644
> --- a/drivers/mmc/host/sdhci-of-at91.c
> +++ b/drivers/mmc/host/sdhci-of-at91.c
> @@ -211,6 +211,7 @@ static int sdhci_at91_probe(struct platform_device *pdev)
> pm_runtime_disable:
> pm_runtime_disable(&pdev->dev);
> pm_runtime_set_suspended(&pdev->dev);
> + pm_runtime_put_noidle(&pdev->dev);
> clocks_disable_unprepare:
> clk_disable_unprepare(priv->gck);
> clk_disable_unprepare(priv->mainck);
> --
> 1.9.1
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web