Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1323855 > unrolled thread

Re: [PATCH] dts/ls1021a: add the DTS for QSPI support

Started byShawn Guo <shawnguo@kernel.org>
First post2016-02-02 08:50 +0100
Last post2016-02-02 12:50 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] dts/ls1021a: add the DTS for QSPI support Shawn Guo <shawnguo@kernel.org> - 2016-02-02 08:50 +0100
    RE: [PATCH] dts/ls1021a: add the DTS for QSPI support Yao Yuan <yao.yuan@nxp.com> - 2016-02-02 12:50 +0100

#1323855 — Re: [PATCH] dts/ls1021a: add the DTS for QSPI support

FromShawn Guo <shawnguo@kernel.org>
Date2016-02-02 08:50 +0100
SubjectRe: [PATCH] dts/ls1021a: add the DTS for QSPI support
Message-ID<qXDSO-7AO-7@gated-at.bofh.it>
On Thu, Jan 28, 2016 at 04:33:26PM +0800, Yuan Yao wrote:
> From: Yuan Yao <yao.yuan@nxp.com>
> 
> Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
> ---
> Add in v1:
> Can merge, but the function depend on the patch:
> https://patchwork.kernel.org/patch/8118251/

Please send me dts patch only after the driver part gets applied.

> 
> mtd: spi-nor: fsl-quadspi: add support for ls1021a
> 
> LS1021a also support Freescale Quad SPI controller.
> Add fsl-quadspi support for ls1021a chip and make SPI_FSL_QUADSPI
> selectable for LS1021A SOC hardwares.
> 
> ---
>  arch/arm/boot/dts/ls1021a.dtsi | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index 9430a99..c764fa5 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -252,6 +252,21 @@
>  			status = "disabled";
>  		};
>  
> +		qspi: quadspi@1550000 {
> +			compatible = "fsl,ls1021a-qspi";
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0x0 0x1550000 0x0 0x10000>,
> +				<0x0 0x40000000 0x0 0x4000000>;
> +			reg-names = "QuadSPI", "QuadSPI-memory";
> +			interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
> +			clock-names = "qspi_en", "qspi";
> +			clocks = <&platform_clk 1>, <&platform_clk 1>;
> +			big-endian;
> +			amba-base = <0x40000000>;

What is this property?  I cannot find it in any bindings doc.  Is it
added by your patches on driver code?

Shawn

> +			status = "disabled";
> +		};
> +
>  		i2c0: i2c@2180000 {
>  			compatible = "fsl,vf610-i2c";
>  			#address-cells = <1>;
> -- 
> 2.1.0.27.g96db324
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

[toc] | [next] | [standalone]


#1324007

FromYao Yuan <yao.yuan@nxp.com>
Date2016-02-02 12:50 +0100
Message-ID<qXHD4-2bY-17@gated-at.bofh.it>
In reply to#1323855
On Tue, Feb 02, 2016 at 03:49PM, Shawn Guo wrote:
> On Thu, Jan 28, 2016 at 04:33:26PM +0800, Yuan Yao wrote:
> > From: Yuan Yao <yao.yuan@nxp.com>
> >
> > Signed-off-by: Yuan Yao <yao.yuan@nxp.com>
> > ---
> > Add in v1:
> > Can merge, but the function depend on the patch:
> > https://patchwork.kernel.org/patch/8118251/
> 
> Please send me dts patch only after the driver part gets applied.

Ok, I will resend the patch after the driver part gets applied.
I just only want to speed up my upstream.

> 
> >
> > mtd: spi-nor: fsl-quadspi: add support for ls1021a
> >
> > LS1021a also support Freescale Quad SPI controller.
> > Add fsl-quadspi support for ls1021a chip and make SPI_FSL_QUADSPI
> > selectable for LS1021A SOC hardwares.
> >
> > ---
> >  arch/arm/boot/dts/ls1021a.dtsi | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/ls1021a.dtsi
> > b/arch/arm/boot/dts/ls1021a.dtsi index 9430a99..c764fa5 100644
> > --- a/arch/arm/boot/dts/ls1021a.dtsi
> > +++ b/arch/arm/boot/dts/ls1021a.dtsi
> > @@ -252,6 +252,21 @@
> >  			status = "disabled";
> >  		};
> >
> > +		qspi: quadspi@1550000 {
> > +			compatible = "fsl,ls1021a-qspi";
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			reg = <0x0 0x1550000 0x0 0x10000>,
> > +				<0x0 0x40000000 0x0 0x4000000>;
> > +			reg-names = "QuadSPI", "QuadSPI-memory";
> > +			interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>;
> > +			clock-names = "qspi_en", "qspi";
> > +			clocks = <&platform_clk 1>, <&platform_clk 1>;
> > +			big-endian;
> > +			amba-base = <0x40000000>;
> 
> What is this property?  I cannot find it in any bindings doc.  Is it added by your
> patches on driver code?

Sorry, it's the legacy property, after the latest discussion we will remove this property.
So I will remove it in the next version.
Thanks for your review.

Yuan Yao.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web