Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1323923 > unrolled thread
| Started by | Krzysztof Adamski <krzysztof.adamski@sonymobile.com> |
|---|---|
| First post | 2016-02-02 11:10 +0100 |
| Last post | 2016-02-02 14:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] pinctrl: sunxi: H3 requires irq_read_needs_mux Krzysztof Adamski <krzysztof.adamski@sonymobile.com> - 2016-02-02 11:10 +0100
Re: [PATCH] pinctrl: sunxi: H3 requires irq_read_needs_mux Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-02-02 14:30 +0100
| From | Krzysztof Adamski <krzysztof.adamski@sonymobile.com> |
|---|---|
| Date | 2016-02-02 11:10 +0100 |
| Subject | [PATCH] pinctrl: sunxi: H3 requires irq_read_needs_mux |
| Message-ID | <qXG4k-ZH-43@gated-at.bofh.it> |
It seems that on H3, just like on A10, when GPIOs are configured as
external interrupt data registers does not contain their value. When
value is read, GPIO function must be temporary switched to input for
reads.
Signed-off-by: Krzysztof Adamski <k@japko.eu>
---
drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c b/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c
index 77d4cf0..11760bb 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c
@@ -492,6 +492,7 @@ static const struct sunxi_pinctrl_desc sun8i_h3_pinctrl_data = {
.pins = sun8i_h3_pins,
.npins = ARRAY_SIZE(sun8i_h3_pins),
.irq_banks = 2,
+ .irq_read_needs_mux = true
};
static int sun8i_h3_pinctrl_probe(struct platform_device *pdev)
--
2.4.2
[toc] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2016-02-02 14:30 +0100 |
| Message-ID | <qXJbS-3xo-55@gated-at.bofh.it> |
| In reply to | #1323923 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, Feb 02, 2016 at 11:03:03AM +0100, Krzysztof Adamski wrote: > It seems that on H3, just like on A10, when GPIOs are configured as > external interrupt data registers does not contain their value. When > value is read, GPIO function must be temporary switched to input for > reads. > > Signed-off-by: Krzysztof Adamski <k@japko.eu> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web