Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1323833 > unrolled thread
| Started by | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| First post | 2016-02-02 07:50 +0100 |
| Last post | 2016-02-02 09:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ocfs2: fix build warning Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-02 07:50 +0100
Re: [PATCH] ocfs2: fix build warning Ryan Ding <ryan.ding@oracle.com> - 2016-02-02 09:10 +0100
| From | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| Date | 2016-02-02 07:50 +0100 |
| Subject | [PATCH] ocfs2: fix build warning |
| Message-ID | <qXCWK-6RP-13@gated-at.bofh.it> |
We were getting build warning about:
/fs/ocfs2/file.c: In function ‘ocfs2_file_write_iter’:
fs/ocfs2/file.c:2198:1: warning: label ‘relock’ defined but not used
The previous commit has cleaned up the code for direct io and removed
the jump instruction to relock, but missed removing the label which is
unused now.
Fixes: 1a46f12e5071 ("ocfs2: code clean up for direct io")
Cc: Ryan Ding <ryan.ding@oracle.com>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
fs/ocfs2/file.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
index 41c506e..c18ab45 100644
--- a/fs/ocfs2/file.c
+++ b/fs/ocfs2/file.c
@@ -2195,7 +2195,6 @@ static ssize_t ocfs2_file_write_iter(struct kiocb *iocb,
inode_lock(inode);
-relock:
/*
* Concurrent O_DIRECT writes are allowed with
* mount_option "coherency=buffered".
--
1.9.1
[toc] | [next] | [standalone]
| From | Ryan Ding <ryan.ding@oracle.com> |
|---|---|
| Date | 2016-02-02 09:10 +0100 |
| Message-ID | <qXEc9-80M-5@gated-at.bofh.it> |
| In reply to | #1323833 |
On 02/02/2016 02:46 PM, Sudip Mukherjee wrote:
> We were getting build warning about:
> /fs/ocfs2/file.c: In function ‘ocfs2_file_write_iter’:
> fs/ocfs2/file.c:2198:1: warning: label ‘relock’ defined but not used
>
> The previous commit has cleaned up the code for direct io and removed
> the jump instruction to relock, but missed removing the label which is
> unused now.
>
> Fixes: 1a46f12e5071 ("ocfs2: code clean up for direct io")
> Cc: Ryan Ding <ryan.ding@oracle.com>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Reviewed-by: Ryan Ding<ryan.ding@oracle.com>
> ---
> fs/ocfs2/file.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
> index 41c506e..c18ab45 100644
> --- a/fs/ocfs2/file.c
> +++ b/fs/ocfs2/file.c
> @@ -2195,7 +2195,6 @@ static ssize_t ocfs2_file_write_iter(struct kiocb *iocb,
>
> inode_lock(inode);
>
> -relock:
> /*
> * Concurrent O_DIRECT writes are allowed with
> * mount_option "coherency=buffered".
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web