Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1323831 > unrolled thread

[PATCH] usb: xhci: fix build warning

Back to article view | Back to linux.kernel

Contents

  [PATCH] usb: xhci: fix build warning Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-02 07:40 +0100
    Re: [PATCH] usb: xhci: fix build warning Mathias Nyman <mathias.nyman@linux.intel.com> - 2016-02-02 09:10 +0100

#1323831 — [PATCH] usb: xhci: fix build warning

We were getting build warning about:

drivers/usb/host/xhci.c: In function ‘xhci_add_ep_to_interval_table’:
drivers/usb/host/xhci.c:2499:2: warning: enumeration value
        ‘USB_SPEED_SUPER_PLUS’ not handled in switch

Fix it by adding SuperSpeedPlus USB3.1 devices as the behaviour is same
as with USB_SPEED_SUPER SuperSpeed devices.

Fixes: 8a1b2725a60d ("usb: define USB_SPEED_SUPER_PLUS speed for SuperSpeedPlus USB3.1 devices")
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/usb/host/xhci.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 26a44c0..5bde15b 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -2410,7 +2410,7 @@ void xhci_drop_ep_from_interval_table(struct xhci_hcd *xhci,
 	if (xhci_is_async_ep(ep_bw->type))
 		return;
 
-	if (udev->speed == USB_SPEED_SUPER) {
+	if (udev->speed >= USB_SPEED_SUPER) {
 		if (xhci_is_sync_in_ep(ep_bw->type))
 			xhci->devs[udev->slot_id]->bw_table->ss_bw_in -=
 				xhci_get_ss_bw_consumed(ep_bw);
@@ -2448,6 +2448,7 @@ void xhci_drop_ep_from_interval_table(struct xhci_hcd *xhci,
 		interval_bw->overhead[HS_OVERHEAD_TYPE] -= 1;
 		break;
 	case USB_SPEED_SUPER:
+	case USB_SPEED_SUPER_PLUS:
 	case USB_SPEED_UNKNOWN:
 	case USB_SPEED_WIRELESS:
 		/* Should never happen because only LS/FS/HS endpoints will get
@@ -2474,7 +2475,7 @@ static void xhci_add_ep_to_interval_table(struct xhci_hcd *xhci,
 	if (xhci_is_async_ep(ep_bw->type))
 		return;
 
-	if (udev->speed == USB_SPEED_SUPER) {
+	if (udev->speed >= USB_SPEED_SUPER) {
 		if (xhci_is_sync_in_ep(ep_bw->type))
 			xhci->devs[udev->slot_id]->bw_table->ss_bw_in +=
 				xhci_get_ss_bw_consumed(ep_bw);
@@ -2507,6 +2508,7 @@ static void xhci_add_ep_to_interval_table(struct xhci_hcd *xhci,
 		interval_bw->overhead[HS_OVERHEAD_TYPE] += 1;
 		break;
 	case USB_SPEED_SUPER:
+	case USB_SPEED_SUPER_PLUS:
 	case USB_SPEED_UNKNOWN:
 	case USB_SPEED_WIRELESS:
 		/* Should never happen because only LS/FS/HS endpoints will get
-- 
1.9.1

[toc] | [next] | [standalone]

#1323869

On 02.02.2016 08:30, Sudip Mukherjee wrote:
> We were getting build warning about:
>
> drivers/usb/host/xhci.c: In function ‘xhci_add_ep_to_interval_table’:
> drivers/usb/host/xhci.c:2499:2: warning: enumeration value
>          ‘USB_SPEED_SUPER_PLUS’ not handled in switch
>
> Fix it by adding SuperSpeedPlus USB3.1 devices as the behaviour is same
> as with USB_SPEED_SUPER SuperSpeed devices.
>
> Fixes: 8a1b2725a60d ("usb: define USB_SPEED_SUPER_PLUS speed for SuperSpeedPlus USB3.1 devices")
> Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>

The original series that added USB_SPEED_SUPER_PLUS to both core and xhci was only partly accepted.
The core part was applied, the rest was asked to be resubmitted.

Second part is still waiting to be applied.
http://www.spinics.net/lists/linux-usb/msg135493.html

-Mathias

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web