Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1320792 > unrolled thread
| Started by | Vlastimil Babka <vbabka@suse.cz> |
|---|---|
| First post | 2016-01-28 16:40 +0100 |
| Last post | 2016-02-02 09:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] mm/Kconfig: correct description of DEFERRED_STRUCT_PAGE_INIT Vlastimil Babka <vbabka@suse.cz> - 2016-01-28 16:40 +0100
Re: [PATCH] mm/Kconfig: correct description of DEFERRED_STRUCT_PAGE_INIT Mel Gorman <mgorman@techsingularity.net> - 2016-02-02 09:50 +0100
| From | Vlastimil Babka <vbabka@suse.cz> |
|---|---|
| Date | 2016-01-28 16:40 +0100 |
| Subject | [PATCH] mm/Kconfig: correct description of DEFERRED_STRUCT_PAGE_INIT |
| Message-ID | <qVWPU-5sX-11@gated-at.bofh.it> |
The description mentions kswapd threads, while the deferred struct page initialization is actually done by one-off "pgdatinitX" threads. Fix the description so that potentially users are not confused about pgdatinit threads using CPU after boot instead of kswapd. Signed-off-by: Vlastimil Babka <vbabka@suse.cz> --- mm/Kconfig | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/mm/Kconfig b/mm/Kconfig index 97a4e06b15c0..03cbfa072f42 100644 --- a/mm/Kconfig +++ b/mm/Kconfig @@ -624,7 +624,7 @@ config ARCH_SUPPORTS_DEFERRED_STRUCT_PAGE_INIT bool config DEFERRED_STRUCT_PAGE_INIT - bool "Defer initialisation of struct pages to kswapd" + bool "Defer initialisation of struct pages to kthreads" default n depends on ARCH_SUPPORTS_DEFERRED_STRUCT_PAGE_INIT depends on MEMORY_HOTPLUG @@ -633,9 +633,10 @@ config DEFERRED_STRUCT_PAGE_INIT single thread. On very large machines this can take a considerable amount of time. If this option is set, large machines will bring up a subset of memmap at boot and then initialise the rest in parallel - when kswapd starts. This has a potential performance impact on - processes running early in the lifetime of the systemm until kswapd - finishes the initialisation. + by starting one-off "pgdatinitX" kernel thread for each node X. This + has a potential performance impact on processes running early in the + lifetime of the system until these kthreads finish the + initialisation. config IDLE_PAGE_TRACKING bool "Enable idle page tracking" -- 2.7.0
[toc] | [next] | [standalone]
| From | Mel Gorman <mgorman@techsingularity.net> |
|---|---|
| Date | 2016-02-02 09:50 +0100 |
| Subject | Re: [PATCH] mm/Kconfig: correct description of DEFERRED_STRUCT_PAGE_INIT |
| Message-ID | <qXEOR-8jh-5@gated-at.bofh.it> |
| In reply to | #1320792 |
On Thu, Jan 28, 2016 at 04:37:28PM +0100, Vlastimil Babka wrote: > The description mentions kswapd threads, while the deferred struct page > initialization is actually done by one-off "pgdatinitX" threads. Fix the > description so that potentially users are not confused about pgdatinit threads > using CPU after boot instead of kswapd. > > Signed-off-by: Vlastimil Babka <vbabka@suse.cz> Acked-by: Mel Gorman <mgorman@techsingularity.net> This was an oversight when I moved to using kernel threads to do the initialisation instead. Thanks for catching it. -- Mel Gorman SUSE Labs
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web