Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1322740 > unrolled thread

[PATCH] ARM: pxa: fix irq initialization for pxa3xx devicetree

Back to article view | Back to linux.kernel

Contents

  [PATCH] ARM: pxa: fix irq initialization for pxa3xx devicetree Robert Jarzmik <robert.jarzmik@free.fr> - 2016-01-31 22:10 +0100
    Re: [PATCH] ARM: pxa: fix irq initialization for pxa3xx devicetree Robert Jarzmik <robert.jarzmik@free.fr> - 2016-02-06 22:50 +0100

#1322740 — [PATCH] ARM: pxa: fix irq initialization for pxa3xx devicetree

The initialization of interrupt controller for devicetree platform was
done for pxa2xx platforms, but not for pxa3xx ones.

Fix this my adding the missing initialization call.

Fixes: 089d03629b04 ("ARM: pxa: add devicetree code for irq handling")
Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
---
 arch/arm/mach-pxa/pxa-dt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-pxa/pxa-dt.c b/arch/arm/mach-pxa/pxa-dt.c
index bed3fa741f54..f128133a8f30 100644
--- a/arch/arm/mach-pxa/pxa-dt.c
+++ b/arch/arm/mach-pxa/pxa-dt.c
@@ -28,6 +28,7 @@ static const char *const pxa3xx_dt_board_compat[] __initconst = {
 
 DT_MACHINE_START(PXA_DT, "Marvell PXA3xx (Device Tree Support)")
 	.map_io		= pxa3xx_map_io,
+	.init_irq	= pxa3xx_dt_init_irq,
 	.handle_irq	= pxa3xx_handle_irq,
 	.restart	= pxa_restart,
 	.dt_compat	= pxa3xx_dt_board_compat,
-- 
2.1.4

[toc] | [next] | [standalone]

#1328378

Robert Jarzmik <robert.jarzmik@free.fr> writes:

> The initialization of interrupt controller for devicetree platform was
> done for pxa2xx platforms, but not for pxa3xx ones.
>
> Fix this my adding the missing initialization call.
>
> Fixes: 089d03629b04 ("ARM: pxa: add devicetree code for irq handling")
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
No, this is incorrect.

The reason behind is that it relies on a patch not yet upstreamed, which was
breaking exactly this init_irq.

Let's drop this and replace it with the good patch.

Cheers.

--
Robert

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web