Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1321055 > unrolled thread

[PATCH v2] USB: option: add support for SIM7100E

Started byAndrey Skvortsov <andrej.skvortzov@gmail.com>
First post2016-01-28 22:10 +0100
Last post2016-01-31 21:30 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH v2] USB: option: add support for SIM7100E Andrey Skvortsov <andrej.skvortzov@gmail.com> - 2016-01-28 22:10 +0100
    Re: [PATCH v2] USB: option: add support for SIM7100E Johan Hovold <johan@kernel.org> - 2016-01-31 21:20 +0100
      Re: [PATCH v2] USB: option: add support for SIM7100E Andrey Skvortsov <andrej.skvortzov@gmail.com> - 2016-01-31 21:30 +0100

#1321055 — [PATCH v2] USB: option: add support for SIM7100E

FromAndrey Skvortsov <andrej.skvortzov@gmail.com>
Date2016-01-28 22:10 +0100
Subject[PATCH v2] USB: option: add support for SIM7100E
Message-ID<qW1Zg-Nq-13@gated-at.bofh.it>
$ lsusb:
Bus 001 Device 101: ID 1e0e:9001 Qualcomm / Option

$ usb-devices:
T:  Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#=101 Spd=480  MxCh= 0
D:  Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  2
P:  Vendor=1e0e ProdID=9001 Rev= 2.32
S:  Manufacturer=SimTech, Incorporated
S:  Product=SimTech, Incorporated
S:  SerialNumber=0123456789ABCDEF
C:* #Ifs= 7 Cfg#= 1 Atr=80 MxPwr=500mA
I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=option
I:* If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
I:* If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
I:* If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
I:* If#= 5 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
I:* If#= 6 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none)

The last interface (6) is used for Android Composite ADB interface.

Serial port layout:
0: QCDM/DIAG
1: NMEA
2: AT
3: AT/PPP
4: audio

Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>
---
 v2: respin v1 against usb-linus branch of git://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git
     move SIM7100E product id to ALINK entries
     move SIM7100E usb_device_id initialization to ALINK initializations
     
 drivers/usb/serial/option.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index db86e51..1a22950 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -317,6 +317,7 @@ static void option_instat_callback(struct urb *urb);
 #define ALINK_VENDOR_ID				0x1e0e
 #define ALINK_PRODUCT_PH300			0x9100
 #define ALINK_PRODUCT_3GU			0x9200
+#define SIMCOM_PRODUCT_SIM7100E			0x9001 /* Yes, ALINK_VENDOR_ID */
 
 /* ALCATEL PRODUCTS */
 #define ALCATEL_VENDOR_ID			0x1bbb
@@ -627,6 +628,10 @@ static const struct option_blacklist_info telit_le922_blacklist_usbcfg3 = {
 	.reserved = BIT(1) | BIT(2) | BIT(3),
 };
 
+static const struct option_blacklist_info simcom_sim7100e_blacklist = {
+	.reserved = BIT(5) | BIT(6),
+};
+
 static const struct usb_device_id option_ids[] = {
 	{ USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_COLT) },
 	{ USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_RICOLA) },
@@ -1645,6 +1650,8 @@ static const struct usb_device_id option_ids[] = {
 	{ USB_DEVICE(ALINK_VENDOR_ID, 0x9000) },
 	{ USB_DEVICE(ALINK_VENDOR_ID, ALINK_PRODUCT_PH300) },
 	{ USB_DEVICE_AND_INTERFACE_INFO(ALINK_VENDOR_ID, ALINK_PRODUCT_3GU, 0xff, 0xff, 0xff) },
+	{ USB_DEVICE(ALINK_VENDOR_ID, SIMCOM_PRODUCT_SIM7100E),
+	  .driver_info = (kernel_ulong_t)&simcom_sim7100e_blacklist },
 	{ USB_DEVICE(ALCATEL_VENDOR_ID, ALCATEL_PRODUCT_X060S_X200),
 	  .driver_info = (kernel_ulong_t)&alcatel_x200_blacklist
 	},
-- 
2.7.0.rc3

[toc] | [next] | [standalone]

#1322728

FromJohan Hovold <johan@kernel.org>
Date2016-01-31 21:20 +0100
Message-ID<qX6Dv-5f-3@gated-at.bofh.it>
In reply to#1321055
On Fri, Jan 29, 2016 at 12:07:30AM +0300, Andrey Skvortsov wrote:
> $ lsusb:
> Bus 001 Device 101: ID 1e0e:9001 Qualcomm / Option
> 
> $ usb-devices:
> T:  Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#=101 Spd=480  MxCh= 0
> D:  Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  2
> P:  Vendor=1e0e ProdID=9001 Rev= 2.32
> S:  Manufacturer=SimTech, Incorporated
> S:  Product=SimTech, Incorporated
> S:  SerialNumber=0123456789ABCDEF
> C:* #Ifs= 7 Cfg#= 1 Atr=80 MxPwr=500mA
> I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=option
> I:* If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I:* If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I:* If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I:* If#= 5 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
> I:* If#= 6 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none)
> 
> The last interface (6) is used for Android Composite ADB interface.
> 
> Serial port layout:
> 0: QCDM/DIAG
> 1: NMEA
> 2: AT
> 3: AT/PPP
> 4: audio
> 
> Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>
> ---
>  v2: respin v1 against usb-linus branch of git://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git
>      move SIM7100E product id to ALINK entries
>      move SIM7100E usb_device_id initialization to ALINK initializations

Thanks for respinning. I'll queue this one up for 4.5-rc.

Johan

[toc] | [prev] | [next] | [standalone]

#1322737

FromAndrey Skvortsov <andrej.skvortzov@gmail.com>
Date2016-01-31 21:30 +0100
Message-ID<qX6Nc-a6-3@gated-at.bofh.it>
In reply to#1322728

[Multipart message — attachments visible in raw view] — view raw

On Sun, Jan 31, 2016 at 09:13:19PM +0100, Johan Hovold wrote:
> On Fri, Jan 29, 2016 at 12:07:30AM +0300, Andrey Skvortsov wrote:
> > $ lsusb:
> > Bus 001 Device 101: ID 1e0e:9001 Qualcomm / Option
> > 
> > $ usb-devices:
> > T:  Bus=01 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#=101 Spd=480  MxCh= 0
> > D:  Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  2
> > P:  Vendor=1e0e ProdID=9001 Rev= 2.32
> > S:  Manufacturer=SimTech, Incorporated
> > S:  Product=SimTech, Incorporated
> > S:  SerialNumber=0123456789ABCDEF
> > C:* #Ifs= 7 Cfg#= 1 Atr=80 MxPwr=500mA
> > I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=option
> > I:* If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> > I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> > I:* If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> > I:* If#= 4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> > I:* If#= 5 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
> > I:* If#= 6 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=42 Prot=01 Driver=(none)
> > 
> > The last interface (6) is used for Android Composite ADB interface.
> > 
> > Serial port layout:
> > 0: QCDM/DIAG
> > 1: NMEA
> > 2: AT
> > 3: AT/PPP
> > 4: audio
> > 
> > Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>
> > ---
> >  v2: respin v1 against usb-linus branch of git://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git
> >      move SIM7100E product id to ALINK entries
> >      move SIM7100E usb_device_id initialization to ALINK initializations
> 
> Thanks for respinning. I'll queue this one up for 4.5-rc.

Thank you.


-- 
Best regards,
Andrey Skvortsov

PGP Key ID: 0x57A3AEAD

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web