Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1321652 > unrolled thread

[PATCH v2 1/2] ASoC: fsl-asoc-card: add cs4271 and cs4272 support

Started by"Felipe F. Tonello" <eu@felipetonello.com>
First post2016-01-29 12:10 +0100
Last post2016-02-01 16:30 +0100
Articles 6 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH v2 1/2] ASoC: fsl-asoc-card: add cs4271 and cs4272 support "Felipe F. Tonello" <eu@felipetonello.com> - 2016-01-29 12:10 +0100
    [PATCH v2 2/2] devicetree: sound: Fix fsl-asoc-card identation "Felipe F. Tonello" <eu@felipetonello.com> - 2016-01-29 12:10 +0100
      Re: [PATCH v2 2/2] devicetree: sound: Fix fsl-asoc-card identation Nicolin Chen <nicoleotsuka@gmail.com> - 2016-01-29 19:10 +0100
        Re: [PATCH v2 2/2] devicetree: sound: Fix fsl-asoc-card identation Felipe Ferreri Tonello <eu@felipetonello.com> - 2016-01-31 18:50 +0100
    Re: [PATCH v2 1/2] ASoC: fsl-asoc-card: add cs4271 and cs4272 support Nicolin Chen <nicoleotsuka@gmail.com> - 2016-01-29 19:00 +0100
    Re: [PATCH v2 1/2] ASoC: fsl-asoc-card: add cs4271 and cs4272 support Rob Herring <robh@kernel.org> - 2016-02-01 16:30 +0100

#1321652 — [PATCH v2 1/2] ASoC: fsl-asoc-card: add cs4271 and cs4272 support

From"Felipe F. Tonello" <eu@felipetonello.com>
Date2016-01-29 12:10 +0100
Subject[PATCH v2 1/2] ASoC: fsl-asoc-card: add cs4271 and cs4272 support
Message-ID<qWf69-1Wx-7@gated-at.bofh.it>
add cs4271 and cs42727 support for fsl-asoc-card

Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
 Documentation/devicetree/bindings/sound/fsl-asoc-card.txt | 9 +++++++++
 sound/soc/fsl/Kconfig                                     | 4 ++--
 sound/soc/fsl/fsl-asoc-card.c                             | 7 +++++++
 3 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt b/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt
index 4da41bf1888e..ceaef5126989 100644
--- a/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt
+++ b/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt
@@ -24,6 +24,9 @@ The compatible list for this generic sound card currently:
 
  "fsl,imx-audio-cs42888"
 
+ "fsl,imx-audio-cs427x"
+ (compatible with CS4271 and CS4272)
+
  "fsl,imx-audio-wm8962"
  (compatible with Documentation/devicetree/bindings/sound/imx-audio-wm8962.txt)
 
@@ -63,6 +66,12 @@ Optional properties:
   - audio-asrc		: The phandle of ASRC. It can be absent if there's no
 			  need to add ASRC support via DPCM.
 
+Optional unless SSI is selected as a CPU DAI:
+
+  - mux-int-port	: The internal port of the i.MX audio muxer (AUDMUX)
+
+  - mux-ext-port	: The external port of the i.MX audio muxer
+
 Example:
 sound-cs42888 {
 	compatible = "fsl,imx-audio-cs42888";
diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index 14dfdee05fd5..35aabf9dc503 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -292,8 +292,8 @@ config SND_SOC_FSL_ASOC_CARD
 	select SND_SOC_FSL_SSI
 	help
 	 ALSA SoC Audio support with ASRC feature for Freescale SoCs that have
-	 ESAI/SAI/SSI and connect with external CODECs such as WM8962, CS42888
-	 and SGTL5000.
+	 ESAI/SAI/SSI and connect with external CODECs such as WM8962, CS42888,
+	 CS4271, CS4272 and SGTL5000.
 	 Say Y if you want to add support for Freescale Generic ASoC Sound Card.
 
 endif # SND_IMX_SOC
diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c
index 562b3bd22d9a..56b6b07d1922 100644
--- a/sound/soc/fsl/fsl-asoc-card.c
+++ b/sound/soc/fsl/fsl-asoc-card.c
@@ -28,6 +28,8 @@
 #include "../codecs/wm8962.h"
 #include "../codecs/wm8960.h"
 
+#define CS427x_SYSCLK_MCLK 0
+
 #define RX 0
 #define TX 1
 
@@ -528,6 +530,10 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
 		priv->cpu_priv.sysclk_dir[RX] = SND_SOC_CLOCK_OUT;
 		priv->cpu_priv.slot_width = 32;
 		priv->dai_fmt |= SND_SOC_DAIFMT_CBS_CFS;
+	} else if (of_device_is_compatible(np, "fsl,imx-audio-cs427x")) {
+		codec_dai_name = "cs4271-hifi";
+		priv->codec_priv.mclk_id = CS427x_SYSCLK_MCLK;
+		priv->dai_fmt |= SND_SOC_DAIFMT_CBM_CFM;
 	} else if (of_device_is_compatible(np, "fsl,imx-audio-sgtl5000")) {
 		codec_dai_name = "sgtl5000";
 		priv->codec_priv.mclk_id = SGTL5000_SYSCLK;
@@ -681,6 +687,7 @@ fail:
 static const struct of_device_id fsl_asoc_card_dt_ids[] = {
 	{ .compatible = "fsl,imx-audio-ac97", },
 	{ .compatible = "fsl,imx-audio-cs42888", },
+	{ .compatible = "fsl,imx-audio-cs427x", },
 	{ .compatible = "fsl,imx-audio-sgtl5000", },
 	{ .compatible = "fsl,imx-audio-wm8962", },
 	{ .compatible = "fsl,imx-audio-wm8960", },
-- 
2.7.0

[toc] | [next] | [standalone]

#1321653 — [PATCH v2 2/2] devicetree: sound: Fix fsl-asoc-card identation

From"Felipe F. Tonello" <eu@felipetonello.com>
Date2016-01-29 12:10 +0100
Subject[PATCH v2 2/2] devicetree: sound: Fix fsl-asoc-card identation
Message-ID<qWf69-1Wx-11@gated-at.bofh.it>
In reply to#1321652
Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
 Documentation/devicetree/bindings/sound/fsl-asoc-card.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt b/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt
index ceaef5126989..16b254b04f8c 100644
--- a/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt
+++ b/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt
@@ -43,7 +43,7 @@ Required properties:
 
   - audio-cpu		: The phandle of an CPU DAI controller
 
-  - audio-codec		: The phandle of an audio codec
+  - audio-codec	: The phandle of an audio codec
 
   - audio-routing	: A list of the connections between audio components.
 			  Each entry is a pair of strings, the first being the
-- 
2.7.0

[toc] | [prev] | [next] | [standalone]

#1321944 — Re: [PATCH v2 2/2] devicetree: sound: Fix fsl-asoc-card identation

FromNicolin Chen <nicoleotsuka@gmail.com>
Date2016-01-29 19:10 +0100
SubjectRe: [PATCH v2 2/2] devicetree: sound: Fix fsl-asoc-card identation
Message-ID<qWlED-71J-21@gated-at.bofh.it>
In reply to#1321653
On Fri, Jan 29, 2016 at 11:01:01AM +0000, Felipe F. Tonello wrote:
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> ---
>  Documentation/devicetree/bindings/sound/fsl-asoc-card.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt b/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt
> index ceaef5126989..16b254b04f8c 100644
> --- a/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt
> +++ b/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt
> @@ -43,7 +43,7 @@ Required properties:
>  
>    - audio-cpu		: The phandle of an CPU DAI controller
>  
> -  - audio-codec		: The phandle of an audio codec
> +  - audio-codec	: The phandle of an audio codec

The indentation was fine actually.....how did you see it misaligned?

>    - audio-routing	: A list of the connections between audio components.
>  			  Each entry is a pair of strings, the first being the
> -- 
> 2.7.0
>

[toc] | [prev] | [next] | [standalone]

#1322692 — Re: [PATCH v2 2/2] devicetree: sound: Fix fsl-asoc-card identation

FromFelipe Ferreri Tonello <eu@felipetonello.com>
Date2016-01-31 18:50 +0100
SubjectRe: [PATCH v2 2/2] devicetree: sound: Fix fsl-asoc-card identation
Message-ID<qX4im-6H4-1@gated-at.bofh.it>
In reply to#1321944

[Multipart message — attachments visible in raw view] — view raw

Hi Nicolin,

On 29/01/16 18:02, Nicolin Chen wrote:
> On Fri, Jan 29, 2016 at 11:01:01AM +0000, Felipe F. Tonello wrote:
>> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
>> ---
>>  Documentation/devicetree/bindings/sound/fsl-asoc-card.txt | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt b/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt
>> index ceaef5126989..16b254b04f8c 100644
>> --- a/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt
>> +++ b/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt
>> @@ -43,7 +43,7 @@ Required properties:
>>  
>>    - audio-cpu		: The phandle of an CPU DAI controller
>>  
>> -  - audio-codec		: The phandle of an audio codec
>> +  - audio-codec	: The phandle of an audio codec
> 
> The indentation was fine actually.....how did you see it misaligned?

It doesn't look right on tab width as 8 spaces. I use `less -x8' for
core.pager git config for example.

But if it is correct, just ignore this patch then.

Thanks

-- 
Felipe

[toc] | [prev] | [next] | [standalone]

#1321938

FromNicolin Chen <nicoleotsuka@gmail.com>
Date2016-01-29 19:00 +0100
Message-ID<qWluY-6FF-33@gated-at.bofh.it>
In reply to#1321652
On Fri, Jan 29, 2016 at 11:01:00AM +0000, Felipe F. Tonello wrote:
> add cs4271 and cs42727 support for fsl-asoc-card
> 
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>

Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>

> ---
>  Documentation/devicetree/bindings/sound/fsl-asoc-card.txt | 9 +++++++++
>  sound/soc/fsl/Kconfig                                     | 4 ++--
>  sound/soc/fsl/fsl-asoc-card.c                             | 7 +++++++
>  3 files changed, 18 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt b/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt
> index 4da41bf1888e..ceaef5126989 100644
> --- a/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt
> +++ b/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt
> @@ -24,6 +24,9 @@ The compatible list for this generic sound card currently:
>  
>   "fsl,imx-audio-cs42888"
>  
> + "fsl,imx-audio-cs427x"
> + (compatible with CS4271 and CS4272)
> +
>   "fsl,imx-audio-wm8962"
>   (compatible with Documentation/devicetree/bindings/sound/imx-audio-wm8962.txt)
>  
> @@ -63,6 +66,12 @@ Optional properties:
>    - audio-asrc		: The phandle of ASRC. It can be absent if there's no
>  			  need to add ASRC support via DPCM.
>  
> +Optional unless SSI is selected as a CPU DAI:
> +
> +  - mux-int-port	: The internal port of the i.MX audio muxer (AUDMUX)
> +
> +  - mux-ext-port	: The external port of the i.MX audio muxer
> +
>  Example:
>  sound-cs42888 {
>  	compatible = "fsl,imx-audio-cs42888";
> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> index 14dfdee05fd5..35aabf9dc503 100644
> --- a/sound/soc/fsl/Kconfig
> +++ b/sound/soc/fsl/Kconfig
> @@ -292,8 +292,8 @@ config SND_SOC_FSL_ASOC_CARD
>  	select SND_SOC_FSL_SSI
>  	help
>  	 ALSA SoC Audio support with ASRC feature for Freescale SoCs that have
> -	 ESAI/SAI/SSI and connect with external CODECs such as WM8962, CS42888
> -	 and SGTL5000.
> +	 ESAI/SAI/SSI and connect with external CODECs such as WM8962, CS42888,
> +	 CS4271, CS4272 and SGTL5000.
>  	 Say Y if you want to add support for Freescale Generic ASoC Sound Card.
>  
>  endif # SND_IMX_SOC
> diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c
> index 562b3bd22d9a..56b6b07d1922 100644
> --- a/sound/soc/fsl/fsl-asoc-card.c
> +++ b/sound/soc/fsl/fsl-asoc-card.c
> @@ -28,6 +28,8 @@
>  #include "../codecs/wm8962.h"
>  #include "../codecs/wm8960.h"
>  
> +#define CS427x_SYSCLK_MCLK 0
> +
>  #define RX 0
>  #define TX 1
>  
> @@ -528,6 +530,10 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
>  		priv->cpu_priv.sysclk_dir[RX] = SND_SOC_CLOCK_OUT;
>  		priv->cpu_priv.slot_width = 32;
>  		priv->dai_fmt |= SND_SOC_DAIFMT_CBS_CFS;
> +	} else if (of_device_is_compatible(np, "fsl,imx-audio-cs427x")) {
> +		codec_dai_name = "cs4271-hifi";
> +		priv->codec_priv.mclk_id = CS427x_SYSCLK_MCLK;
> +		priv->dai_fmt |= SND_SOC_DAIFMT_CBM_CFM;
>  	} else if (of_device_is_compatible(np, "fsl,imx-audio-sgtl5000")) {
>  		codec_dai_name = "sgtl5000";
>  		priv->codec_priv.mclk_id = SGTL5000_SYSCLK;
> @@ -681,6 +687,7 @@ fail:
>  static const struct of_device_id fsl_asoc_card_dt_ids[] = {
>  	{ .compatible = "fsl,imx-audio-ac97", },
>  	{ .compatible = "fsl,imx-audio-cs42888", },
> +	{ .compatible = "fsl,imx-audio-cs427x", },
>  	{ .compatible = "fsl,imx-audio-sgtl5000", },
>  	{ .compatible = "fsl,imx-audio-wm8962", },
>  	{ .compatible = "fsl,imx-audio-wm8960", },
> -- 
> 2.7.0
>

[toc] | [prev] | [next] | [standalone]

#1323233

FromRob Herring <robh@kernel.org>
Date2016-02-01 16:30 +0100
Message-ID<qXoAr-4Of-31@gated-at.bofh.it>
In reply to#1321652
On Fri, Jan 29, 2016 at 11:01:00AM +0000, Felipe F. Tonello wrote:
> add cs4271 and cs42727 support for fsl-asoc-card
> 
> Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
> ---
>  Documentation/devicetree/bindings/sound/fsl-asoc-card.txt | 9 +++++++++
>  sound/soc/fsl/Kconfig                                     | 4 ++--
>  sound/soc/fsl/fsl-asoc-card.c                             | 7 +++++++
>  3 files changed, 18 insertions(+), 2 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web