Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1321818 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-01-29 16:00 +0100 |
| Last post | 2016-02-01 02:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 4/6] ARM: s3c24xx: don't select RFKILL if CONFIG_NET is disabled Arnd Bergmann <arnd@arndb.de> - 2016-01-29 16:00 +0100
Re: [PATCH 4/6] ARM: s3c24xx: don't select RFKILL if CONFIG_NET is disabled Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-01 02:10 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-01-29 16:00 +0100 |
| Subject | [PATCH 4/6] ARM: s3c24xx: don't select RFKILL if CONFIG_NET is disabled |
| Message-ID | <qWiGL-4DM-51@gated-at.bofh.it> |
Bluetooth is only supported when network support is part of the kernel, so it is a bit pointless to build the hi1940-bt support without networking. If we try anyway, we get a Kconfig warning: warning: (TOSA_BT && H1940BT) selects RFKILL which has unmet direct dependencies (NET) This adds a dependency on CONFIG_NET to avoid that case. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arm/mach-s3c24xx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig index 5884bbb7952e..bf66c8334822 100644 --- a/arch/arm/mach-s3c24xx/Kconfig +++ b/arch/arm/mach-s3c24xx/Kconfig @@ -227,7 +227,7 @@ config ARCH_H1940 config H1940BT tristate "Control the state of H1940 bluetooth chip" - depends on ARCH_H1940 + depends on ARCH_H1940 && NET select RFKILL help This is a simple driver that is able to control -- 2.7.0
[toc] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2016-02-01 02:10 +0100 |
| Subject | Re: [PATCH 4/6] ARM: s3c24xx: don't select RFKILL if CONFIG_NET is disabled |
| Message-ID | <qXba9-3n0-5@gated-at.bofh.it> |
| In reply to | #1321818 |
On 29.01.2016 23:50, Arnd Bergmann wrote: > Bluetooth is only supported when network support is part of the kernel, > so it is a bit pointless to build the hi1940-bt support without networking. > If we try anyway, we get a Kconfig warning: > > warning: (TOSA_BT && H1940BT) selects RFKILL which has unmet direct dependencies (NET) > > This adds a dependency on CONFIG_NET to avoid that case. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arm/mach-s3c24xx/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-s3c24xx/Kconfig b/arch/arm/mach-s3c24xx/Kconfig > index 5884bbb7952e..bf66c8334822 100644 > --- a/arch/arm/mach-s3c24xx/Kconfig > +++ b/arch/arm/mach-s3c24xx/Kconfig > @@ -227,7 +227,7 @@ config ARCH_H1940 > > config H1940BT > tristate "Control the state of H1940 bluetooth chip" > - depends on ARCH_H1940 > + depends on ARCH_H1940 && NET > select RFKILL > help > This is a simple driver that is able to control I think there shouldn't be a reverse dependency for RFKILL but instead just: depends on ARCH_H1940 && RFKILL This makes it simpler and RFKILL is a user-visible symbol. Best regards, Krzysztof
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web