Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1321812 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-01-29 16:00 +0100 |
| Last post | 2016-02-01 02:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 6/6] ARM: exynos: select THERMAL_OF Arnd Bergmann <arnd@arndb.de> - 2016-01-29 16:00 +0100
Re: [PATCH 6/6] ARM: exynos: select THERMAL_OF Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-01 02:30 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-01-29 16:00 +0100 |
| Subject | [PATCH 6/6] ARM: exynos: select THERMAL_OF |
| Message-ID | <qWiGL-4DM-33@gated-at.bofh.it> |
We cannot select a symbol that has disabled dependencies, so we get a warning if we ever enable EXYNOS_THERMAL without also turning on THERMAL_OF: warning: (ARCH_EXYNOS) selects EXYNOS_THERMAL which has unmet direct dependencies (THERMAL && (ARCH_EXYNOS || COMPILE_TEST) && THERMAL_OF) This adds another 'select' in the platform code to avoid that case. Alternatively, we could decide to not select EXYNOS_THERMAL here and instead make it a user option. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arm/mach-exynos/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig index 652a0bb11578..5189bcecad12 100644 --- a/arch/arm/mach-exynos/Kconfig +++ b/arch/arm/mach-exynos/Kconfig @@ -27,6 +27,7 @@ menuconfig ARCH_EXYNOS select S5P_DEV_MFC select SRAM select THERMAL + select THERMAL_OF select MFD_SYSCON select CLKSRC_EXYNOS_MCT select POWER_RESET -- 2.7.0
[toc] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2016-02-01 02:30 +0100 |
| Message-ID | <qXbtw-3vW-5@gated-at.bofh.it> |
| In reply to | #1321812 |
On 29.01.2016 23:50, Arnd Bergmann wrote:
> We cannot select a symbol that has disabled dependencies, so
> we get a warning if we ever enable EXYNOS_THERMAL without
> also turning on THERMAL_OF:
>
> warning: (ARCH_EXYNOS) selects EXYNOS_THERMAL which has unmet direct dependencies (THERMAL && (ARCH_EXYNOS || COMPILE_TEST) && THERMAL_OF)
>
> This adds another 'select' in the platform code to avoid that
> case. Alternatively, we could decide to not select EXYNOS_THERMAL
> here and instead make it a user option.
We want EXYNOS_THERMAL because we are using boost cpufreq on Exynos4x12
(through turbo frequencies in DTS and cpufreq-dt) so your current
solution is a proper fix for:
Fixes: f87e6bd3f740 ("thermal: exynos: Add the dependency of
CONFIG_THERMAL_OF instead of CONFIG_OF")
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/arm/mach-exynos/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
> index 652a0bb11578..5189bcecad12 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -27,6 +27,7 @@ menuconfig ARCH_EXYNOS
> select S5P_DEV_MFC
> select SRAM
> select THERMAL
> + select THERMAL_OF
> select MFD_SYSCON
> select CLKSRC_EXYNOS_MCT
> select POWER_RESET
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web