Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1321810 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-01-29 16:00 +0100 |
| Last post | 2016-02-01 01:50 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 3/6] ARM: s3c24xx: fix unused gta02_configure_pmu_for_charger warning Arnd Bergmann <arnd@arndb.de> - 2016-01-29 16:00 +0100
Re: [PATCH 3/6] ARM: s3c24xx: fix unused gta02_configure_pmu_for_charger warning Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-01 01:50 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-01-29 16:00 +0100 |
| Subject | [PATCH 3/6] ARM: s3c24xx: fix unused gta02_configure_pmu_for_charger warning |
| Message-ID | <qWiGK-4DM-23@gated-at.bofh.it> |
gta02_configure_pmu_for_charger is only used when CONFIG_PCF50633_ADC
is set, and otherwise we get a warning about an unused symbol:
arch/arm/mach-s3c24xx/mach-gta02.c:158:1: warning: 'gta02_configure_pmu_for_charger' defined but not used [-Wunused-function]
gta02_configure_pmu_for_charger(struct pcf50633 *pcf, void *unused, int res)
This adds an #ifdef to shut up the warning.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
arch/arm/mach-s3c24xx/mach-gta02.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-s3c24xx/mach-gta02.c b/arch/arm/mach-s3c24xx/mach-gta02.c
index 6d1e0b9c5b27..27ae6877550f 100644
--- a/arch/arm/mach-s3c24xx/mach-gta02.c
+++ b/arch/arm/mach-s3c24xx/mach-gta02.c
@@ -154,6 +154,7 @@ static struct s3c2410_uartcfg gta02_uartcfgs[] = {
#define ADC_NOM_CHG_DETECT_1A 6
#define ADC_NOM_CHG_DETECT_USB 43
+#ifdef CONFIG_PCF50633_ADC
static void
gta02_configure_pmu_for_charger(struct pcf50633 *pcf, void *unused, int res)
{
@@ -174,6 +175,7 @@ gta02_configure_pmu_for_charger(struct pcf50633 *pcf, void *unused, int res)
pcf50633_mbc_usb_curlim_set(pcf, ma);
}
+#endif
static struct delayed_work gta02_charger_work;
static int gta02_usb_vbus_draw;
--
2.7.0
[toc] | [next] | [standalone]
| From | Krzysztof Kozlowski <k.kozlowski@samsung.com> |
|---|---|
| Date | 2016-02-01 01:50 +0100 |
| Subject | Re: [PATCH 3/6] ARM: s3c24xx: fix unused gta02_configure_pmu_for_charger warning |
| Message-ID | <qXaQN-2Zi-1@gated-at.bofh.it> |
| In reply to | #1321810 |
On 29.01.2016 23:50, Arnd Bergmann wrote: > gta02_configure_pmu_for_charger is only used when CONFIG_PCF50633_ADC > is set, and otherwise we get a warning about an unused symbol: > > arch/arm/mach-s3c24xx/mach-gta02.c:158:1: warning: 'gta02_configure_pmu_for_charger' defined but not used [-Wunused-function] > gta02_configure_pmu_for_charger(struct pcf50633 *pcf, void *unused, int res) > > This adds an #ifdef to shut up the warning. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/arm/mach-s3c24xx/mach-gta02.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web