Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1322320 > unrolled thread

[PATCH V2] mfd: core: add macro for adding mfd cells

Back to article view | Back to linux.kernel

Contents

  [PATCH V2] mfd: core: add macro for adding mfd cells Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-30 11:00 +0100

#1322320 — [PATCH V2] mfd: core: add macro for adding mfd cells

Most of MFD drivers add the mfd sub devices cells as follows:
static const struct mfd_cell as3722_devs[] = {
        {
                .name = "as3722-pinctrl",
        },
        {
                .name = "as3722-regulator",
        },
        {
                .name = "as3722-rtc",
                .num_resources = ARRAY_SIZE(as3722_rtc_resource),
                .resources = as3722_rtc_resource,
        },
        {
                .name = "as3722-adc",
                .num_resources = ARRAY_SIZE(as3722_adc_resource),
                .resources = as3722_adc_resource,
        },
 };

Add defines for adding mfd cells so that it can be done in single line
as follows:
static const struct mfd_cell as3722_devs[] = {
	DEFINE_MFD_CELL_NAME("as3722-pinctrl"),
	DEFINE_MFD_CELL_NAME("as3722-regulator"),
	DEFINE_MFD_CELL_NAME_RESOURCE("as3722-rtc", as3722_rtc_resource),
	DEFINE_MFD_CELL_NAME_RESOURCE("as3722-adc", as3722_adc_resource),
};

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
I am sending this patch based on review comment recived on max77620
mfd patch to use/add macro whereever possible.
Once this is reviewed and agreed, I will post series of mfd patches
to use this macro.

Changes from V1:
- Missing "_" from argument name which was causing the compilation issue.
- This is found when using both macro.

 include/linux/mfd/core.h | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h
index bc6f7e0..3fa4ab7 100644
--- a/include/linux/mfd/core.h
+++ b/include/linux/mfd/core.h
@@ -14,6 +14,7 @@
 #ifndef MFD_CORE_H
 #define MFD_CORE_H
 
+#include <linux/kernel.h>
 #include <linux/platform_device.h>
 
 struct irq_domain;
@@ -81,6 +82,20 @@ struct mfd_cell {
 	int			num_parent_supplies;
 };
 
+/* Defne mfd cells with name and resource */
+#define DEFINE_MFD_CELL_NAME_RESOURCE(_name, _res)		\
+	{							\
+		.name = (_name),				\
+		.num_resources = ARRAY_SIZE((_res)),		\
+		.resources = (_res),				\
+	}
+
+/* Defne mfd cells with name */
+#define DEFINE_MFD_CELL_NAME(_name)				\
+	{							\
+		.name = (_name),				\
+	}
+
 /*
  * Convenience functions for clients using shared cells.  Refcounting
  * happens automatically, with the cell's enable/disable callbacks
-- 
2.1.4

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web