Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1321159 > unrolled thread
| Started by | Insu Yun <wuninsu@gmail.com> |
|---|---|
| First post | 2016-01-29 01:00 +0100 |
| Last post | 2016-02-09 10:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ch7006: correctly handling failed allocation Insu Yun <wuninsu@gmail.com> - 2016-01-29 01:00 +0100
Re: [PATCH] ch7006: correctly handling failed allocation Daniel Vetter <daniel@ffwll.ch> - 2016-02-09 10:30 +0100
| From | Insu Yun <wuninsu@gmail.com> |
|---|---|
| Date | 2016-01-29 01:00 +0100 |
| Subject | [PATCH] ch7006: correctly handling failed allocation |
| Message-ID | <qW4DN-2tl-15@gated-at.bofh.it> |
Since drm_property_create_range can be failed in memory pressure, it needs to be checked and return -ENOMEM. Signed-off-by: Insu Yun <wuninsu@gmail.com> --- drivers/gpu/drm/i2c/ch7006_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch7006_drv.c index 90db5f4..0594c45 100644 --- a/drivers/gpu/drm/i2c/ch7006_drv.c +++ b/drivers/gpu/drm/i2c/ch7006_drv.c @@ -253,6 +253,8 @@ static int ch7006_encoder_create_resources(struct drm_encoder *encoder, drm_mode_create_tv_properties(dev, NUM_TV_NORMS, ch7006_tv_norm_names); priv->scale_property = drm_property_create_range(dev, 0, "scale", 0, 2); + if (!priv->scale_property) + return -ENOMEM; drm_object_attach_property(&connector->base, conf->tv_select_subconnector_property, priv->select_subconnector); -- 1.9.1
[toc] | [next] | [standalone]
| From | Daniel Vetter <daniel@ffwll.ch> |
|---|---|
| Date | 2016-02-09 10:30 +0100 |
| Message-ID | <r0cMr-25f-23@gated-at.bofh.it> |
| In reply to | #1321159 |
On Thu, Jan 28, 2016 at 06:54:36PM -0500, Insu Yun wrote: > Since drm_property_create_range can be failed in memory pressure, > it needs to be checked and return -ENOMEM. > > Signed-off-by: Insu Yun <wuninsu@gmail.com> Applied to drm-misc, thanks. -Daniel > --- > drivers/gpu/drm/i2c/ch7006_drv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch7006_drv.c > index 90db5f4..0594c45 100644 > --- a/drivers/gpu/drm/i2c/ch7006_drv.c > +++ b/drivers/gpu/drm/i2c/ch7006_drv.c > @@ -253,6 +253,8 @@ static int ch7006_encoder_create_resources(struct drm_encoder *encoder, > drm_mode_create_tv_properties(dev, NUM_TV_NORMS, ch7006_tv_norm_names); > > priv->scale_property = drm_property_create_range(dev, 0, "scale", 0, 2); > + if (!priv->scale_property) > + return -ENOMEM; > > drm_object_attach_property(&connector->base, conf->tv_select_subconnector_property, > priv->select_subconnector); > -- > 1.9.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web