Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1321040 > unrolled thread

[PATCH RFC 0/3] leds: add SN3218 LED driver

Back to article view | Back to linux.kernel

Contents

  [PATCH RFC 0/3] leds: add SN3218 LED driver Stefan Wahren <stefan.wahren@i2se.com> - 2016-01-28 21:50 +0100
    [PATCH RFC 2/3] DT: add binding for SN3218 LED driver Stefan Wahren <stefan.wahren@i2se.com> - 2016-01-28 21:50 +0100
      Re: [PATCH RFC 2/3] DT: add binding for SN3218 LED driver Rob Herring <robh@kernel.org> - 2016-01-29 04:30 +0100

#1321040 — [PATCH RFC 0/3] leds: add SN3218 LED driver

This patch series implements support for the Si-En SN3218
18 Channel LED Driver through I2C. This implemention only write
data over I2C und get the platform data via DT.

The driver has been tested on a Raspberry Pi B.

Stefan Wahren (3):
  of: Add vendor prefix for Si-En Technology
  DT: add binding for SN3218 LED driver
  leds: add SN3218 LED driver

 .../devicetree/bindings/leds/leds-sn3218.txt       |   41 ++++
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 drivers/leds/Kconfig                               |    8 +
 drivers/leds/Makefile                              |    1 +
 drivers/leds/leds-sn3218.c                         |  254 ++++++++++++++++++++
 5 files changed, 305 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-sn3218.txt
 create mode 100644 drivers/leds/leds-sn3218.c

-- 
1.7.9.5

[toc] | [next] | [standalone]

#1321047 — [PATCH RFC 2/3] DT: add binding for SN3218 LED driver

This patch adds the binding for Si-En Technology SN3218
18-Channel LED driver.

Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
 .../devicetree/bindings/leds/leds-sn3218.txt       |   41 ++++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-sn3218.txt

diff --git a/Documentation/devicetree/bindings/leds/leds-sn3218.txt b/Documentation/devicetree/bindings/leds/leds-sn3218.txt
new file mode 100644
index 0000000..bf632df
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/leds-sn3218.txt
@@ -0,0 +1,41 @@
+* Si-En Technology - SN3218 18-Channel LED Driver
+
+Required properties:
+- compatible :
+	"si-en,sn3218"
+- address-cells : must be 1
+- size-cells : must be 0
+- reg : I2C slave address, typically 0x54
+
+Each led is represented as a sub-node of the si-en,sn3218 device.
+
+LED sub-node properties:
+- label : (optional) see Documentation/devicetree/bindings/leds/common.txt
+- reg : number of LED line (could be from 0 to 17)
+- linux,default-trigger : (optional)
+   see Documentation/devicetree/bindings/leds/common.txt
+
+Example:
+
+sn3218@54 {
+	compatible = "si-en,sn3218";
+	#address-cells = <1>;
+	#size-cells = <0>;
+	reg = <0x54>;
+
+	led1@0 {
+		label = "led1";
+		reg = <0x0>;
+	};
+
+	led2@1 {
+		label = "led2";
+		reg = <0x1>;
+	};
+
+	led3@2 {
+		label = "led3";
+		reg = <0x2>;
+	};
+};
+
-- 
1.7.9.5

[toc] | [prev] | [next] | [standalone]

#1321457 — Re: [PATCH RFC 2/3] DT: add binding for SN3218 LED driver

On Thu, Jan 28, 2016 at 08:41:06PM +0000, Stefan Wahren wrote:
> This patch adds the binding for Si-En Technology SN3218
> 18-Channel LED driver.
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
>  .../devicetree/bindings/leds/leds-sn3218.txt       |   41 ++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/leds/leds-sn3218.txt

One nit, otherwise:

Acked-by: Rob Herring <robh@kernel.org>

> 
> diff --git a/Documentation/devicetree/bindings/leds/leds-sn3218.txt b/Documentation/devicetree/bindings/leds/leds-sn3218.txt
> new file mode 100644
> index 0000000..bf632df
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-sn3218.txt
> @@ -0,0 +1,41 @@
> +* Si-En Technology - SN3218 18-Channel LED Driver
> +
> +Required properties:
> +- compatible :
> +	"si-en,sn3218"
> +- address-cells : must be 1
> +- size-cells : must be 0
> +- reg : I2C slave address, typically 0x54
> +
> +Each led is represented as a sub-node of the si-en,sn3218 device.
> +
> +LED sub-node properties:
> +- label : (optional) see Documentation/devicetree/bindings/leds/common.txt
> +- reg : number of LED line (could be from 0 to 17)
> +- linux,default-trigger : (optional)
> +   see Documentation/devicetree/bindings/leds/common.txt
> +
> +Example:
> +
> +sn3218@54 {
> +	compatible = "si-en,sn3218";
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	reg = <0x54>;
> +
> +	led1@0 {

Just led@X please.

> +		label = "led1";
> +		reg = <0x0>;
> +	};
> +
> +	led2@1 {
> +		label = "led2";
> +		reg = <0x1>;
> +	};
> +
> +	led3@2 {
> +		label = "led3";
> +		reg = <0x2>;
> +	};
> +};
> +
> -- 
> 1.7.9.5
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web