Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1320853 > unrolled thread
| Started by | Mauro Carvalho Chehab <mchehab@osg.samsung.com> |
|---|---|
| First post | 2016-01-28 17:40 +0100 |
| Last post | 2016-01-28 21:10 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 22/31] media: dvb-core create tuner to demod pad link in disabled state Mauro Carvalho Chehab <mchehab@osg.samsung.com> - 2016-01-28 17:40 +0100
Re: [PATCH 22/31] media: dvb-core create tuner to demod pad link in disabled state Shuah Khan <shuahkh@osg.samsung.com> - 2016-01-28 21:10 +0100
| From | Mauro Carvalho Chehab <mchehab@osg.samsung.com> |
|---|---|
| Date | 2016-01-28 17:40 +0100 |
| Subject | Re: [PATCH 22/31] media: dvb-core create tuner to demod pad link in disabled state |
| Message-ID | <qVXLZ-65U-23@gated-at.bofh.it> |
Em Wed, 6 Jan 2016 13:27:11 -0700
Shuah Khan <shuahkh@osg.samsung.com> escreveu:
> Create tuner to demod pad link in disabled state to help avoid
> disable step when tuner resource is requested by video or audio.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> ---
> drivers/media/dvb-core/dvbdev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c
> index b56e008..1d10fa6 100644
> --- a/drivers/media/dvb-core/dvbdev.c
> +++ b/drivers/media/dvb-core/dvbdev.c
> @@ -593,8 +593,9 @@ int dvb_create_media_graph(struct dvb_adapter *adap)
> }
>
> if (tuner && demod) {
> + /* create tuner to demod link deactivated */
> ret = media_create_pad_link(tuner, TUNER_PAD_IF_OUTPUT,
> - demod, 0, MEDIA_LNK_FL_ENABLED);
> + demod, 0, 0);
This is not right, as it makes no sense for DVB-only drivers.
> if (ret)
> return ret;
> }
[toc] | [next] | [standalone]
| From | Shuah Khan <shuahkh@osg.samsung.com> |
|---|---|
| Date | 2016-01-28 21:10 +0100 |
| Message-ID | <qW13c-a7-9@gated-at.bofh.it> |
| In reply to | #1320853 |
On 01/28/2016 09:38 AM, Mauro Carvalho Chehab wrote:
> Em Wed, 6 Jan 2016 13:27:11 -0700
> Shuah Khan <shuahkh@osg.samsung.com> escreveu:
>
>> Create tuner to demod pad link in disabled state to help avoid
>> disable step when tuner resource is requested by video or audio.
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>> drivers/media/dvb-core/dvbdev.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c
>> index b56e008..1d10fa6 100644
>> --- a/drivers/media/dvb-core/dvbdev.c
>> +++ b/drivers/media/dvb-core/dvbdev.c
>> @@ -593,8 +593,9 @@ int dvb_create_media_graph(struct dvb_adapter *adap)
>> }
>>
>> if (tuner && demod) {
>> + /* create tuner to demod link deactivated */
>> ret = media_create_pad_link(tuner, TUNER_PAD_IF_OUTPUT,
>> - demod, 0, MEDIA_LNK_FL_ENABLED);
>> + demod, 0, 0);
>
> This is not right, as it makes no sense for DVB-only drivers.
Right. Not a good change for DVB only drivers. But does make
sense on hybrid. I will make sure it gets done only in hyrbid
cases.
thanks,
-- Shuah
>
>> if (ret)
>> return ret;
>> }
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web