Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1318655 > unrolled thread
| Started by | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| First post | 2016-01-27 06:20 +0100 |
| Last post | 2016-01-27 07:20 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[RFC PATCH 07/21] mmc: sdhci-pxav3: consolidate parsing path Shawn Lin <shawn.lin@rock-chips.com> - 2016-01-27 06:20 +0100
Re: [RFC PATCH 07/21] mmc: sdhci-pxav3: consolidate parsing path Jisheng Zhang <jszhang@marvell.com> - 2016-01-27 06:50 +0100
Re: [RFC PATCH 07/21] mmc: sdhci-pxav3: consolidate parsing path Shawn Lin <shawn.lin@rock-chips.com> - 2016-01-27 07:20 +0100
| From | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| Date | 2016-01-27 06:20 +0100 |
| Subject | [RFC PATCH 07/21] mmc: sdhci-pxav3: consolidate parsing path |
| Message-ID | <qVqGn-6Zi-43@gated-at.bofh.it> |
This patch remove mmc_of_parse and check return value
of sdhci_get_of_property.
Cc: Jisheng Zhang <jszhang@marvell.com>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
drivers/mmc/host/sdhci-pxav3.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
index f5edf9d..06eda25 100644
--- a/drivers/mmc/host/sdhci-pxav3.c
+++ b/drivers/mmc/host/sdhci-pxav3.c
@@ -410,10 +410,8 @@ static int sdhci_pxav3_probe(struct platform_device *pdev)
match = of_match_device(of_match_ptr(sdhci_pxav3_of_match), &pdev->dev);
if (match) {
- ret = mmc_of_parse(host->mmc);
- if (ret)
+ ret = sdhci_get_of_property(pdev);
goto err_of_parse;
- sdhci_get_of_property(pdev);
pdata = pxav3_get_mmc_pdata(dev);
pdev->dev.platform_data = pdata;
} else if (pdata) {
--
2.3.7
[toc] | [next] | [standalone]
| From | Jisheng Zhang <jszhang@marvell.com> |
|---|---|
| Date | 2016-01-27 06:50 +0100 |
| Message-ID | <qVr9n-7eZ-7@gated-at.bofh.it> |
| In reply to | #1318655 |
Hi Shawn,
On Wed, 27 Jan 2016 13:07:36 +0800 Shawn Lin wrote:
> This patch remove mmc_of_parse and check return value
> of sdhci_get_of_property.
>
> Cc: Jisheng Zhang <jszhang@marvell.com>
> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Reviewed-by: Jisheng Zhang <jszhang@marvell.com>
But I have some comments to your patch10:
> SDHCI_QUIRK_BROKEN_CARD_DETECTION is for "broken-cd".
> If we add MMC_CAP_NONREMOVABLE("non-removeble"), we shoud
> not add "broken-cd" together according to mmc.txt for
> dt-bingdings. Also, "broken-cd" can obtain from mmc_of_parse,
> which will add MMC_CAP_NEEDS_POLL into mmc->caps.
The problem is non-dt platforms which need the broken cd quirk don't have
chance to set MMC_CAP_NEEDS_POLL in driver, unless we explicitly do so
in driver. But then, the driver only need to do so on some platforms but
not always.
Thanks,
Jisheng
> ---
>
> drivers/mmc/host/sdhci-pxav3.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
> index f5edf9d..06eda25 100644
> --- a/drivers/mmc/host/sdhci-pxav3.c
> +++ b/drivers/mmc/host/sdhci-pxav3.c
> @@ -410,10 +410,8 @@ static int sdhci_pxav3_probe(struct platform_device *pdev)
>
> match = of_match_device(of_match_ptr(sdhci_pxav3_of_match), &pdev->dev);
> if (match) {
> - ret = mmc_of_parse(host->mmc);
> - if (ret)
> + ret = sdhci_get_of_property(pdev);
> goto err_of_parse;
> - sdhci_get_of_property(pdev);
> pdata = pxav3_get_mmc_pdata(dev);
> pdev->dev.platform_data = pdata;
> } else if (pdata) {
[toc] | [prev] | [next] | [standalone]
| From | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| Date | 2016-01-27 07:20 +0100 |
| Message-ID | <qVrCq-7KH-7@gated-at.bofh.it> |
| In reply to | #1318675 |
Hi Jisheng,
On 2016/1/27 13:44, Jisheng Zhang wrote:
> Hi Shawn,
>
> On Wed, 27 Jan 2016 13:07:36 +0800 Shawn Lin wrote:
>
>> This patch remove mmc_of_parse and check return value
>> of sdhci_get_of_property.
>>
>> Cc: Jisheng Zhang <jszhang@marvell.com>
>> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>
> Reviewed-by: Jisheng Zhang <jszhang@marvell.com>
>
>
> But I have some comments to your patch10:
>
>> SDHCI_QUIRK_BROKEN_CARD_DETECTION is for "broken-cd".
>> If we add MMC_CAP_NONREMOVABLE("non-removeble"), we shoud
>> not add "broken-cd" together according to mmc.txt for
>> dt-bingdings. Also, "broken-cd" can obtain from mmc_of_parse,
>> which will add MMC_CAP_NEEDS_POLL into mmc->caps.
>
> The problem is non-dt platforms which need the broken cd quirk don't have
> chance to set MMC_CAP_NEEDS_POLL in driver, unless we explicitly do so
> in driver. But then, the driver only need to do so on some platforms but
> not always.
>
Thanks for sharing your thought. That is indeed a historical baggage
to improve sdhci. So, it needs to check each platform case by case.
Let's wait more feedback untile I decide how to respin the patchset. :)
> Thanks,
> Jisheng
>
>
>> ---
>>
>> drivers/mmc/host/sdhci-pxav3.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
>> index f5edf9d..06eda25 100644
>> --- a/drivers/mmc/host/sdhci-pxav3.c
>> +++ b/drivers/mmc/host/sdhci-pxav3.c
>> @@ -410,10 +410,8 @@ static int sdhci_pxav3_probe(struct platform_device *pdev)
>>
>> match = of_match_device(of_match_ptr(sdhci_pxav3_of_match), &pdev->dev);
>> if (match) {
>> - ret = mmc_of_parse(host->mmc);
>> - if (ret)
>> + ret = sdhci_get_of_property(pdev);
>> goto err_of_parse;
>> - sdhci_get_of_property(pdev);
>> pdata = pxav3_get_mmc_pdata(dev);
>> pdev->dev.platform_data = pdata;
>> } else if (pdata) {
>
>
>
>
--
Best Regards
Shawn Lin
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web