Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1318340 > unrolled thread

[PATCH 2/2] iio: si7005: add support for Hoperf th02

Started byCristina Moraru <cristina.moraru09@gmail.com>
First post2016-01-26 21:30 +0100
Last post2016-01-27 10:20 +0100
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 2/2] iio: si7005: add support for Hoperf th02 Cristina Moraru <cristina.moraru09@gmail.com> - 2016-01-26 21:30 +0100
    Re: [PATCH 2/2] iio: si7005: add support for Hoperf th02 Matt Ranostay <mranostay@gmail.com> - 2016-01-27 00:00 +0100
      Re: [PATCH 2/2] iio: si7005: add support for Hoperf th02 Daniel Baluta <daniel.baluta@intel.com> - 2016-01-27 10:20 +0100

#1318340 — [PATCH 2/2] iio: si7005: add support for Hoperf th02

FromCristina Moraru <cristina.moraru09@gmail.com>
Date2016-01-26 21:30 +0100
Subject[PATCH 2/2] iio: si7005: add support for Hoperf th02
Message-ID<qVipt-Vs-23@gated-at.bofh.it>
This patch adds support for Hoperf th02 humidity and
temperature sensor as it uses same register definitions
as si7005

th02 Datasheet: http://www.anglia-live.com/netalogue/pdfs/hrf/datasheets/TH02_V1.1.pdf

Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
---
 drivers/iio/humidity/Kconfig  | 3 ++-
 drivers/iio/humidity/si7005.c | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig
index c1f3a21..866dda1 100644
--- a/drivers/iio/humidity/Kconfig
+++ b/drivers/iio/humidity/Kconfig
@@ -43,7 +43,8 @@ config SI7005
 	  humidity and temperature sensor.
 
 	  To compile this driver as a module, choose M here: the module
-	  will be called si7005.
+	  will be called si7005. This driver also
+	  supports Hoperf TH02 Humidity and Temperature Sensor.
 
 config SI7020
 	tristate "Si7013/20/21 Relative Humidity and Temperature Sensors"
diff --git a/drivers/iio/humidity/si7005.c b/drivers/iio/humidity/si7005.c
index 91972cc..98a022f 100644
--- a/drivers/iio/humidity/si7005.c
+++ b/drivers/iio/humidity/si7005.c
@@ -170,6 +170,7 @@ static int si7005_probe(struct i2c_client *client,
 
 static const struct i2c_device_id si7005_id[] = {
 	{ "si7005", 0 },
+	{ "th02", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(i2c, si7005_id);
-- 
1.9.1

[toc] | [next] | [standalone]


#1318453

FromMatt Ranostay <mranostay@gmail.com>
Date2016-01-27 00:00 +0100
Message-ID<qVkKB-2Cf-1@gated-at.bofh.it>
In reply to#1318340
On Tue, Jan 26, 2016 at 12:21 PM, Cristina Moraru
<cristina.moraru09@gmail.com> wrote:
> This patch adds support for Hoperf th02 humidity and
> temperature sensor as it uses same register definitions
> as si7005
>
> th02 Datasheet: http://www.anglia-live.com/netalogue/pdfs/hrf/datasheets/TH02_V1.1.pdf
>
> Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
> ---
>  drivers/iio/humidity/Kconfig  | 3 ++-
>  drivers/iio/humidity/si7005.c | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig
> index c1f3a21..866dda1 100644
> --- a/drivers/iio/humidity/Kconfig
> +++ b/drivers/iio/humidity/Kconfig
> @@ -43,7 +43,8 @@ config SI7005
>           humidity and temperature sensor.
>
>           To compile this driver as a module, choose M here: the module
> -         will be called si7005.
> +         will be called si7005. This driver also
> +         supports Hoperf TH02 Humidity and Temperature Sensor.

This probably shouldn't be changing the Kconfig description. Since if
every driver added a line for each device/variant it supported
everything would get quite wordy.

>
>  config SI7020
>         tristate "Si7013/20/21 Relative Humidity and Temperature Sensors"
> diff --git a/drivers/iio/humidity/si7005.c b/drivers/iio/humidity/si7005.c
> index 91972cc..98a022f 100644
> --- a/drivers/iio/humidity/si7005.c
> +++ b/drivers/iio/humidity/si7005.c
> @@ -170,6 +170,7 @@ static int si7005_probe(struct i2c_client *client,
>
>  static const struct i2c_device_id si7005_id[] = {
>         { "si7005", 0 },
> +       { "th02", 0 },
>         { }
>  };
>  MODULE_DEVICE_TABLE(i2c, si7005_id);
> --
> 1.9.1
>

[toc] | [prev] | [next] | [standalone]


#1318769

FromDaniel Baluta <daniel.baluta@intel.com>
Date2016-01-27 10:20 +0100
Message-ID<qVuqC-1hZ-19@gated-at.bofh.it>
In reply to#1318453
On Wed, Jan 27, 2016 at 12:56 AM, Matt Ranostay <mranostay@gmail.com> wrote:
> On Tue, Jan 26, 2016 at 12:21 PM, Cristina Moraru
> <cristina.moraru09@gmail.com> wrote:
>> This patch adds support for Hoperf th02 humidity and
>> temperature sensor as it uses same register definitions
>> as si7005
>>
>> th02 Datasheet: http://www.anglia-live.com/netalogue/pdfs/hrf/datasheets/TH02_V1.1.pdf
>>
>> Signed-off-by: Cristina Moraru <cristina.moraru09@gmail.com>
>> ---
>>  drivers/iio/humidity/Kconfig  | 3 ++-
>>  drivers/iio/humidity/si7005.c | 1 +
>>  2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig
>> index c1f3a21..866dda1 100644
>> --- a/drivers/iio/humidity/Kconfig
>> +++ b/drivers/iio/humidity/Kconfig
>> @@ -43,7 +43,8 @@ config SI7005
>>           humidity and temperature sensor.
>>
>>           To compile this driver as a module, choose M here: the module
>> -         will be called si7005.
>> +         will be called si7005. This driver also
>> +         supports Hoperf TH02 Humidity and Temperature Sensor.
>
> This probably shouldn't be changing the Kconfig description. Since if
> every driver added a line for each device/variant it supported
> everything would get quite wordy.

Wordy is good :). We usually add all the supported chips in the Kconfig.
See for example entries for BMC150_ACCEL or IIO_ST_ACCEL_3AXIS.

thanks,
Daniel.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web