Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1317915 > unrolled thread

[PATCH] clk: rockchip: add hclk_cpubus to the list of rk3188 critical clocks

Back to article view | Back to linux.kernel

Contents

  [PATCH] clk: rockchip: add hclk_cpubus to the list of rk3188 critical clocks Alexander Kochetkov <al.kochet@gmail.com> - 2016-01-26 14:40 +0100
    Re: [PATCH] clk: rockchip: add hclk_cpubus to the list of rk3188 critical clocks Heiko Stuebner <heiko@sntech.de> - 2016-01-26 21:30 +0100

#1317915 — [PATCH] clk: rockchip: add hclk_cpubus to the list of rk3188 critical clocks

hclk_cpubus needs to keep running because it is needed for devices like
the rom, i2s0 or spdif to be accessible via cpu. Without that all
accesses to devices (readl/writel) return wrong data. So add it
to the list of critical clocks.

Fixes: 78eaf6095cc763c ("clk: rockchip: disable unused clocks")

Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>

CC: linux-clk@vger.kernel.org
CC: linux-arm-kernel@lists.infradead.org
CC: linux-rockchip@lists.infradead.org
CC: linux-kernel@vger.kernel.org
CC: stable@vger.kernel.org # 4.1.x-
---
 drivers/clk/rockchip/clk-rk3188.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/rockchip/clk-rk3188.c b/drivers/clk/rockchip/clk-rk3188.c
index abb4760..fe728f8 100644
--- a/drivers/clk/rockchip/clk-rk3188.c
+++ b/drivers/clk/rockchip/clk-rk3188.c
@@ -718,6 +718,7 @@ static const char *const rk3188_critical_clocks[] __initconst = {
 	"hclk_peri",
 	"pclk_cpu",
 	"pclk_peri",
+	"hclk_cpubus"
 };
 
 static void __init rk3188_common_clk_init(struct device_node *np)
-- 
1.7.9.5

[toc] | [next] | [standalone]

#1318336

Am Dienstag, 26. Januar 2016, 16:34:00 schrieb Alexander Kochetkov:
> hclk_cpubus needs to keep running because it is needed for devices like
> the rom, i2s0 or spdif to be accessible via cpu. Without that all
> accesses to devices (readl/writel) return wrong data. So add it
> to the list of critical clocks.
> 
> Fixes: 78eaf6095cc763c ("clk: rockchip: disable unused clocks")
> 
> Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>

applied to my clk-branch for 4.6


Thanks
Heiko

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web