Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1315907 > unrolled thread

[PATCH 07/12] perf hists browser: Fix callchain_node__count_rows()

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 07/12] perf hists browser: Fix callchain_node__count_rows() Namhyung Kim <namhyung@kernel.org> - 2016-01-24 15:00 +0100
    Re: [PATCH 07/12] perf hists browser: Fix  callchain_node__count_rows() Jiri Olsa <jolsa@redhat.com> - 2016-01-26 12:50 +0100
      Re: [PATCH 07/12] perf hists browser: Fix  callchain_node__count_rows() Namhyung Kim <namhyung@kernel.org> - 2016-01-26 13:40 +0100

#1315907 — [PATCH 07/12] perf hists browser: Fix callchain_node__count_rows()

Like other functions, it should stop counting if there's any folded
callchain.  Because of this it occasionally lose the cursor at the end.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
 tools/perf/ui/browsers/hists.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index 349c5de73287..c7ca36dae89f 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -215,7 +215,7 @@ static int callchain_node__count_folded_rows(struct callchain_node *node __maybe
 static int callchain_node__count_rows(struct callchain_node *node)
 {
 	struct callchain_list *chain;
-	bool unfolded = false;
+	char folded_sign = ' ';
 	int n = 0;
 
 	if (callchain_param.mode == CHAIN_FLAT)
@@ -225,10 +225,13 @@ static int callchain_node__count_rows(struct callchain_node *node)
 
 	list_for_each_entry(chain, &node->val, list) {
 		++n;
-		unfolded = chain->unfolded;
+
+		folded_sign = callchain_list__folded(chain);
+		if (folded_sign == '+')
+			break;
 	}
 
-	if (unfolded)
+	if (folded_sign == '-')
 		n += callchain_node__count_rows_rb_tree(node);
 
 	return n;
-- 
2.6.4

[toc] | [next] | [standalone]

#1317775 — Re: [PATCH 07/12] perf hists browser: Fix callchain_node__count_rows()

On Sun, Jan 24, 2016 at 10:53:30PM +0900, Namhyung Kim wrote:
> Like other functions, it should stop counting if there's any folded
> callchain.  Because of this it occasionally lose the cursor at the end.

are you reffering to the case when the browser wouldn't jump
to the last entry, but the cursor disappears instead, and then
shows up after holding 'UP' arrow?  

because I've seen that occasionaly ;-)

jirka

[toc] | [prev] | [next] | [standalone]

#1317838 — Re: [PATCH 07/12] perf hists browser: Fix callchain_node__count_rows()

Hi Jiri,

On Tue, Jan 26, 2016 at 12:46:38PM +0100, Jiri Olsa wrote:
> On Sun, Jan 24, 2016 at 10:53:30PM +0900, Namhyung Kim wrote:
> > Like other functions, it should stop counting if there's any folded
> > callchain.  Because of this it occasionally lose the cursor at the end.
> 
> are you reffering to the case when the browser wouldn't jump
> to the last entry, but the cursor disappears instead, and then
> shows up after holding 'UP' arrow?  

Right.  Since it counts some of folded callchain nodes, the cursor
went beyond the end so nothing was shown for them.

> 
> because I've seen that occasionaly ;-)

Me too.

Thanks,
Namhyung

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web