Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1320925 > unrolled thread
| Started by | Luis Henriques <luis.henriques@canonical.com> |
|---|---|
| First post | 2016-01-28 19:00 +0100 |
| Last post | 2016-02-02 18:40 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 3.14 30/59] xhci: refuse loading if nousb is used Luis Henriques <luis.henriques@canonical.com> - 2016-01-28 19:00 +0100
Re: [PATCH 3.14 30/59] xhci: refuse loading if nousb is used Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-01-31 20:20 +0100
Re: [PATCH 3.14 30/59] xhci: refuse loading if nousb is used Luis Henriques <luis.henriques@canonical.com> - 2016-02-02 18:40 +0100
| From | Luis Henriques <luis.henriques@canonical.com> |
|---|---|
| Date | 2016-01-28 19:00 +0100 |
| Subject | Re: [PATCH 3.14 30/59] xhci: refuse loading if nousb is used |
| Message-ID | <qVZ1o-6V6-7@gated-at.bofh.it> |
On Wed, Jan 27, 2016 at 10:15:18AM -0800, Greg Kroah-Hartman wrote:
> 3.14-stable review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Oliver Neukum <oneukum@suse.com>
>
> commit 1eaf35e4dd592c59041bc1ed3248c46326da1f5f upstream.
>
> The module should fail to load.
>
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> ---
> drivers/usb/host/xhci.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -4893,6 +4893,10 @@ static int __init xhci_hcd_init(void)
> BUILD_BUG_ON(sizeof(struct xhci_intr_reg) != 8*32/8);
> /* xhci_run_regs has eight fields and embeds 128 xhci_intr_regs */
> BUILD_BUG_ON(sizeof(struct xhci_run_regs) != (8+8*128)*32/8);
> +
> + if (usb_disabled())
> + return -ENODEV;
> +
I believe the error path should actually call xhci_unregister_pci().
Something like the patch below. The same is applies to the 3.10
kernel.
Cheers,
--
Luís
> return 0;
> unreg_pci:
> xhci_unregister_pci();
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
From 870b9e9479b67df493e2ca3c763102b10d4dd9da Mon Sep 17 00:00:00 2001
From: Oliver Neukum <oneukum@suse.com>
Date: Thu, 3 Dec 2015 15:03:34 +0100
Subject: xhci: refuse loading if nousb is used
commit 1eaf35e4dd592c59041bc1ed3248c46326da1f5f upstream.
The module should fail to load.
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[ luis: need to call xhci_unregister_pci() in the error path ]
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
---
drivers/usb/host/xhci.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 20209e870a99..4c78dc564b3a 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -4955,6 +4955,12 @@ static int __init xhci_hcd_init(void)
BUILD_BUG_ON(sizeof(struct xhci_intr_reg) != 8*32/8);
/* xhci_run_regs has eight fields and embeds 128 xhci_intr_regs */
BUILD_BUG_ON(sizeof(struct xhci_run_regs) != (8+8*128)*32/8);
+
+ if (usb_disabled()) {
+ retval = -ENODEV;
+ goto unreg_pci;
+ }
+
return 0;
unreg_pci:
xhci_unregister_pci();
[toc] | [next] | [standalone]
| From | Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-01-31 20:20 +0100 |
| Message-ID | <qX5Hs-7SQ-13@gated-at.bofh.it> |
| In reply to | #1320925 |
On Thu, Jan 28, 2016 at 05:57:35PM +0000, Luis Henriques wrote:
> On Wed, Jan 27, 2016 at 10:15:18AM -0800, Greg Kroah-Hartman wrote:
> > 3.14-stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Oliver Neukum <oneukum@suse.com>
> >
> > commit 1eaf35e4dd592c59041bc1ed3248c46326da1f5f upstream.
> >
> > The module should fail to load.
> >
> > Signed-off-by: Oliver Neukum <oneukum@suse.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> > ---
> > drivers/usb/host/xhci.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > --- a/drivers/usb/host/xhci.c
> > +++ b/drivers/usb/host/xhci.c
> > @@ -4893,6 +4893,10 @@ static int __init xhci_hcd_init(void)
> > BUILD_BUG_ON(sizeof(struct xhci_intr_reg) != 8*32/8);
> > /* xhci_run_regs has eight fields and embeds 128 xhci_intr_regs */
> > BUILD_BUG_ON(sizeof(struct xhci_run_regs) != (8+8*128)*32/8);
> > +
> > + if (usb_disabled())
> > + return -ENODEV;
> > +
>
> I believe the error path should actually call xhci_unregister_pci().
> Something like the patch below. The same is applies to the 3.10
> kernel.
>
> Cheers,
> --
> Luís
>
> > return 0;
> > unreg_pci:
> > xhci_unregister_pci();
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe stable" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> >From 870b9e9479b67df493e2ca3c763102b10d4dd9da Mon Sep 17 00:00:00 2001
> From: Oliver Neukum <oneukum@suse.com>
> Date: Thu, 3 Dec 2015 15:03:34 +0100
> Subject: xhci: refuse loading if nousb is used
>
> commit 1eaf35e4dd592c59041bc1ed3248c46326da1f5f upstream.
>
> The module should fail to load.
>
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> [ luis: need to call xhci_unregister_pci() in the error path ]
> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
> ---
> drivers/usb/host/xhci.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 20209e870a99..4c78dc564b3a 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -4955,6 +4955,12 @@ static int __init xhci_hcd_init(void)
> BUILD_BUG_ON(sizeof(struct xhci_intr_reg) != 8*32/8);
> /* xhci_run_regs has eight fields and embeds 128 xhci_intr_regs */
> BUILD_BUG_ON(sizeof(struct xhci_run_regs) != (8+8*128)*32/8);
> +
> + if (usb_disabled()) {
> + retval = -ENODEV;
> + goto unreg_pci;
> + }
No, we should move the check much higher up to the top of the function,
which makes it simpler. I'll go do that instead, thanks.
greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Luis Henriques <luis.henriques@canonical.com> |
|---|---|
| Date | 2016-02-02 18:40 +0100 |
| Message-ID | <qXN5N-6qA-37@gated-at.bofh.it> |
| In reply to | #1322717 |
On Sun, Jan 31, 2016 at 11:10:14AM -0800, Greg Kroah-Hartman wrote: > > No, we should move the check much higher up to the top of the function, > which makes it simpler. I'll go do that instead, thanks. > Ok, that makes sense. I'll use a similar solution for the 3.16 kernel backport. Thanks. Cheers, -- Luís
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web