Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1320353 > unrolled thread

Re: [PATCH v8 0/5] mfd: tps65912: Driver rewrite with DT support

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v8 0/5] mfd: tps65912: Driver rewrite with DT support Lee Jones <lee.jones@linaro.org> - 2016-01-28 07:50 +0100
    Re: [PATCH v8 0/5] mfd: tps65912: Driver rewrite with DT support Mark Brown <broonie@kernel.org> - 2016-01-28 12:50 +0100
      Re: [PATCH v8 0/5] mfd: tps65912: Driver rewrite with DT support Lee Jones <lee.jones@linaro.org> - 2016-01-28 13:10 +0100
        Re: [PATCH v8 0/5] mfd: tps65912: Driver rewrite with DT support Mark Brown <broonie@kernel.org> - 2016-01-28 13:50 +0100
          Re: [PATCH v8 0/5] mfd: tps65912: Driver rewrite with DT support Lee Jones <lee.jones@linaro.org> - 2016-01-28 14:40 +0100
            Re: [PATCH v8 0/5] mfd: tps65912: Driver rewrite with DT support "Andrew F. Davis" <afd@ti.com> - 2016-02-02 16:10 +0100
              Re: [PATCH v8 0/5] mfd: tps65912: Driver rewrite with DT support "Andrew F. Davis" <afd@ti.com> - 2016-02-06 17:30 +0100

#1320353 — Re: [PATCH v8 0/5] mfd: tps65912: Driver rewrite with DT support

Mark,

Just need your stamp for this to go in.

> In an effort to cleanup this driver and add Device Tree support
> the driver has been rewritten based on new driver styles and
> modern kernel driver helpers. This has nearly halved the lines
> of code while keeping all previous functionality.
> 
> Platform file based initialization has been dropped as there is
> no examples of this use in the kernel.
> 
> v1 can be found here: [1] v2: [2] v3: [3] v4: [4] v5: [5] v6: [6] v7: [7]
> 
> Changes from v7:
>  - Now complies with gpiolib changes
> 
> Changes from v6:
>  - Removed compatible strings from DT sub-nodes
>  - Rearranged DT bindings
>  - Small fixes
> 
> Changes from v5:
>  - Small formatting changes to DT Docs
>  - Converted to_tps65912_gpio from macro to inline function
> 
> Changes from v4:
>  - Use mfd core to add sub-devices
> 
> Changes from v3:
>  - Reorganized regulator driver and related DT node
>  - Other small fixes as discussed in v3 thread
> 
> Changes from v2:
>  - Split the series further into subsystems
> 
> Changes from v1:
>  - Split the rewrite into delete/create patches
>  - Several small fixes as discussed in v1 thread
> 
> [1] http://www.spinics.net/lists/devicetree/msg93863.html
> [2] http://www.spinics.net/lists/devicetree/msg95003.html
> [3] http://www.spinics.net/lists/devicetree/msg95133.html
> [4] http://www.spinics.net/lists/devicetree/msg96109.html
> [5] http://www.spinics.net/lists/devicetree/msg100601.html
> [6] https://lkml.org/lkml/2015/10/30/690
> [7] https://www.spinics.net/lists/linux-gpio/msg09710.html
> 
> Andrew F. Davis (5):
>   Documentation: tps65912: Add DT bindings for the TPS65912 PMIC
>   mfd: tps65912: Remove old driver in preparation for new driver
>   mfd: tps65912: Add driver for the TPS65912 PMIC
>   regulator: tps65912: Add regulator driver for the TPS65912 PMIC
>   gpio: tps65912: Add GPIO driver for the TPS65912 PMIC
> 
>  Documentation/devicetree/bindings/mfd/tps65912.txt |  50 ++
>  drivers/gpio/Kconfig                               |   2 +-
>  drivers/gpio/gpio-tps65912.c                       | 309 ++++-----
>  drivers/mfd/Kconfig                                |  20 +-
>  drivers/mfd/Makefile                               |   3 +-
>  drivers/mfd/tps65912-core.c                        | 286 ++++-----
>  drivers/mfd/tps65912-i2c.c                         | 218 +++----
>  drivers/mfd/tps65912-irq.c                         | 217 -------
>  drivers/mfd/tps65912-spi.c                         | 218 +++----
>  drivers/regulator/Kconfig                          |   2 +-
>  drivers/regulator/tps65912-regulator.c             | 709 +++++----------------
>  include/linux/mfd/tps65912.h                       | 209 +++---
>  12 files changed, 767 insertions(+), 1476 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/mfd/tps65912.txt
>  rewrite drivers/gpio/gpio-tps65912.c (74%)
>  rewrite drivers/mfd/tps65912-core.c (96%)
>  rewrite drivers/mfd/tps65912-i2c.c (93%)
>  delete mode 100644 drivers/mfd/tps65912-irq.c
>  rewrite drivers/mfd/tps65912-spi.c (92%)
>  rewrite drivers/regulator/tps65912-regulator.c (94%)
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [next] | [standalone]

#1320603

[Multipart message — attachments visible in raw view] — view raw

On Thu, Jan 28, 2016 at 06:41:49AM +0000, Lee Jones wrote:

> Just need your stamp for this to go in.

Please be more specific?  What is it that you are looking for beyond the
review I already did for the regulator driver?

[toc] | [prev] | [next] | [standalone]

#1320612

On Thu, 28 Jan 2016, Mark Brown wrote:

> On Thu, Jan 28, 2016 at 06:41:49AM +0000, Lee Jones wrote:
> 
> > Just need your stamp for this to go in.
> 
> Please be more specific?  What is it that you are looking for beyond the
> review I already did for the regulator driver?

Patch 2.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [next] | [standalone]

#1320638

[Multipart message — attachments visible in raw view] — view raw

On Thu, Jan 28, 2016 at 12:04:23PM +0000, Lee Jones wrote:
> On Thu, 28 Jan 2016, Mark Brown wrote:

> > Please be more specific?  What is it that you are looking for beyond the
> > review I already did for the regulator driver?

> Patch 2.

I reviewed that *ages* ago.

[toc] | [prev] | [next] | [standalone]

#1320677

On Thu, 28 Jan 2016, Mark Brown wrote:

> On Thu, Jan 28, 2016 at 12:04:23PM +0000, Lee Jones wrote:
> > On Thu, 28 Jan 2016, Mark Brown wrote:
> 
> > > Please be more specific?  What is it that you are looking for beyond the
> > > review I already did for the regulator driver?
> 
> > Patch 2.
> 
> I reviewed that *ages* ago.

Link or it didn't happen. ;)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [next] | [standalone]

#1324182

On 01/28/2016 07:30 AM, Lee Jones wrote:
> On Thu, 28 Jan 2016, Mark Brown wrote:
>
>> On Thu, Jan 28, 2016 at 12:04:23PM +0000, Lee Jones wrote:
>>> On Thu, 28 Jan 2016, Mark Brown wrote:
>>
>>>> Please be more specific?  What is it that you are looking for beyond the
>>>> review I already did for the regulator driver?
>>
>>> Patch 2.
>>
>> I reviewed that *ages* ago.
>
> Link or it didn't happen. ;)
>

Might be best to take his ack for the new regulator driver
as approval to remove the old one. :)

[toc] | [prev] | [next] | [standalone]

#1328335

On 02/02/2016 09:03 AM, Andrew F. Davis wrote:
> On 01/28/2016 07:30 AM, Lee Jones wrote:
>> On Thu, 28 Jan 2016, Mark Brown wrote:
>>
>>> On Thu, Jan 28, 2016 at 12:04:23PM +0000, Lee Jones wrote:
>>>> On Thu, 28 Jan 2016, Mark Brown wrote:
>>>
>>>>> Please be more specific?  What is it that you are looking for beyond the
>>>>> review I already did for the regulator driver?
>>>
>>>> Patch 2.
>>>
>>> I reviewed that *ages* ago.
>>
>> Link or it didn't happen. ;)
>>
>
> Might be best to take his ack for the new regulator driver
> as approval to remove the old one. :)

If not, is there anything I can do to help keep this from getting
delayed another cycle?

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web