Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1320492 > unrolled thread

Re: [PATCH V4 3/5] pinctrl: max77620: add pincontrol driver for MAX77620/MAX20024

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH V4 3/5] pinctrl: max77620: add pincontrol driver for MAX77620/MAX20024 Linus Walleij <linus.walleij@linaro.org> - 2016-01-28 11:10 +0100
    Re: [PATCH V4 3/5] pinctrl: max77620: add pincontrol driver for MAX77620/MAX20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-28 11:30 +0100

#1320492 — Re: [PATCH V4 3/5] pinctrl: max77620: add pincontrol driver for MAX77620/MAX20024

On Tue, Jan 19, 2016 at 11:19 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:

> MAXIM Semiconductor's PMIC, MAX77620/MAX20024 has 8 GPIO pins
> which also act as the special function in alternate mode. Also
> there is configuration like push-pull, open drain, FPS timing
> etc for these pins.
>
> Add pincontrol driver to configure these parameters through
> pincontrol APIs.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Chaitanya Bandi <bandik@nvidia.com>

Nice. This driver looks like a lot of hard work, but I think
it's worth it.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

I guess Lee will be merging this into the MTD tree.

(I still had those comments on the DT bindings but this driver
part looks fine.)

Yours,
Linus Walleij

[toc] | [next] | [standalone]

#1320526

On Thursday 28 January 2016 03:34 PM, Linus Walleij wrote:
> On Tue, Jan 19, 2016 at 11:19 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
>
>> MAXIM Semiconductor's PMIC, MAX77620/MAX20024 has 8 GPIO pins
>> which also act as the special function in alternate mode. Also
>> there is configuration like push-pull, open drain, FPS timing
>> etc for these pins.
>>
>> Add pincontrol driver to configure these parameters through
>> pincontrol APIs.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> Signed-off-by: Chaitanya Bandi <bandik@nvidia.com>
> Nice. This driver looks like a lot of hard work, but I think
> it's worth it.
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Thank you very much for acknowledgement.

> I guess Lee will be merging this into the MTD tree.
>
> (I still had those comments on the DT bindings but this driver
> part looks fine.)
>
>
I have posted patch V5 for enhancing DT binding doc as suggested by you 
and Lee. Request you to help on review.

I am going to send V6 to separate out DT binding doc patch with the 
driver file which I did in V5 and so want to correct if there is any 
more pending on document enhancement.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web