Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1320417 > unrolled thread
| Started by | Shawn Guo <shawnguo@kernel.org> |
|---|---|
| First post | 2016-01-28 09:40 +0100 |
| Last post | 2016-01-28 23:40 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] ARM: dts: vf-colibri-eval-v3: Use enable-gpios for BL_ON Shawn Guo <shawnguo@kernel.org> - 2016-01-28 09:40 +0100
Re: [PATCH] ARM: dts: vf-colibri-eval-v3: Use enable-gpios for BL_ON Stefan Agner <stefan@agner.ch> - 2016-01-28 23:40 +0100
| From | Shawn Guo <shawnguo@kernel.org> |
|---|---|
| Date | 2016-01-28 09:40 +0100 |
| Subject | Re: [PATCH] ARM: dts: vf-colibri-eval-v3: Use enable-gpios for BL_ON |
| Message-ID | <qVQhs-Jf-15@gated-at.bofh.it> |
On Sat, Jan 09, 2016 at 12:29:53PM +0530, Bhuvanchandra DV wrote:
> Use pwm-backlight driver 'enable-gpios' property for backlight on/off
> control.
>
> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
> ---
> arch/arm/boot/dts/vf-colibri.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vf-colibri.dtsi b/arch/arm/boot/dts/vf-colibri.dtsi
> index e5949b9..1c0da05 100644
> --- a/arch/arm/boot/dts/vf-colibri.dtsi
> +++ b/arch/arm/boot/dts/vf-colibri.dtsi
> @@ -10,7 +10,10 @@
> / {
> bl: backlight {
> compatible = "pwm-backlight";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_gpio_bl_on>;
> pwms = <&pwm0 0 5000000 0>;
> + enable-gpios = <&gpio1 13 GPIO_ACTIVE_HIGH>;
> status = "disabled";
> };
> };
> @@ -169,6 +172,12 @@
> >;
> };
>
> + pinctrl_gpio_bl_on: gpio_bl_on {
> + fsl,pins = <
> + VF610_PAD_PTC0__GPIO_45 0x22ef
> + >;
> + };
> +
@Stefan,
Do we need this? My understanding is that on Vybrid, when gpio is
requested, the pinctrl will set it up automatically.
Shawn
> pinctrl_i2c0: i2c0grp {
> fsl,pins = <
> VF610_PAD_PTB14__I2C0_SCL 0x37ff
> --
> 2.7.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
[toc] | [next] | [standalone]
| From | Stefan Agner <stefan@agner.ch> |
|---|---|
| Date | 2016-01-28 23:40 +0100 |
| Message-ID | <qW3ol-1FK-7@gated-at.bofh.it> |
| In reply to | #1320417 |
On 2016-01-28 00:39, Shawn Guo wrote:
> On Sat, Jan 09, 2016 at 12:29:53PM +0530, Bhuvanchandra DV wrote:
>> Use pwm-backlight driver 'enable-gpios' property for backlight on/off
>> control.
>>
>> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
>> ---
>> arch/arm/boot/dts/vf-colibri.dtsi | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/vf-colibri.dtsi b/arch/arm/boot/dts/vf-colibri.dtsi
>> index e5949b9..1c0da05 100644
>> --- a/arch/arm/boot/dts/vf-colibri.dtsi
>> +++ b/arch/arm/boot/dts/vf-colibri.dtsi
>> @@ -10,7 +10,10 @@
>> / {
>> bl: backlight {
>> compatible = "pwm-backlight";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_gpio_bl_on>;
>> pwms = <&pwm0 0 5000000 0>;
>> + enable-gpios = <&gpio1 13 GPIO_ACTIVE_HIGH>;
>> status = "disabled";
>> };
>> };
>> @@ -169,6 +172,12 @@
>> >;
>> };
>>
>> + pinctrl_gpio_bl_on: gpio_bl_on {
>> + fsl,pins = <
>> + VF610_PAD_PTC0__GPIO_45 0x22ef
>> + >;
>> + };
>> +
>
> @Stefan,
>
> Do we need this? My understanding is that on Vybrid, when gpio is
> requested, the pinctrl will set it up automatically.
Yes this is required. The GPIO driver asks the pinctrl driver to enable
the GPIO, and the pinctrl driver requires a "valid" pinmux configuration
to be able to find the IOMUXC register at all.
Acked-by: Stefan Agner <stefan@agner.ch>
--
Stefan
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web