Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1320457 > unrolled thread

[PATCH] mm: provide reference to READ_IMPLIES_EXEC

Started bySudip Mukherjee <sudipm.mukherjee@gmail.com>
First post2016-01-28 10:20 +0100
Last post2016-01-28 16:30 +0100
Articles 4 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] mm: provide reference to READ_IMPLIES_EXEC Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-28 10:20 +0100
    Re: [PATCH] mm: provide reference to READ_IMPLIES_EXEC Konstantin Khlebnikov <koct9i@gmail.com> - 2016-01-28 10:40 +0100
    Re: mm: provide reference to READ_IMPLIES_EXEC Guenter Roeck <linux@roeck-us.net> - 2016-01-28 15:40 +0100
      Re: mm: provide reference to READ_IMPLIES_EXEC Konstantin Khlebnikov <koct9i@gmail.com> - 2016-01-28 16:30 +0100

#1320457 — [PATCH] mm: provide reference to READ_IMPLIES_EXEC

FromSudip Mukherjee <sudipm.mukherjee@gmail.com>
Date2016-01-28 10:20 +0100
Subject[PATCH] mm: provide reference to READ_IMPLIES_EXEC
Message-ID<qVQU9-1eY-1@gated-at.bofh.it>
blackfin defconfig fails with the error:
mm/internal.h: In function 'is_stack_mapping':
arch/blackfin/include/asm/page.h:15:27: error: 'READ_IMPLIES_EXEC' undeclared

Commit 07dff8ae2bc5 has added is_stack_mapping in mm/internal.h but it
also needs personality.h.

Fixes: 07dff8ae2bc5 ("mm: warn about VmData over RLIMIT_DATA")
Cc: Konstantin Khlebnikov <koct9i@gmail.com>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---

build log at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/105335848

 mm/internal.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/internal.h b/mm/internal.h
index cac6eb4..59c496f 100644
--- a/mm/internal.h
+++ b/mm/internal.h
@@ -14,6 +14,7 @@
 #include <linux/fs.h>
 #include <linux/mm.h>
 #include <linux/pagemap.h>
+#include <linux/personality.h>
 #include <linux/tracepoint-defs.h>
 
 /*
-- 
1.9.1

[toc] | [next] | [standalone]

#1320470

FromKonstantin Khlebnikov <koct9i@gmail.com>
Date2016-01-28 10:40 +0100
Message-ID<qVRdw-1om-3@gated-at.bofh.it>
In reply to#1320457
On Thu, Jan 28, 2016 at 12:11 PM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> blackfin defconfig fails with the error:
> mm/internal.h: In function 'is_stack_mapping':
> arch/blackfin/include/asm/page.h:15:27: error: 'READ_IMPLIES_EXEC' undeclared
>
> Commit 07dff8ae2bc5 has added is_stack_mapping in mm/internal.h but it
> also needs personality.h.

I have different patch which should fix this too.
It removes usage of VM_STACK_DEFAULT_FLAGS from that file.

>
> Fixes: 07dff8ae2bc5 ("mm: warn about VmData over RLIMIT_DATA")
> Cc: Konstantin Khlebnikov <koct9i@gmail.com>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
>
> build log at:
> https://travis-ci.org/sudipm-mukherjee/parport/jobs/105335848
>
>  mm/internal.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/mm/internal.h b/mm/internal.h
> index cac6eb4..59c496f 100644
> --- a/mm/internal.h
> +++ b/mm/internal.h
> @@ -14,6 +14,7 @@
>  #include <linux/fs.h>
>  #include <linux/mm.h>
>  #include <linux/pagemap.h>
> +#include <linux/personality.h>
>  #include <linux/tracepoint-defs.h>
>
>  /*
> --
> 1.9.1
>

[toc] | [prev] | [next] | [standalone]

#1320735 — Re: mm: provide reference to READ_IMPLIES_EXEC

FromGuenter Roeck <linux@roeck-us.net>
Date2016-01-28 15:40 +0100
SubjectRe: mm: provide reference to READ_IMPLIES_EXEC
Message-ID<qVVTQ-4Lm-17@gated-at.bofh.it>
In reply to#1320457
On Thu, Jan 28, 2016 at 02:41:03PM +0530, Sudip Mukherjee wrote:
> blackfin defconfig fails with the error:
> mm/internal.h: In function 'is_stack_mapping':
> arch/blackfin/include/asm/page.h:15:27: error: 'READ_IMPLIES_EXEC' undeclared
> 
> Commit 07dff8ae2bc5 has added is_stack_mapping in mm/internal.h but it
> also needs personality.h.
> 
> Fixes: 07dff8ae2bc5 ("mm: warn about VmData over RLIMIT_DATA")

FWIW, this is just one of many build failures due to this patch.
Pretty much all non-MMU builds fail, plus several MMU builds.
I had prepared a patch for mn10300, but gave up after I noticed
all the other failures.

Build results in next-20160128:
	total: 146 pass: 121 fail: 25
Failed builds:
	alpha:allmodconfig
	arm64:allnoconfig
	arm64:allmodconfig
	avr32:defconfig
	avr32:merisc_defconfig
	avr32:atngw100mkii_evklcd101_defconfig
	blackfin:defconfig
	blackfin:BF561-EZKIT-SMP_defconfig
	c6x:dsk6455_defconfig
	c6x:evmc6457_defconfig
	c6x:evmc6678_defconfig
	frv:defconfig
	ia64:defconfig
	ia64:allnoconfig
	m68k:allmodconfig
	microblaze:nommu_defconfig
	microblaze:allnoconfig
	mn10300:asb2303_defconfig
	mn10300:asb2364_defconfig
	parisc:allmodconfig
	powerpc:ppc6xx_defconfig
	s390:defconfig
	s390:allmodconfig
	s390:allnoconfig
	xtensa:allmodconfig
Qemu test results:
	total: 96 pass: 83 fail: 13
Failed tests:
	arm:kzm:imx_v6_v7_defconfig
	arm64:smp:defconfig
	arm64:nosmp:defconfig
	microblaze:microblaze_defconfig
	microblaze:microblazeel_defconfig
	powerpc:mac99:ppc_book3s_defconfig
	powerpc:mpc8544ds:mpc85xx_smp_defconfig
	powerpc:smp4:ppc64_book3s_defconfig
	powerpc:nosmp:ppc64_e5500_defconfig
	powerpc:smp:ppc64_e5500_defconfig
	s390:defconfig
	sparc64:sun4u:nosmp:sparc64_defconfig
	sparc64:sun4v:nosmp:sparc64_defconfig

Not all, but most of the failures are due to 07dff8ae2bc5.

Guenter

[toc] | [prev] | [next] | [standalone]

#1320784 — Re: mm: provide reference to READ_IMPLIES_EXEC

FromKonstantin Khlebnikov <koct9i@gmail.com>
Date2016-01-28 16:30 +0100
SubjectRe: mm: provide reference to READ_IMPLIES_EXEC
Message-ID<qVWGe-5of-9@gated-at.bofh.it>
In reply to#1320735
On Thu, Jan 28, 2016 at 5:38 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> On Thu, Jan 28, 2016 at 02:41:03PM +0530, Sudip Mukherjee wrote:
>> blackfin defconfig fails with the error:
>> mm/internal.h: In function 'is_stack_mapping':
>> arch/blackfin/include/asm/page.h:15:27: error: 'READ_IMPLIES_EXEC' undeclared
>>
>> Commit 07dff8ae2bc5 has added is_stack_mapping in mm/internal.h but it
>> also needs personality.h.
>>
>> Fixes: 07dff8ae2bc5 ("mm: warn about VmData over RLIMIT_DATA")
>
> FWIW, this is just one of many build failures due to this patch.
> Pretty much all non-MMU builds fail, plus several MMU builds.
> I had prepared a patch for mn10300, but gave up after I noticed
> all the other failures.

Please try mine "[PATCH] mm: polish virtual memory accounting"
instead of that. It should fix some (or all) fails from 07dff8ae2bc5.

>
> Build results in next-20160128:
>         total: 146 pass: 121 fail: 25
> Failed builds:
>         alpha:allmodconfig
>         arm64:allnoconfig
>         arm64:allmodconfig
>         avr32:defconfig
>         avr32:merisc_defconfig
>         avr32:atngw100mkii_evklcd101_defconfig
>         blackfin:defconfig
>         blackfin:BF561-EZKIT-SMP_defconfig
>         c6x:dsk6455_defconfig
>         c6x:evmc6457_defconfig
>         c6x:evmc6678_defconfig
>         frv:defconfig
>         ia64:defconfig
>         ia64:allnoconfig
>         m68k:allmodconfig
>         microblaze:nommu_defconfig
>         microblaze:allnoconfig
>         mn10300:asb2303_defconfig
>         mn10300:asb2364_defconfig
>         parisc:allmodconfig
>         powerpc:ppc6xx_defconfig
>         s390:defconfig
>         s390:allmodconfig
>         s390:allnoconfig
>         xtensa:allmodconfig
> Qemu test results:
>         total: 96 pass: 83 fail: 13
> Failed tests:
>         arm:kzm:imx_v6_v7_defconfig
>         arm64:smp:defconfig
>         arm64:nosmp:defconfig
>         microblaze:microblaze_defconfig
>         microblaze:microblazeel_defconfig
>         powerpc:mac99:ppc_book3s_defconfig
>         powerpc:mpc8544ds:mpc85xx_smp_defconfig
>         powerpc:smp4:ppc64_book3s_defconfig
>         powerpc:nosmp:ppc64_e5500_defconfig
>         powerpc:smp:ppc64_e5500_defconfig
>         s390:defconfig
>         sparc64:sun4u:nosmp:sparc64_defconfig
>         sparc64:sun4v:nosmp:sparc64_defconfig
>
> Not all, but most of the failures are due to 07dff8ae2bc5.
>
> Guenter

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web