Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1316284 > unrolled thread

Re: [PATCH] storvsc: use small sg_tablesize on x86

Started byOlaf Hering <olaf@aepfle.de>
First post2016-01-25 09:40 +0100
Last post2016-01-28 16:40 +0100
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] storvsc: use small sg_tablesize on x86 Olaf Hering <olaf@aepfle.de> - 2016-01-25 09:40 +0100
    RE: [PATCH] storvsc: use small sg_tablesize on x86 KY Srinivasan <kys@microsoft.com> - 2016-01-28 00:10 +0100
      Re: [PATCH] storvsc: use small sg_tablesize on x86 James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-01-28 07:10 +0100
        Re: [PATCH] storvsc: use small sg_tablesize on x86 Olaf Hering <olaf@aepfle.de> - 2016-01-28 07:50 +0100
          Re: [PATCH] storvsc: use small sg_tablesize on x86 James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-01-28 16:40 +0100

#1316284 — Re: [PATCH] storvsc: use small sg_tablesize on x86

FromOlaf Hering <olaf@aepfle.de>
Date2016-01-25 09:40 +0100
SubjectRe: [PATCH] storvsc: use small sg_tablesize on x86
Message-ID<qUKQP-1ei-33@gated-at.bofh.it>
On Fri, Oct 02, Olaf Hering wrote:

> On Thu, Oct 01, James Bottomley wrote:
> 
> > On Thu, 2015-10-01 at 20:30 +0000, KY Srinivasan wrote:
> 
> > > > +#if defined(CONFIG_X86_32)
> 
> > Um, this is a bit architecture specific (I know Azure is x86, but
> > still).  Can you make the define check CONFIG_32BIT rather than
> > CONFIG_X86_32?
> 
> According to arch/x86/Kconfig there is no such thing.

What is the status of this change? Looks like there is nothing more to
do on my side.

Olaf

[toc] | [next] | [standalone]

#1320124

FromKY Srinivasan <kys@microsoft.com>
Date2016-01-28 00:10 +0100
Message-ID<qVHnP-2DE-11@gated-at.bofh.it>
In reply to#1316284

> -----Original Message-----
> From: Olaf Hering [mailto:olaf@aepfle.de]
> Sent: Monday, January 25, 2016 12:35 AM
> To: James Bottomley <James.Bottomley@HansenPartnership.com>
> Cc: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> <haiyangz@microsoft.com>; linux-kernel@vger.kernel.org; linux-
> scsi@vger.kernel.org
> Subject: Re: [PATCH] storvsc: use small sg_tablesize on x86
> 
> On Fri, Oct 02, Olaf Hering wrote:
> 
> > On Thu, Oct 01, James Bottomley wrote:
> >
> > > On Thu, 2015-10-01 at 20:30 +0000, KY Srinivasan wrote:
> >
> > > > > +#if defined(CONFIG_X86_32)
> >
> > > Um, this is a bit architecture specific (I know Azure is x86, but
> > > still).  Can you make the define check CONFIG_32BIT rather than
> > > CONFIG_X86_32?
> >
> > According to arch/x86/Kconfig there is no such thing.
> 
> What is the status of this change? Looks like there is nothing more to
> do on my side.

Olaf,

We do have the config option: CONFIG_X86_64. Perhaps we could use this.
Could you resubmit the patch with this change.

Regards,

K. Y

 
> 
> Olaf

[toc] | [prev] | [next] | [standalone]

#1320323

FromJames Bottomley <James.Bottomley@HansenPartnership.com>
Date2016-01-28 07:10 +0100
Message-ID<qVNWi-7D7-13@gated-at.bofh.it>
In reply to#1320124
On Wed, 2016-01-27 at 23:09 +0000, KY Srinivasan wrote:
> 
> > -----Original Message-----
> > From: Olaf Hering [mailto:olaf@aepfle.de]
> > Sent: Monday, January 25, 2016 12:35 AM
> > To: James Bottomley <James.Bottomley@HansenPartnership.com>
> > Cc: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> > <haiyangz@microsoft.com>; linux-kernel@vger.kernel.org; linux-
> > scsi@vger.kernel.org
> > Subject: Re: [PATCH] storvsc: use small sg_tablesize on x86
> > 
> > On Fri, Oct 02, Olaf Hering wrote:
> > 
> > > On Thu, Oct 01, James Bottomley wrote:
> > > 
> > > > On Thu, 2015-10-01 at 20:30 +0000, KY Srinivasan wrote:
> > > 
> > > > > > +#if defined(CONFIG_X86_32)
> > > 
> > > > Um, this is a bit architecture specific (I know Azure is x86,
> > > > but
> > > > still).  Can you make the define check CONFIG_32BIT rather than
> > > > CONFIG_X86_32?
> > > 
> > > According to arch/x86/Kconfig there is no such thing.
> > 
> > What is the status of this change? Looks like there is nothing more 
> > to do on my side.
> 
> Olaf,
> 
> We do have the config option: CONFIG_X86_64. Perhaps we could use 
> this. Could you resubmit the patch with this change.

It's not really architecture independent, is it?  Just use the bit
width config.

James

[toc] | [prev] | [next] | [standalone]

#1320348

FromOlaf Hering <olaf@aepfle.de>
Date2016-01-28 07:50 +0100
Message-ID<qVOyZ-7VI-5@gated-at.bofh.it>
In reply to#1320323
On Wed, Jan 27, James Bottomley wrote:

> It's not really architecture independent, is it?  Just use the bit
> width config.

Again: which one? This driver is not for mips|powerpc|score|sh.

Olaf

[toc] | [prev] | [next] | [standalone]

#1320790

FromJames Bottomley <James.Bottomley@HansenPartnership.com>
Date2016-01-28 16:40 +0100
Message-ID<qVWPU-5sX-5@gated-at.bofh.it>
In reply to#1320348
On Thu, 2016-01-28 at 07:48 +0100, Olaf Hering wrote:
> On Wed, Jan 27, James Bottomley wrote:
> 
> > It's not really architecture independent, is it?  Just use the bit
> > width config.
> 
> Again: which one? This driver is not for mips|powerpc|score|sh.

zgrep CONFIG_.*BIT /proc/config.gz
[...]
CONFIG_64BIT=y

James

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web